summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorXavier Hernandez <jahernan@redhat.com>2018-02-01 16:06:32 +0100
committerPranith Kumar Karampuri <pkarampu@redhat.com>2018-02-03 09:55:50 +0000
commit1edb79b9b4e94083c03055ddba805f51e0349992 (patch)
treea1b39f73433e56ea5ce5b1366ddc31e25d8f5905
parentfe87f3e34fc1c983731a8b84968d49db2b96c824 (diff)
cluster/afr: remove unnecessary child_up initialization
The child_up array was initialized with all elements being -1 to allow afr_notify() to differentiate down bricks from bricks that haven't reported yet. With current implementation this is not needed anymore and it was causing unexpected results when other parts of the code considered that if child_up[i] != 0, it meant that it was up. Change-Id: I2a9d712ee64c512f24bd5cd3a48dcb37e3139472 BUG: 1541038 Signed-off-by: Xavier Hernandez <jahernan@redhat.com>
-rw-r--r--xlators/cluster/afr/src/afr.c7
1 files changed, 0 insertions, 7 deletions
diff --git a/xlators/cluster/afr/src/afr.c b/xlators/cluster/afr/src/afr.c
index 34b4cdd0b8a..10e81138aea 100644
--- a/xlators/cluster/afr/src/afr.c
+++ b/xlators/cluster/afr/src/afr.c
@@ -557,13 +557,6 @@ init (xlator_t *this)
goto out;
}
- for (i = 0; i < child_count; i++)
- priv->child_up[i] = -1; /* start with unknown state.
- this initialization needed
- for afr_notify() to work
- reliably
- */
-
priv->children = GF_CALLOC (sizeof (xlator_t *), child_count,
gf_afr_mt_xlator_t);
if (!priv->children) {