summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorEmmanuel Dreyfus <manu@netbsd.org>2013-10-02 06:07:23 +0200
committerVijay Bellur <vbellur@redhat.com>2013-10-24 05:21:26 -0700
commit02ede06cbb00aef2ad1fbceb8c818c5d649ab512 (patch)
tree22e035025229f7c84d33d2eff6c8c0926cbd1cca
parent71614ecbd96f65273d7a19bc62b1d918a8b36191 (diff)
Disable eager-locks on NetBSD for 3.4 branch
As described in https://bugzilla.redhat.com/show_bug.cgi?id=1005526 eager-locks are broken on release-3.4, at least for NetBSD. This change disable them by default, leaving the admin the possibility to explicitely enable the feature if needed. BUG: 1005526 Change-Id: I6f1b393865b103ec56ad5eb5143f59bb8672f19c Signed-off-by: Emmanuel Dreyfus <manu@netbsd.org> Reviewed-on: http://review.gluster.org/6020 Tested-by: Gluster Build System <jenkins@build.gluster.com> Reviewed-by: Vijay Bellur <vbellur@redhat.com>
-rw-r--r--xlators/cluster/afr/src/afr.c10
1 files changed, 10 insertions, 0 deletions
diff --git a/xlators/cluster/afr/src/afr.c b/xlators/cluster/afr/src/afr.c
index bee10fd..d49a39d 100644
--- a/xlators/cluster/afr/src/afr.c
+++ b/xlators/cluster/afr/src/afr.c
@@ -674,7 +674,17 @@ struct volume_options options[] = {
},
{ .key = {"eager-lock"},
.type = GF_OPTION_TYPE_BOOL,
+#ifdef __NetBSD__
+ /*
+ * eager-locks are broken on NetBSD, and cause spurious
+ * split brain with all NULL pending matrix, as described
+ * in https://bugzilla.redhat.com/show_bug.cgi?id=1005526
+ * We therefore disable them for now
+ */
+ .default_value = "off",
+#else
.default_value = "on",
+#endif
.description = "Lock phase of a transaction has two sub-phases. "
"First is an attempt to acquire locks in parallel by "
"broadcasting non-blocking lock requests. If lock "