From 02ede06cbb00aef2ad1fbceb8c818c5d649ab512 Mon Sep 17 00:00:00 2001 From: Emmanuel Dreyfus Date: Wed, 2 Oct 2013 06:07:23 +0200 Subject: Disable eager-locks on NetBSD for 3.4 branch As described in https://bugzilla.redhat.com/show_bug.cgi?id=1005526 eager-locks are broken on release-3.4, at least for NetBSD. This change disable them by default, leaving the admin the possibility to explicitely enable the feature if needed. BUG: 1005526 Change-Id: I6f1b393865b103ec56ad5eb5143f59bb8672f19c Signed-off-by: Emmanuel Dreyfus Reviewed-on: http://review.gluster.org/6020 Tested-by: Gluster Build System Reviewed-by: Vijay Bellur --- xlators/cluster/afr/src/afr.c | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/xlators/cluster/afr/src/afr.c b/xlators/cluster/afr/src/afr.c index bee10fd01dc..d49a39d781c 100644 --- a/xlators/cluster/afr/src/afr.c +++ b/xlators/cluster/afr/src/afr.c @@ -674,7 +674,17 @@ struct volume_options options[] = { }, { .key = {"eager-lock"}, .type = GF_OPTION_TYPE_BOOL, +#ifdef __NetBSD__ + /* + * eager-locks are broken on NetBSD, and cause spurious + * split brain with all NULL pending matrix, as described + * in https://bugzilla.redhat.com/show_bug.cgi?id=1005526 + * We therefore disable them for now + */ + .default_value = "off", +#else .default_value = "on", +#endif .description = "Lock phase of a transaction has two sub-phases. " "First is an attempt to acquire locks in parallel by " "broadcasting non-blocking lock requests. If lock " -- cgit