summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorAshish Pandey <aspandey@redhat.com>2017-08-10 12:56:32 +0530
committerShyamsundar Ranganathan <srangana@redhat.com>2017-08-12 13:38:51 +0000
commitcdb03a71fe0af131d09046cd673dfc58b4003550 (patch)
treeab77ecb6cb68ca6b5a83825814ab1a1e978b5428
parent22ac7241b2f8c1bb3db2678b8b6b9a364f14876c (diff)
mgmt/glusterd: Provide more information in command message
Problem: When more than one bricks are present on the same node, while creating a volume, we get a warning message that the setup is not optimal. We need to add more information in this error/warning. Solution: Add following line in current message. Bricks should be on different nodes to have best fault tolerant configuration. >Change-Id: Ica72bd6e68dff7e41c37617f3b775a981fa40c69 >BUG: 1480099 >Signed-off-by: Ashish Pandey <aspandey@redhat.com> >Reviewed-on: https://review.gluster.org/18014 >CentOS-regression: Gluster Build System <jenkins@build.gluster.org> >Smoke: Gluster Build System <jenkins@build.gluster.org> >Reviewed-by: Atin Mukherjee <amukherj@redhat.com> >Signed-off-by: Ashish Pandey <aspandey@redhat.com> Change-Id: Ica72bd6e68dff7e41c37617f3b775a981fa40c69 BUG: 1480448 Signed-off-by: Ashish Pandey <aspandey@redhat.com> Reviewed-on: https://review.gluster.org/18022 Reviewed-by: Atin Mukherjee <amukherj@redhat.com> Smoke: Gluster Build System <jenkins@build.gluster.org> CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
-rw-r--r--xlators/mgmt/glusterd/src/glusterd-volume-ops.c8
1 files changed, 5 insertions, 3 deletions
diff --git a/xlators/mgmt/glusterd/src/glusterd-volume-ops.c b/xlators/mgmt/glusterd/src/glusterd-volume-ops.c
index b95b8a4..9ce600e 100644
--- a/xlators/mgmt/glusterd/src/glusterd-volume-ops.c
+++ b/xlators/mgmt/glusterd/src/glusterd-volume-ops.c
@@ -100,9 +100,11 @@ glusterd_check_brick_order(dict_t *dict, char *err_str)
" if you want to override this behavior. ";
const char found_string[2048] = "Multiple bricks of a %s "
"volume are present on the same server. This "
- "setup is not optimal. Use 'force' at the "
- "end of the command if you want to override "
- "this behavior. ";
+ "setup is not optimal. Bricks should be on "
+ "different nodes to have best fault tolerant "
+ "configuration. Use 'force' at the end of the "
+ "command if you want to override this "
+ "behavior. ";
this = THIS;