From cdb03a71fe0af131d09046cd673dfc58b4003550 Mon Sep 17 00:00:00 2001 From: Ashish Pandey Date: Thu, 10 Aug 2017 12:56:32 +0530 Subject: mgmt/glusterd: Provide more information in command message Problem: When more than one bricks are present on the same node, while creating a volume, we get a warning message that the setup is not optimal. We need to add more information in this error/warning. Solution: Add following line in current message. Bricks should be on different nodes to have best fault tolerant configuration. >Change-Id: Ica72bd6e68dff7e41c37617f3b775a981fa40c69 >BUG: 1480099 >Signed-off-by: Ashish Pandey >Reviewed-on: https://review.gluster.org/18014 >CentOS-regression: Gluster Build System >Smoke: Gluster Build System >Reviewed-by: Atin Mukherjee >Signed-off-by: Ashish Pandey Change-Id: Ica72bd6e68dff7e41c37617f3b775a981fa40c69 BUG: 1480448 Signed-off-by: Ashish Pandey Reviewed-on: https://review.gluster.org/18022 Reviewed-by: Atin Mukherjee Smoke: Gluster Build System CentOS-regression: Gluster Build System --- xlators/mgmt/glusterd/src/glusterd-volume-ops.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/xlators/mgmt/glusterd/src/glusterd-volume-ops.c b/xlators/mgmt/glusterd/src/glusterd-volume-ops.c index b95b8a4e863..9ce600e51c3 100644 --- a/xlators/mgmt/glusterd/src/glusterd-volume-ops.c +++ b/xlators/mgmt/glusterd/src/glusterd-volume-ops.c @@ -100,9 +100,11 @@ glusterd_check_brick_order(dict_t *dict, char *err_str) " if you want to override this behavior. "; const char found_string[2048] = "Multiple bricks of a %s " "volume are present on the same server. This " - "setup is not optimal. Use 'force' at the " - "end of the command if you want to override " - "this behavior. "; + "setup is not optimal. Bricks should be on " + "different nodes to have best fault tolerant " + "configuration. Use 'force' at the end of the " + "command if you want to override this " + "behavior. "; this = THIS; -- cgit