summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorJim Meyering <meyering@redhat.com>2012-07-11 16:45:33 +0200
committerAnand Avati <avati@redhat.com>2012-07-13 13:56:30 -0700
commit2dc0d32e5d8b205fa407073b209bb663d546dde8 (patch)
treea126ff55d00ba111f184700a5b7e258ccf5cac7f
parentce65a6b2f52f95922d29acba43e08315c50df136 (diff)
no semantic change: reverse condition and if/else clauses...
Reverse an if-condition and the corresponding then/else code blocks to hide a false-positive if-before-GF_FREE from the useless-if-before-free script. Signed-off-by: Jim Meyering <meyering@redhat.com> BUG: 839925 Change-Id: Ia68558218d63ae77b6c1c85e15231b66cce5bd49 Reviewed-on: http://review.gluster.com/3651 Tested-by: Gluster Build System <jenkins@build.gluster.com> Reviewed-by: Anand Avati <avati@redhat.com>
-rw-r--r--xlators/mgmt/glusterd/src/glusterd-mountbroker.c6
1 files changed, 3 insertions, 3 deletions
diff --git a/xlators/mgmt/glusterd/src/glusterd-mountbroker.c b/xlators/mgmt/glusterd/src/glusterd-mountbroker.c
index 50ce1484e..7b4b09a6c 100644
--- a/xlators/mgmt/glusterd/src/glusterd-mountbroker.c
+++ b/xlators/mgmt/glusterd/src/glusterd-mountbroker.c
@@ -324,10 +324,10 @@ make_georep_mountspec (gf_mount_spec_t *mspec, const char *volnames,
fa[2] = georep_mnt_desc;
for (i = 0; i < 3; i++) {
- if (fa[i])
- GF_FREE (fa[i]);
- else
+ if (fa[i] == NULL)
ret = -1;
+ else
+ GF_FREE (fa[i]);
}
return ret;