From 2dc0d32e5d8b205fa407073b209bb663d546dde8 Mon Sep 17 00:00:00 2001 From: Jim Meyering Date: Wed, 11 Jul 2012 16:45:33 +0200 Subject: no semantic change: reverse condition and if/else clauses... Reverse an if-condition and the corresponding then/else code blocks to hide a false-positive if-before-GF_FREE from the useless-if-before-free script. Signed-off-by: Jim Meyering BUG: 839925 Change-Id: Ia68558218d63ae77b6c1c85e15231b66cce5bd49 Reviewed-on: http://review.gluster.com/3651 Tested-by: Gluster Build System Reviewed-by: Anand Avati --- xlators/mgmt/glusterd/src/glusterd-mountbroker.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/xlators/mgmt/glusterd/src/glusterd-mountbroker.c b/xlators/mgmt/glusterd/src/glusterd-mountbroker.c index 50ce1484e..7b4b09a6c 100644 --- a/xlators/mgmt/glusterd/src/glusterd-mountbroker.c +++ b/xlators/mgmt/glusterd/src/glusterd-mountbroker.c @@ -324,10 +324,10 @@ make_georep_mountspec (gf_mount_spec_t *mspec, const char *volnames, fa[2] = georep_mnt_desc; for (i = 0; i < 3; i++) { - if (fa[i]) - GF_FREE (fa[i]); - else + if (fa[i] == NULL) ret = -1; + else + GF_FREE (fa[i]); } return ret; -- cgit