summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorPrashanth Pai <ppai@redhat.com>2014-09-04 16:32:40 +0530
committerPrashanth Pai <ppai@redhat.com>2014-09-04 17:43:26 +0530
commitdda911d7f139d32c1c9a4bdca8d4aaf5acf479ae (patch)
treef29627949682d2a0148621ca29177fa6401248bd
parentccd43c43ae79920422248e5413151de7c0ab08a3 (diff)
Provide default mode for Volume.mkdir()
Calling mkdir without mode used to fail with following error: >>> vol.mkdir('/c2') Traceback (most recent call last): File "<stdin>", line 1, in <module> TypeError: mkdir() takes exactly 3 arguments (2 given) Python's os.mkdir() defined default mode: https://docs.python.org/2/library/os.html#os.mkdir Also, changed mode_t is of type unsigned short (ctypes.c_ushort). Change-Id: I95e47a8173d90e2a162cfeb9af002ea0c20fc2ff Signed-off-by: Prashanth Pai <ppai@redhat.com>
-rwxr-xr-xglusterfs/api.py2
-rwxr-xr-xglusterfs/gfapi.py4
2 files changed, 3 insertions, 3 deletions
diff --git a/glusterfs/api.py b/glusterfs/api.py
index fa3c9f7..6bc19ea 100755
--- a/glusterfs/api.py
+++ b/glusterfs/api.py
@@ -213,7 +213,7 @@ glfs_closedir = ctypes.CFUNCTYPE(
glfs_mkdir = ctypes.CFUNCTYPE(ctypes.c_int, ctypes.c_void_p, ctypes.c_char_p,
- ctypes.c_ulong)(('glfs_mkdir', client))
+ ctypes.c_ushort)(('glfs_mkdir', client))
glfs_opendir = ctypes.CFUNCTYPE(ctypes.c_void_p,
ctypes.c_void_p,
diff --git a/glusterfs/gfapi.py b/glusterfs/gfapi.py
index d65099f..fc6bb27 100755
--- a/glusterfs/gfapi.py
+++ b/glusterfs/gfapi.py
@@ -335,7 +335,7 @@ class Volume(object):
raise OSError(err, os.strerror(err))
return s
- def makedirs(self, name, mode):
+ def makedirs(self, name, mode=0777):
"""
Create directories defined in 'name' recursively.
"""
@@ -352,7 +352,7 @@ class Volume(object):
return
self.mkdir(name, mode)
- def mkdir(self, path, mode):
+ def mkdir(self, path, mode=0777):
ret = api.glfs_mkdir(self.fs, path, mode)
if ret < 0:
err = ctypes.get_errno()