summaryrefslogtreecommitdiffstats
path: root/src
diff options
context:
space:
mode:
authorSelvasundaram <selvam@gluster.com>2011-08-04 12:24:55 +0530
committerSelvasundaram <selvam@gluster.com>2011-08-04 12:24:55 +0530
commitb4535830499287558db651d154231d588a35e474 (patch)
tree232b4d24c5f244b0d06a374141bb8cee43cb8939 /src
parent9541f13d89b6bb373e2a10983d0e950636fe8458 (diff)
Replacing hardcoded "\n" with system new line character
Diffstat (limited to 'src')
-rw-r--r--src/com.gluster.storage.management.gateway/src/com/gluster/storage/management/gateway/resources/v1_0/VolumesResource.java6
-rw-r--r--src/com.gluster.storage.management.gateway/src/com/gluster/storage/management/gateway/utils/PasswordManager.java10
-rw-r--r--src/com.gluster.storage.management.gui/src/com/gluster/storage/management/gui/actions/DeleteVolumeAction.java17
-rw-r--r--src/com.gluster.storage.management.gui/src/com/gluster/storage/management/gui/actions/RemoveBrickAction.java3
-rw-r--r--src/com.gluster.storage.management.gui/src/com/gluster/storage/management/gui/actions/StartVolumeAction.java8
-rw-r--r--src/com.gluster.storage.management.gui/src/com/gluster/storage/management/gui/actions/StopVolumeAction.java14
-rw-r--r--src/com.gluster.storage.management.gui/src/com/gluster/storage/management/gui/dialogs/CreateVolumeWizard.java7
-rw-r--r--src/com.gluster.storage.management.gui/src/com/gluster/storage/management/gui/dialogs/LoginDialog.java2
-rw-r--r--src/com.gluster.storage.management.gui/src/com/gluster/storage/management/gui/utils/ChartUtil.java7
-rw-r--r--src/com.gluster.storage.management.gui/src/com/gluster/storage/management/gui/views/ClusterSummaryView.java7
-rw-r--r--src/com.gluster.storage.management.gui/src/com/gluster/storage/management/gui/views/GlusterServersSummaryView.java5
-rw-r--r--src/com.gluster.storage.management.gui/src/com/gluster/storage/management/gui/views/VolumesSummaryView.java3
-rw-r--r--src/com.gluster.storage.management.gui/src/com/gluster/storage/management/gui/views/pages/GlusterServersPage.java6
-rw-r--r--src/com.gluster.storage.management.gui/src/com/gluster/storage/management/gui/views/pages/VolumesPage.java3
14 files changed, 60 insertions, 38 deletions
diff --git a/src/com.gluster.storage.management.gateway/src/com/gluster/storage/management/gateway/resources/v1_0/VolumesResource.java b/src/com.gluster.storage.management.gateway/src/com/gluster/storage/management/gateway/resources/v1_0/VolumesResource.java
index 915673bb..5762c89f 100644
--- a/src/com.gluster.storage.management.gateway/src/com/gluster/storage/management/gateway/resources/v1_0/VolumesResource.java
+++ b/src/com.gluster.storage.management.gateway/src/com/gluster/storage/management/gateway/resources/v1_0/VolumesResource.java
@@ -63,6 +63,7 @@ import static com.gluster.storage.management.core.constants.RESTConstants.TASK_S
import java.io.File;
import java.io.FileOutputStream;
import java.io.IOException;
+import java.text.SimpleDateFormat;
import java.util.ArrayList;
import java.util.Arrays;
import java.util.Collections;
@@ -531,8 +532,11 @@ public class VolumesResource extends AbstractResource {
}
public File createOnlineServerList(String clusterName) throws IOException {
+ String timestamp = new SimpleDateFormat("yyyyMMddHHmmss").format(new Date());
+
GlusterServer onlineServer = clusterService.getOnlineServer(clusterName);
- String clusterServersListFile = FileUtil.getTempDirName() + CoreConstants.FILE_SEPARATOR + ALL_SERVERS_FILE_NAME;
+ String clusterServersListFile = FileUtil.getTempDirName() + CoreConstants.FILE_SEPARATOR
+ + ALL_SERVERS_FILE_NAME + "_" + timestamp;
List<GlusterServer> glusterServers = glusterUtil.getGlusterServers(onlineServer);
File serversFile = new File(clusterServersListFile);
FileOutputStream fos = new FileOutputStream(serversFile);
diff --git a/src/com.gluster.storage.management.gateway/src/com/gluster/storage/management/gateway/utils/PasswordManager.java b/src/com.gluster.storage.management.gateway/src/com/gluster/storage/management/gateway/utils/PasswordManager.java
index 2554ccb3..503a6ea0 100644
--- a/src/com.gluster.storage.management.gateway/src/com/gluster/storage/management/gateway/utils/PasswordManager.java
+++ b/src/com.gluster.storage.management.gateway/src/com/gluster/storage/management/gateway/utils/PasswordManager.java
@@ -45,12 +45,12 @@ public class PasswordManager {
userAuthDao.changePassword(username, encodedPassword);
System.out.println("Password for user [" + username + "] reset successsfully to default value of ["
- + CoreConstants.DEFAULT_PASSWORD + "].\n");
+ + CoreConstants.DEFAULT_PASSWORD + "]." + CoreConstants.NEWLINE);
} catch (Exception e) {
- System.err
- .println("\n\nPassword reset for user ["
- + username
- + "] failed! \nMake sure that the Management Gateway is not running while performing password reset.\n");
+ System.err.println(CoreConstants.NEWLINE + CoreConstants.NEWLINE + "Password reset for user [" + username
+ + "] failed! " + CoreConstants.NEWLINE
+ + "Make sure that the Management Gateway is not running while performing password reset."
+ + CoreConstants.NEWLINE);
System.exit(SQL_ERR);
}
}
diff --git a/src/com.gluster.storage.management.gui/src/com/gluster/storage/management/gui/actions/DeleteVolumeAction.java b/src/com.gluster.storage.management.gui/src/com/gluster/storage/management/gui/actions/DeleteVolumeAction.java
index 59e2a957..a230198a 100644
--- a/src/com.gluster.storage.management.gui/src/com/gluster/storage/management/gui/actions/DeleteVolumeAction.java
+++ b/src/com.gluster.storage.management.gui/src/com/gluster/storage/management/gui/actions/DeleteVolumeAction.java
@@ -27,6 +27,7 @@ import org.eclipse.jface.dialogs.MessageDialog;
import org.eclipse.jface.viewers.ISelection;
import com.gluster.storage.management.client.VolumesClient;
+import com.gluster.storage.management.core.constants.CoreConstants;
import com.gluster.storage.management.core.model.Volume;
import com.gluster.storage.management.core.model.Volume.VOLUME_STATUS;
import com.gluster.storage.management.core.utils.StringUtil;
@@ -50,7 +51,7 @@ public class DeleteVolumeAction extends AbstractActionDelegate {
if (onlineVolumeNames.size() > 0) { // There are some online volumes, get confirmation to stop and delete all
// the volumes
warningMessage = "Following volume(s) [" + StringUtil.collectionToString(onlineVolumeNames, ", ")
- + "] are online, \nAre you sure to continue?";
+ + "] are online, " + CoreConstants.NEWLINE + "Are you sure to continue?";
} else {
warningMessage = "Are you sure to delete the following volume(s) ["
+ StringUtil.collectionToString(selectedVolumeNames, ", ") + "] ?";
@@ -80,11 +81,12 @@ public class DeleteVolumeAction extends AbstractActionDelegate {
// there is a possibility that the error was in post-delete operation, which means
// volume was deleted, but some other error happened. check if this is the case.
if (vc.volumeExists(volume.getName())) {
- errorMessage += "\nVolume [" + volume.getName() + "] could not be deleted! Error: ["
- + e.getMessage() + "]";
+ errorMessage += CoreConstants.NEWLINE + "Volume [" + volume.getName()
+ + "] could not be deleted! Error: [" + e.getMessage() + "]";
failedVolumes.add(volume.getName());
} else {
- errorMessage += "\nVolume deleted, but following error(s) occured: [" + e.getMessage() + "]";
+ errorMessage += CoreConstants.NEWLINE + "Volume deleted, but following error(s) occured: ["
+ + e.getMessage() + "]";
modelManager.deleteVolume(volume);
deletedVolumes.add(volume.getName());
}
@@ -94,13 +96,14 @@ public class DeleteVolumeAction extends AbstractActionDelegate {
// Display the success or failure info
if (deletedVolumes.size() == 0) { // No volume(s) deleted successfully
showErrorDialog(actionDesc, "Following volume(s) [" + StringUtil.collectionToString(failedVolumes, ", ")
- + "] could not be delete! " + "\nError: [" + errorMessage + "]");
+ + "] could not be delete! " + CoreConstants.NEWLINE + "Error: [" + errorMessage + "]");
} else {
String info = "Following volumes [" + StringUtil.collectionToString(deletedVolumes, ", ")
+ "] are deleted successfully!";
if (errorMessage != "") {
- info += "\n\nFollowing volumes [" + StringUtil.collectionToString(failedVolumes, ", ")
- + "] are failed to delete! [" + errorMessage + "]";
+ info += CoreConstants.NEWLINE + CoreConstants.NEWLINE + "Following volumes ["
+ + StringUtil.collectionToString(failedVolumes, ", ") + "] are failed to delete! ["
+ + errorMessage + "]";
}
showInfoDialog(actionDesc, info);
}
diff --git a/src/com.gluster.storage.management.gui/src/com/gluster/storage/management/gui/actions/RemoveBrickAction.java b/src/com.gluster.storage.management.gui/src/com/gluster/storage/management/gui/actions/RemoveBrickAction.java
index 2e71d1f6..2ce25043 100644
--- a/src/com.gluster.storage.management.gui/src/com/gluster/storage/management/gui/actions/RemoveBrickAction.java
+++ b/src/com.gluster.storage.management.gui/src/com/gluster/storage/management/gui/actions/RemoveBrickAction.java
@@ -12,6 +12,7 @@ import org.eclipse.swt.widgets.Display;
import org.eclipse.ui.IWorkbenchPart;
import com.gluster.storage.management.client.VolumesClient;
+import com.gluster.storage.management.core.constants.CoreConstants;
import com.gluster.storage.management.core.model.Brick;
import com.gluster.storage.management.core.model.Volume;
import com.gluster.storage.management.core.utils.StringUtil;
@@ -33,7 +34,7 @@ public class RemoveBrickAction extends AbstractActionDelegate {
List<String> brickList = getBrickList(bricks);
Integer deleteOption = new MessageDialog(getShell(), "Remove Bricks(s)", GUIHelper.getInstance().getImage(
IImageKeys.VOLUME_16x16), "Are you sure you want to remove following bricks from volume [" + volume.getName()
- + "] ? \n" + StringUtil.collectionToString(brickList, ", "), MessageDialog.QUESTION, new String[] {
+ + "] ? " + CoreConstants.NEWLINE + StringUtil.collectionToString(brickList, ", "), MessageDialog.QUESTION, new String[] {
"Cancel", "Remove bricks, delete data", "Remove bricks, keep data" }, -1).open();
if (deleteOption <= 0) { // By Cancel button(0) or Escape key(-1)
return;
diff --git a/src/com.gluster.storage.management.gui/src/com/gluster/storage/management/gui/actions/StartVolumeAction.java b/src/com.gluster.storage.management.gui/src/com/gluster/storage/management/gui/actions/StartVolumeAction.java
index b52952af..df897507 100644
--- a/src/com.gluster.storage.management.gui/src/com/gluster/storage/management/gui/actions/StartVolumeAction.java
+++ b/src/com.gluster.storage.management.gui/src/com/gluster/storage/management/gui/actions/StartVolumeAction.java
@@ -26,6 +26,7 @@ import org.eclipse.jface.action.IAction;
import org.eclipse.jface.viewers.ISelection;
import com.gluster.storage.management.client.VolumesClient;
+import com.gluster.storage.management.core.constants.CoreConstants;
import com.gluster.storage.management.core.model.Volume;
import com.gluster.storage.management.core.model.Volume.VOLUME_STATUS;
import com.gluster.storage.management.core.utils.StringUtil;
@@ -78,13 +79,14 @@ public class StartVolumeAction extends AbstractActionDelegate {
// Display the success or failure info
if (startedVolumes.size() == 0) { // No volume(s) started successfully
showErrorDialog(actionDesc, "Following volume(s) [" + StringUtil.collectionToString(failedVolumes, ", ")
- + "] could not be start! " + "\nError: [" + errorMessage + "]");
+ + "] could not be start! " + CoreConstants.NEWLINE + "Error: [" + errorMessage + "]");
} else {
String info = "Following volume(s) [" + StringUtil.collectionToString(startedVolumes, ", ")
+ "] are started successfully!";
if (errorMessage != "") {
- info += "\n\nFollowing volume(s) [" + StringUtil.collectionToString(failedVolumes, ", ")
- + "] are failed to start! [" + errorMessage + "]";
+ info += CoreConstants.NEWLINE + CoreConstants.NEWLINE + "Following volume(s) ["
+ + StringUtil.collectionToString(failedVolumes, ", ") + "] are failed to start! ["
+ + errorMessage + "]";
}
showInfoDialog(actionDesc, info);
}
diff --git a/src/com.gluster.storage.management.gui/src/com/gluster/storage/management/gui/actions/StopVolumeAction.java b/src/com.gluster.storage.management.gui/src/com/gluster/storage/management/gui/actions/StopVolumeAction.java
index f2d23490..765b856c 100644
--- a/src/com.gluster.storage.management.gui/src/com/gluster/storage/management/gui/actions/StopVolumeAction.java
+++ b/src/com.gluster.storage.management.gui/src/com/gluster/storage/management/gui/actions/StopVolumeAction.java
@@ -27,6 +27,7 @@ import org.eclipse.jface.dialogs.MessageDialog;
import org.eclipse.jface.viewers.ISelection;
import com.gluster.storage.management.client.VolumesClient;
+import com.gluster.storage.management.core.constants.CoreConstants;
import com.gluster.storage.management.core.model.Volume;
import com.gluster.storage.management.core.model.Volume.VOLUME_STATUS;
import com.gluster.storage.management.core.utils.StringUtil;
@@ -61,9 +62,9 @@ public class StopVolumeAction extends AbstractActionDelegate {
}
Integer userAction = new MessageDialog(getShell(), "Stop Volume", GUIHelper.getInstance().getImage(
- IImageKeys.VOLUME_16x16), "Are you sure you want to stop the following volume(s)?\n" + "["
- + StringUtil.collectionToString(onlineVolumeNames, ", ") + "]", MessageDialog.QUESTION, new String[] {
- "No", "Yes" }, -1).open();
+ IImageKeys.VOLUME_16x16), "Are you sure you want to stop the following volume(s)?"
+ + CoreConstants.NEWLINE + "[" + StringUtil.collectionToString(onlineVolumeNames, ", ") + "]",
+ MessageDialog.QUESTION, new String[] { "No", "Yes" }, -1).open();
if (userAction <= 0) { // user select cancel or pressed escape key
return;
@@ -90,13 +91,14 @@ public class StopVolumeAction extends AbstractActionDelegate {
// Display the success or failure info
if (stoppedVolumes.size() == 0) { // No volume(s) stopped successfully
showErrorDialog(actionDesc, "Following volume(s) [" + StringUtil.collectionToString(failedVolumes, ", ")
- + "] could not be stopped! " + "\nError: [" + errorMessage + "]");
+ + "] could not be stopped! " + CoreConstants.NEWLINE + "Error: [" + errorMessage + "]");
} else {
String info = "Following volume(s) [" + StringUtil.collectionToString(stoppedVolumes, ", ")
+ "] are stopped successfully!";
if (errorMessage != "") {
- info += "\n\nFollowing volume(s) [" + StringUtil.collectionToString(failedVolumes, ", ")
- + "] are failed to stop! [" + errorMessage + "]";
+ info += CoreConstants.NEWLINE + CoreConstants.NEWLINE + "Following volume(s) ["
+ + StringUtil.collectionToString(failedVolumes, ", ") + "] are failed to stop! [" + errorMessage
+ + "]";
}
showInfoDialog(actionDesc, info);
}
diff --git a/src/com.gluster.storage.management.gui/src/com/gluster/storage/management/gui/dialogs/CreateVolumeWizard.java b/src/com.gluster.storage.management.gui/src/com/gluster/storage/management/gui/dialogs/CreateVolumeWizard.java
index c5cbcc16..0d8104bb 100644
--- a/src/com.gluster.storage.management.gui/src/com/gluster/storage/management/gui/dialogs/CreateVolumeWizard.java
+++ b/src/com.gluster.storage.management.gui/src/com/gluster/storage/management/gui/dialogs/CreateVolumeWizard.java
@@ -22,6 +22,7 @@ import org.eclipse.jface.dialogs.MessageDialog;
import org.eclipse.jface.wizard.Wizard;
import com.gluster.storage.management.client.VolumesClient;
+import com.gluster.storage.management.core.constants.CoreConstants;
import com.gluster.storage.management.core.model.Volume;
import com.gluster.storage.management.core.model.Volume.VOLUME_STATUS;
import com.gluster.storage.management.gui.GlusterDataModelManager;
@@ -92,9 +93,9 @@ public class CreateVolumeWizard extends Wizard {
boolean error = false;
String message1 = null;
if (page.startVolumeAfterCreation()) {
- if (MessageDialog.openConfirm(getShell(), title,
- "Volume created, but following error(s) occured: " + errMsg
- + "\n\nDo you still want to start the volume [" + newVolume.getName() + "]?")) {
+ if (MessageDialog.openConfirm(getShell(), title, "Volume created, but following error(s) occured: "
+ + errMsg + CoreConstants.NEWLINE + CoreConstants.NEWLINE
+ + "Do you still want to start the volume [" + newVolume.getName() + "]?")) {
try {
volumesClient.startVolume(newVolume.getName());
newVolume.setStatus(VOLUME_STATUS.ONLINE);
diff --git a/src/com.gluster.storage.management.gui/src/com/gluster/storage/management/gui/dialogs/LoginDialog.java b/src/com.gluster.storage.management.gui/src/com/gluster/storage/management/gui/dialogs/LoginDialog.java
index 11f0ac87..3b4fd7ca 100644
--- a/src/com.gluster.storage.management.gui/src/com/gluster/storage/management/gui/dialogs/LoginDialog.java
+++ b/src/com.gluster.storage.management.gui/src/com/gluster/storage/management/gui/dialogs/LoginDialog.java
@@ -224,7 +224,7 @@ public class LoginDialog extends Dialog {
if (dialog.open() == Dialog.CANCEL) {
MessageDialog.openError(getShell(), "Change password Cancelled",
- "Password must be changed on first login!" + "\n" + "Application will close.");
+ "Password must be changed on first login!" + CoreConstants.NEWLINE + "Application will close.");
cancelPressed();
return;
}
diff --git a/src/com.gluster.storage.management.gui/src/com/gluster/storage/management/gui/utils/ChartUtil.java b/src/com.gluster.storage.management.gui/src/com/gluster/storage/management/gui/utils/ChartUtil.java
index e2035468..1297d2f4 100644
--- a/src/com.gluster.storage.management.gui/src/com/gluster/storage/management/gui/utils/ChartUtil.java
+++ b/src/com.gluster.storage.management.gui/src/com/gluster/storage/management/gui/utils/ChartUtil.java
@@ -35,6 +35,7 @@ import org.eclipse.ui.forms.events.HyperlinkEvent;
import org.eclipse.ui.forms.widgets.FormToolkit;
import org.eclipse.ui.forms.widgets.Hyperlink;
+import com.gluster.storage.management.core.constants.CoreConstants;
import com.gluster.storage.management.core.constants.GlusterConstants;
import com.gluster.storage.management.core.model.GlusterServer;
import com.gluster.storage.management.core.model.NetworkInterface;
@@ -83,9 +84,9 @@ public class ChartUtil {
extractChartData(stats, timestamps, data, dataColumnIndex);
if (timestamps.size() == 0) {
- toolkit.createLabel(
- section,
- "Server statistics not available!\nCheck if all services are running properly \non the cluster servers, or try after some time!");
+ toolkit.createLabel(section, "Server statistics not available!" + CoreConstants.NEWLINE
+ + "Check if all services are running properly " + CoreConstants.NEWLINE
+ + "on the cluster servers, or try after some time!");
return null;
}
diff --git a/src/com.gluster.storage.management.gui/src/com/gluster/storage/management/gui/views/ClusterSummaryView.java b/src/com.gluster.storage.management.gui/src/com/gluster/storage/management/gui/views/ClusterSummaryView.java
index 8318522b..37269711 100644
--- a/src/com.gluster.storage.management.gui/src/com/gluster/storage/management/gui/views/ClusterSummaryView.java
+++ b/src/com.gluster.storage.management.gui/src/com/gluster/storage/management/gui/views/ClusterSummaryView.java
@@ -41,6 +41,7 @@ import org.eclipse.ui.forms.widgets.ScrolledForm;
import org.eclipse.ui.handlers.IHandlerService;
import org.eclipse.ui.part.ViewPart;
+import com.gluster.storage.management.core.constants.CoreConstants;
import com.gluster.storage.management.core.constants.GlusterConstants;
import com.gluster.storage.management.core.model.Alert;
import com.gluster.storage.management.core.model.Cluster;
@@ -212,7 +213,8 @@ public class ClusterSummaryView extends ViewPart {
private void createDiskSpaceSection() {
Composite section = guiHelper.createSection(form, toolkit, "Disk Space", null, 3, false);
if (cluster.getServers().size() == 0) {
- toolkit.createLabel(section, "This section will be populated after at least\none server is added to the storage cloud.");
+ toolkit.createLabel(section, "This section will be populated after at least" + CoreConstants.NEWLINE
+ + "one server is added to the storage cloud.");
return;
}
@@ -324,7 +326,8 @@ public class ClusterSummaryView extends ViewPart {
private Composite createAreaChartSection(ServerStats stats, String sectionTitle, int dataColumnIndex, String unit, String timestampFormat, ChartPeriodLinkListener listener, double maxValue, int chartLinkColumnCount) {
Composite section = guiHelper.createSection(form, toolkit, sectionTitle, null, 1, false);
if (cluster.getServers().size() == 0) {
- toolkit.createLabel(section, "This section will be populated after at least\none server is added to the storage cloud.");
+ toolkit.createLabel(section, "This section will be populated after at least" + CoreConstants.NEWLINE
+ + "one server is added to the storage cloud.");
return null;
}
diff --git a/src/com.gluster.storage.management.gui/src/com/gluster/storage/management/gui/views/GlusterServersSummaryView.java b/src/com.gluster.storage.management.gui/src/com/gluster/storage/management/gui/views/GlusterServersSummaryView.java
index 45893d12..25c966c1 100644
--- a/src/com.gluster.storage.management.gui/src/com/gluster/storage/management/gui/views/GlusterServersSummaryView.java
+++ b/src/com.gluster.storage.management.gui/src/com/gluster/storage/management/gui/views/GlusterServersSummaryView.java
@@ -32,6 +32,7 @@ import org.eclipse.ui.forms.widgets.FormToolkit;
import org.eclipse.ui.forms.widgets.ScrolledForm;
import org.eclipse.ui.part.ViewPart;
+import com.gluster.storage.management.core.constants.CoreConstants;
import com.gluster.storage.management.core.model.Alert;
import com.gluster.storage.management.core.model.Alert.ALERT_TYPES;
import com.gluster.storage.management.core.model.ClusterListener;
@@ -156,8 +157,8 @@ public class GlusterServersSummaryView extends ViewPart {
private void populateAvailabilitySection() {
if (servers.getEntities().size() == 0) {
- toolkit.createLabel(serversAvailabilitySection,
- "This section will be populated after at least\none server is added to the storage cloud.");
+ toolkit.createLabel(serversAvailabilitySection, "This section will be populated after at least"
+ + CoreConstants.NEWLINE + "one server is added to the storage cloud.");
return;
}
diff --git a/src/com.gluster.storage.management.gui/src/com/gluster/storage/management/gui/views/VolumesSummaryView.java b/src/com.gluster.storage.management.gui/src/com/gluster/storage/management/gui/views/VolumesSummaryView.java
index b14b078d..07782143 100644
--- a/src/com.gluster.storage.management.gui/src/com/gluster/storage/management/gui/views/VolumesSummaryView.java
+++ b/src/com.gluster.storage.management.gui/src/com/gluster/storage/management/gui/views/VolumesSummaryView.java
@@ -31,6 +31,7 @@ import org.eclipse.ui.forms.widgets.FormToolkit;
import org.eclipse.ui.forms.widgets.ScrolledForm;
import org.eclipse.ui.part.ViewPart;
+import com.gluster.storage.management.core.constants.CoreConstants;
import com.gluster.storage.management.core.model.Alert;
import com.gluster.storage.management.core.model.Cluster;
import com.gluster.storage.management.core.model.ClusterListener;
@@ -220,7 +221,7 @@ public class VolumesSummaryView extends ViewPart {
private void populateSummarySection() {
if(volumes.getEntities().size() == 0) {
toolkit.createLabel(summarySection,
- "This section will be populated after at least\none volume is created the storage cloud.");
+ "This section will be populated after at least" + CoreConstants.NEWLINE +"one volume is created the storage cloud.");
return;
}
diff --git a/src/com.gluster.storage.management.gui/src/com/gluster/storage/management/gui/views/pages/GlusterServersPage.java b/src/com.gluster.storage.management.gui/src/com/gluster/storage/management/gui/views/pages/GlusterServersPage.java
index 8dc58ff1..962ab80b 100644
--- a/src/com.gluster.storage.management.gui/src/com/gluster/storage/management/gui/views/pages/GlusterServersPage.java
+++ b/src/com.gluster.storage.management.gui/src/com/gluster/storage/management/gui/views/pages/GlusterServersPage.java
@@ -30,6 +30,7 @@ import org.eclipse.swt.widgets.Table;
import org.eclipse.swt.widgets.TableColumn;
import org.eclipse.ui.IWorkbenchSite;
+import com.gluster.storage.management.core.constants.CoreConstants;
import com.gluster.storage.management.core.model.ClusterListener;
import com.gluster.storage.management.core.model.DefaultClusterListener;
import com.gluster.storage.management.core.model.EntityGroup;
@@ -45,8 +46,9 @@ public class GlusterServersPage extends AbstractTableViewerPage<GlusterServer> {
NAME, IP_ADDRESSES, NUM_OF_CPUS, TOTAL_MEMORY, TOTAL_FREE_SPACE, TOTAL_DISK_SPACE, STATUS // Removed PREFERRED_NETWORK
};
- private static final String[] GLUSTER_SERVER_TABLE_COLUMN_NAMES = new String[] { "Name",
- "IP Address(es)", "Number\nof CPUs", "Total\nMemory (GB)", "Free Space (GB)", "Total \n Space (GB)", "Status" }; // Removed "Preferred\nNetwork",
+ private static final String[] GLUSTER_SERVER_TABLE_COLUMN_NAMES = new String[] { "Name", "IP Address(es)",
+ "Number" + CoreConstants.NEWLINE + "of CPUs", "Total" + CoreConstants.NEWLINE + "Memory (GB)",
+ "Free Space (GB)", "Total " + CoreConstants.NEWLINE + " Space (GB)", "Status" }; // Removed "Preferred\nNetwork",
public GlusterServersPage(IWorkbenchSite site, final Composite parent, int style, final EntityGroup<GlusterServer> servers) {
super(site, parent, style, true, true, servers);
diff --git a/src/com.gluster.storage.management.gui/src/com/gluster/storage/management/gui/views/pages/VolumesPage.java b/src/com.gluster.storage.management.gui/src/com/gluster/storage/management/gui/views/pages/VolumesPage.java
index 04c77758..1676ce77 100644
--- a/src/com.gluster.storage.management.gui/src/com/gluster/storage/management/gui/views/pages/VolumesPage.java
+++ b/src/com.gluster.storage.management.gui/src/com/gluster/storage/management/gui/views/pages/VolumesPage.java
@@ -30,6 +30,7 @@ import org.eclipse.swt.widgets.Table;
import org.eclipse.swt.widgets.TableColumn;
import org.eclipse.ui.IWorkbenchSite;
+import com.gluster.storage.management.core.constants.CoreConstants;
import com.gluster.storage.management.core.model.ClusterListener;
import com.gluster.storage.management.core.model.DefaultClusterListener;
import com.gluster.storage.management.core.model.EntityGroup;
@@ -46,7 +47,7 @@ public class VolumesPage extends AbstractTableViewerPage<Volume> {
};
private static final String[] VOLUME_TABLE_COLUMN_NAMES = new String[] { "Name", "Volume Type",
- "Number of\nBricks", "Transport Type", "Status" };
+ "Number of" + CoreConstants.NEWLINE + "Bricks", "Transport Type", "Status" };
public VolumesPage(final Composite parent, IWorkbenchSite site, EntityGroup<Volume> volumes) {
super(site, parent, SWT.NONE, true, true, volumes);