Volume Rebalance functionality enhancement

7 files changed, 117 insertions, 65 deletions

diff --git a/src/com.gluster.storage.management.client/src/com/gluster/storage/management/client/VolumesClient.java b/src/com.gluster.storage.management.client/src/com/gluster/storage/management/client/VolumesClient.java
index b5d2711a..2866a8e1 100644
--- a/src/com.gluster.storage.management.client/src/com/gluster/storage/management/client/VolumesClient.java
+++ b/src/com.gluster.storage.management.client/src/com/gluster/storage/management/client/VolumesClient.java
@@ -241,12 +241,6 @@ public class VolumesClient extends AbstractClient {
 		putRequest(volumeName, form);
 	}
 	
-	public void rebalanceStatus(String volumeName) {
-		Form form = new Form();
-		form.add(RESTConstants.FORM_PARAM_OPERATION, RESTConstants.TASK_REBALANCE_STATUS);
-		putRequest(volumeName, form);
-	}
-	
 	public void rebalanceStop(String volumeName) {
 		Form form = new Form();
 		form.add(RESTConstants.FORM_PARAM_OPERATION, RESTConstants.TASK_REBALANCE_STOP);
diff --git a/src/com.gluster.storage.management.server/src/com/gluster/storage/management/server/resources/GlusterServersResource.java b/src/com.gluster.storage.management.server/src/com/gluster/storage/management/server/resources/GlusterServersResource.java
index a9ef7fbb..e3bfe158 100644
--- a/src/com.gluster.storage.management.server/src/com/gluster/storage/management/server/resources/GlusterServersResource.java
+++ b/src/com.gluster.storage.management.server/src/com/gluster/storage/management/server/resources/GlusterServersResource.java
@@ -414,15 +414,12 @@ public class GlusterServersResource extends AbstractServersResource {
 			return badRequestResponse("Disk name must not be empty!");
 		}
 
-		InitializeDiskTask initializeTask = new InitializeDiskTask(clusterService, clusterName, diskName, serverName);
-		try {
-			initializeTask.start();
-			taskResource.addTask(initializeTask);
-			return acceptedResponse(RESTConstants.RESOURCE_PATH_CLUSTERS + "/" + clusterName + "/" + RESOURCE_TASKS
-					+ "/" + initializeTask.getId());
-		} catch (ConnectionException e) {
-			return errorResponse(e.getMessage());
-		}
+		InitializeDiskTask initializeTask = new InitializeDiskTask(clusterService, clusterName, serverName, diskName);
+		initializeTask.start();
+		taskResource.addTask(initializeTask);
+
+		return acceptedResponse(RESTConstants.RESOURCE_PATH_CLUSTERS + "/" + clusterName + "/" + RESOURCE_TASKS + "/"
+				+ initializeTask.getId());
 	}
 
 	private void setGlusterUtil(GlusterUtil glusterUtil) {
diff --git a/src/com.gluster.storage.management.server/src/com/gluster/storage/management/server/resources/VolumesResource.java b/src/com.gluster.storage.management.server/src/com/gluster/storage/management/server/resources/VolumesResource.java
index d568d519..4318945c 100644
--- a/src/com.gluster.storage.management.server/src/com/gluster/storage/management/server/resources/VolumesResource.java
+++ b/src/com.gluster.storage.management.server/src/com/gluster/storage/management/server/resources/VolumesResource.java
@@ -978,7 +978,7 @@ public class VolumesResource extends AbstractResource {
 		return rebalanceStart(clusterName, volumeName, layout);
 	}
 	
-	public String rebalanceStart(String clusterName, String volumeName, String layout) {
+	private String rebalanceStart(String clusterName, String volumeName, String layout) {
 		RebalanceVolumeTask rebalanceTask = new RebalanceVolumeTask(clusterService, clusterName, volumeName);
 		rebalanceTask.setLayout(layout);
 		rebalanceTask.start();
diff --git a/src/com.gluster.storage.management.server/src/com/gluster/storage/management/server/tasks/InitializeDiskTask.java b/src/com.gluster.storage.management.server/src/com/gluster/storage/management/server/tasks/InitializeDiskTask.java
index 5f3f8e30..40d7877e 100644
--- a/src/com.gluster.storage.management.server/src/com/gluster/storage/management/server/tasks/InitializeDiskTask.java
+++ b/src/com.gluster.storage.management.server/src/com/gluster/storage/management/server/tasks/InitializeDiskTask.java
@@ -20,21 +20,26 @@
  */
 package com.gluster.storage.management.server.tasks;
 
+import com.gluster.storage.management.core.exceptions.ConnectionException;
+import com.gluster.storage.management.core.exceptions.GlusterRuntimeException;
 import com.gluster.storage.management.core.model.Status;
 import com.gluster.storage.management.core.model.TaskInfo;
 import com.gluster.storage.management.core.model.TaskInfo.TASK_TYPE;
 import com.gluster.storage.management.core.model.TaskStatus;
+import com.gluster.storage.management.core.utils.ProcessResult;
 import com.gluster.storage.management.server.services.ClusterService;
+import com.gluster.storage.management.server.utils.GlusterUtil;
 import com.gluster.storage.management.server.utils.SshUtil;
+import com.sun.jersey.core.util.Base64;
 
 public class InitializeDiskTask extends Task {
 
 	private static final String INITIALIZE_DISK_SCRIPT = "initialize_disk.py";
-	private static final String INITIALIZE_DISK_STATUS_SCRIPT = "initialize_disk_status.py";
 	
 	private String serverName;
 	private String diskName;
 	private SshUtil sshUtil = new SshUtil();
+	private GlusterUtil glusterUtil;
 
 	public InitializeDiskTask(ClusterService clusterService, String clusterName, String serverName, String diskName) {
 		super(clusterService, clusterName, TASK_TYPE.DISK_FORMAT, diskName, "Initialize disk " + serverName + ":"
@@ -50,7 +55,7 @@ public class InitializeDiskTask extends Task {
 
 	@Override
 	public String getId() {
-		return taskInfo.getType() + "-" + serverName + ":" + diskName;
+		return new String(Base64.encode(taskInfo.getType() + "-" + serverName + ":" + diskName));
 	}
 
 	@Override
@@ -85,17 +90,41 @@ public class InitializeDiskTask extends Task {
 
 	@Override
 	public void start() {
-		getTaskInfo().setStatus(
-				new TaskStatus(new Status(sshUtil.executeRemote(getServerName(), INITIALIZE_DISK_SCRIPT + " "
-						+ getDiskName()))));
+		try {
+			startInitializeDisk(getOnlineServer().getName());
+		} catch(ConnectionException e) {
+			// online server might have gone offline. try with a new one
+			startInitializeDisk(getNewOnlineServer().getName());
+		}
+	}
+
+	private void startInitializeDisk(String serverName) {
+		ProcessResult processResult = sshUtil.executeRemote(serverName, INITIALIZE_DISK_SCRIPT + " " + getDiskName());
+		if (processResult.isSuccess()) {
+			// TODO: Message needs to change according to the script return
+			if (processResult.getOutput().trim().matches(".*has been successful$")) {
+				getTaskInfo().setStatus(
+						new TaskStatus(new Status(Status.STATUS_CODE_RUNNING, processResult.getOutput())));
+				return;
+			}
+		}
+		
+		// if we reach here, it means Initialize disk start failed.
+		throw new GlusterRuntimeException(processResult.toString());
+		
 	}
 
 	@Override
 	public TaskStatus checkStatus() {
-		return new TaskStatus(new Status(sshUtil.executeRemote(getServerName(), INITIALIZE_DISK_STATUS_SCRIPT + " "
-				+ getDiskName())));
+		
+		try {
+			return glusterUtil.checkInitializeDiskStatus(getOnlineServer().getName(), getDiskName());
+		} catch(ConnectionException e) {
+			// online server might have gone offline. try with a new one
+			return glusterUtil.checkInitializeDiskStatus(getNewOnlineServer().getName(), getDiskName());
+		}
 	}
-
+	
 	public void setDiskName(String diskName) {
 		this.diskName = diskName;
 	}
diff --git a/src/com.gluster.storage.management.server/src/com/gluster/storage/management/server/tasks/RebalanceVolumeTask.java b/src/com.gluster.storage.management.server/src/com/gluster/storage/management/server/tasks/RebalanceVolumeTask.java
index 7f9fb6bf..33655b3f 100644
--- a/src/com.gluster.storage.management.server/src/com/gluster/storage/management/server/tasks/RebalanceVolumeTask.java
+++ b/src/com.gluster.storage.management.server/src/com/gluster/storage/management/server/tasks/RebalanceVolumeTask.java
@@ -28,33 +28,40 @@ import com.gluster.storage.management.core.model.TaskInfo.TASK_TYPE;
 import com.gluster.storage.management.core.model.TaskStatus;
 import com.gluster.storage.management.core.utils.ProcessResult;
 import com.gluster.storage.management.server.services.ClusterService;
+import com.gluster.storage.management.server.utils.GlusterUtil;
 import com.gluster.storage.management.server.utils.SshUtil;
+import com.sun.jersey.core.util.Base64;
 
 public class RebalanceVolumeTask extends Task {
 
 	private String layout;
+	private String serverName;
 	private SshUtil sshUtil = new SshUtil();
+	private GlusterUtil glusterUtil = new GlusterUtil();
 
 	public RebalanceVolumeTask(ClusterService clusterService, String clusterName, TaskInfo taskInfo) {
 		super(clusterService, clusterName, taskInfo);
 	}
 
 	public RebalanceVolumeTask(ClusterService clusterService, String clusterName, String volumeName) {
-		super(clusterService, clusterName, TASK_TYPE.VOLUME_REBALANCE, volumeName, "Volume rebalance running on " + volumeName, false, true, false);
+		super(clusterService, clusterName, TASK_TYPE.VOLUME_REBALANCE, volumeName, "Volume rebalance running on "
+				+ volumeName, false, true, false);
 	}
 
 	@Override
 	public String getId() {
-		return taskInfo.getType() + "-" + taskInfo.getReference();
+		return new String(Base64.encode(taskInfo.getType() + "-" + taskInfo.getReference()));
 	}
 
 	@Override
 	public void start() {
 		try {
-			startRebalance(getOnlineServer().getName());
+			serverName = getOnlineServer().getName();
+			startRebalance(serverName);
 		} catch(ConnectionException e) {
 			// online server might have gone offline. try with a new one
-			startRebalance(getNewOnlineServer().getName());
+			serverName = getNewOnlineServer().getName();
+			startRebalance(serverName);
 		}
 	}
 
@@ -63,7 +70,9 @@ public class RebalanceVolumeTask extends Task {
 		ProcessResult processResult = sshUtil.executeRemote(serverName, command);
 		if (processResult.isSuccess()) {
 			if (processResult.getOutput().trim().matches(".*has been successful$")) {
-				getTaskInfo().setStatus(new TaskStatus(new Status(Status.STATUS_CODE_RUNNING, processResult.getOutput())));
+				getTaskInfo().setStatus(
+						new TaskStatus(new Status(Status.STATUS_CODE_RUNNING, processResult.getOutput())));
+				return;
 			}
 		}
 		
@@ -74,34 +83,34 @@ public class RebalanceVolumeTask extends Task {
 	@Override
 	public void resume() {
 		getTaskInfo().setStatus(
-				new TaskStatus(new Status(Status.STATUS_CODE_FAILURE, "Pause/Resume is not supported in Volume Rebalance")));
+				new TaskStatus(new Status(Status.STATUS_CODE_FAILURE,
+						"Pause/Resume is not supported in Volume Rebalance")));
 	}
 
 	@Override
 	public void stop() {
 		try {
-			stopRebalance(getOnlineServer().getName());
-		} catch(ConnectionException e) {
-			// online server might have gone offline. try with a new one
-			stopRebalance(getNewOnlineServer().getName());
+			stopRebalance(serverName);
+		} catch (ConnectionException e) {
+			// online server might have gone offline. update the failure status
+			getTaskInfo().setStatus(new TaskStatus(new Status(Status.STATUS_CODE_FAILURE, e.getMessage())));
 		}
 	}
 
 	private void stopRebalance(String serverName) {
 		String command = "gluster volume rebalance " + getTaskInfo().getReference() + " stop";
 		ProcessResult processResult = sshUtil.executeRemote(serverName, command);
-		TaskStatus taskStatus = new TaskStatus();
+
 		if (processResult.isSuccess()) {
 			if (processResult.getOutput().trim().matches(".*has been successful$")) {
-				taskStatus.setCode(Status.STATUS_CODE_SUCCESS);
-			} else {
-				taskStatus.setCode(Status.STATUS_CODE_FAILURE);
+				getTaskInfo().setStatus(
+						new TaskStatus(new Status(Status.STATUS_CODE_SUCCESS, processResult.getOutput())));
+				return;
 			}
-		} else {
-			taskStatus.setCode(Status.STATUS_CODE_FAILURE);
 		}
-		taskStatus.setMessage(processResult.getOutput()); // Common
-		getTaskInfo().setStatus(taskStatus);
+		
+		// if we reach here, it means rebalance stop failed.
+		throw new GlusterRuntimeException(processResult.toString());
 	}
 
 	@Override
@@ -113,31 +122,14 @@ public class RebalanceVolumeTask extends Task {
 	@Override
 	public TaskStatus checkStatus() {
 		try {
-			return checkRebalanceStatus(getOnlineServer().getName());
+			return glusterUtil.checkRebalanceStatus(serverName, getTaskInfo().getReference());
 		} catch(ConnectionException e) {
-			// online server might have gone offline. try with a new one. 
-			return checkRebalanceStatus(getNewOnlineServer().getName());
+			// online server might have gone offline. update the failure status
+			getTaskInfo().setStatus(new TaskStatus(new Status(Status.STATUS_CODE_FAILURE, e.getMessage())));
+			return getTaskInfo().getStatus();
 		}
 	}
 	
-	// TODO: This method should move to glusterUtil
-	private TaskStatus checkRebalanceStatus(String serverName) {
-		String command = "gluster volume rebalance " + getTaskInfo().getReference() + " status";
-		ProcessResult processResult = sshUtil.executeRemote(serverName, command);
-		TaskStatus taskStatus = new TaskStatus();
-		if (processResult.isSuccess()) {
-			if (processResult.getOutput().trim().matches(".*rebalance completed$")) {
-				taskStatus.setCode(Status.STATUS_CODE_SUCCESS);
-			} else {
-				taskStatus.setCode(Status.STATUS_CODE_RUNNING);
-			}
-		} else {
-			taskStatus.setCode(Status.STATUS_CODE_FAILURE);
-		}
-		taskStatus.setMessage(processResult.getOutput()); // Common
-		return taskStatus;
-	}
-
 	public void setLayout(String layout) {
 		this.layout = layout;
 	}
diff --git a/src/com.gluster.storage.management.server/src/com/gluster/storage/management/server/tasks/Task.java b/src/com.gluster.storage.management.server/src/com/gluster/storage/management/server/tasks/Task.java
index 49cd0b8b..c16c039a 100644
--- a/src/com.gluster.storage.management.server/src/com/gluster/storage/management/server/tasks/Task.java
+++ b/src/com.gluster.storage.management.server/src/com/gluster/storage/management/server/tasks/Task.java
@@ -33,7 +33,8 @@ public abstract class Task {
 	protected String clusterName;
 	private ClusterService clusterService;
 	
-	public Task(ClusterService clusterService, String clusterName, TASK_TYPE type, String reference, String desc, boolean canPause, boolean canStop, boolean canCommit) {
+	public Task(ClusterService clusterService, String clusterName, TASK_TYPE type, String reference, String desc,
+			boolean canPause, boolean canStop, boolean canCommit) {
 		TaskInfo taskInfo = new TaskInfo();
 		taskInfo.setType(type);
 		taskInfo.setReference(reference);
@@ -41,7 +42,7 @@ public abstract class Task {
 		taskInfo.setCanPause(canPause);
 		taskInfo.setCanStop(canStop);
 		taskInfo.setCanCommit(canCommit);
-		
+
 		init(clusterService, clusterName, taskInfo);
 		
 	}
diff --git a/src/com.gluster.storage.management.server/src/com/gluster/storage/management/server/utils/GlusterUtil.java b/src/com.gluster.storage.management.server/src/com/gluster/storage/management/server/utils/GlusterUtil.java
index 788e3eab..a09c7956 100644
--- a/src/com.gluster.storage.management.server/src/com/gluster/storage/management/server/utils/GlusterUtil.java
+++ b/src/com.gluster.storage.management.server/src/com/gluster/storage/management/server/utils/GlusterUtil.java
@@ -37,6 +37,7 @@ import com.gluster.storage.management.core.model.GlusterServer;
 import com.gluster.storage.management.core.model.GlusterServer.SERVER_STATUS;
 import com.gluster.storage.management.core.model.Status;
 import com.gluster.storage.management.core.model.TaskInfo;
+import com.gluster.storage.management.core.model.TaskStatus;
 import com.gluster.storage.management.core.model.Volume;
 import com.gluster.storage.management.core.model.Volume.TRANSPORT_TYPE;
 import com.gluster.storage.management.core.model.Volume.VOLUME_STATUS;
@@ -71,6 +72,8 @@ public class GlusterUtil {
 	private static final String VOLUME_TYPE_REPLICATE = "Replicate";
 	
 	private static final GlusterCoreUtil glusterCoreUtil = new GlusterCoreUtil();
+	
+	private static final String INITIALIZE_DISK_STATUS_SCRIPT = "initialize_disk_status.py";
 
 	@Autowired
 	private SshUtil sshUtil;
@@ -550,6 +553,42 @@ public class GlusterUtil {
 			throw new GlusterRuntimeException("Couldn't remove server [" + serverName + "]! Error: " + result);
 		}
 	}
+	
+	public TaskStatus checkRebalanceStatus(String serverName, String volumeName) {
+		String command = "gluster volume rebalance " + volumeName + " status";
+		ProcessResult processResult = sshUtil.executeRemote(serverName, command);
+		TaskStatus taskStatus = new TaskStatus();
+		if (processResult.isSuccess()) {
+			if (processResult.getOutput().trim().matches("^rebalance completed.*")) {
+				taskStatus.setCode(Status.STATUS_CODE_SUCCESS);
+			} else if(processResult.getOutput().trim().matches(".*in progress:.*")) {
+				taskStatus.setCode(Status.STATUS_CODE_RUNNING);
+			} else {
+				taskStatus.setCode(Status.STATUS_CODE_FAILURE);
+			}
+		} else {
+			taskStatus.setCode(Status.STATUS_CODE_FAILURE);
+		}
+		taskStatus.setMessage(processResult.getOutput()); // Common
+		return taskStatus;
+	}
+	
+	public TaskStatus checkInitializeDiskStatus(String serverName, String diskName) {
+		ProcessResult processResult = sshUtil.executeRemote(serverName, INITIALIZE_DISK_STATUS_SCRIPT + " " + diskName);
+		TaskStatus taskStatus = new TaskStatus();
+		if (processResult.isSuccess()) {
+			// TODO: Message needs to change according to the script return
+			if (processResult.getOutput().trim().matches(".*Initailize completed$")) {
+				taskStatus.setCode(Status.STATUS_CODE_SUCCESS);
+			} else {
+				taskStatus.setCode(Status.STATUS_CODE_RUNNING);
+			}
+		} else {
+			taskStatus.setCode(Status.STATUS_CODE_FAILURE);
+		}
+		taskStatus.setMessage(processResult.getOutput());
+		return taskStatus;
+	}
 
 	public static void main(String args[]) {
 		// List<String> names = new GlusterUtil().getGlusterServerNames();