summaryrefslogtreecommitdiffstats
path: root/transport
Commit message (Collapse)AuthorAgeFilesLines
* transport/ib-verbs: assign to qpreg before accessing it in ↵Raghavendra G2009-11-191-0/+1
| | | | | | | | | | __ib_verbs_lookup_peer. Signed-off-by: Raghavendra G <raghavendra@gluster.com> Signed-off-by: Anand V. Avati <avati@dev.gluster.com> BUG: 381 (glusterfs crash in ib-verbs) URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=381
* transport/ib-verbs: fix race-condition resulting in freeing of transport ↵Raghavendra G2009-11-161-11/+70
| | | | | | | | | | | | | | | | | while it was still being used. - while handling a failed work completion status, the transport is disconnected. But further down in the code, the transport is still used. There can be a possibility that transport might've been freed by the time control reaches this point. More detailed description of events leading to this situation can be found at http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=381 Signed-off-by: Raghavendra G <raghavendra@gluster.com> Signed-off-by: Anand V. Avati <avati@dev.gluster.com> BUG: 381 (glusterfs crash in ib-verbs) URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=381
* transport/ib-verbs: synchronize ib_verbs_recv_completion_proc with ↵Raghavendra G2009-11-162-5/+6
| | | | | | | | | | | | | | | | | | | | ib_verbs_receive so that the former doesn't overwrite the pointer from which latter reads. - There can be a condition wherein, 1. the thread executing ib_verbs_recv_completion_proc (thr 1) stores the buffer pointer and notifies the upper translators about a POLLIN event. 2. the thread waiting for events on socket (thr 2) calls transport_receive, but in ib_verbs_receive it has not still read the data. 3. thr 1 receives work completion event for another work request and overwrites the buffer pointer. 4. thr 2 reads from the new pointer there by missing the data stored in buffer pointed by pointer which got overwritten. Signed-off-by: Raghavendra G <raghavendra@gluster.com> Signed-off-by: Anand V. Avati <avati@dev.gluster.com> BUG: 382 (Data can be lost before it is read in ib_verbs_receive.) URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=382
* transport/name.c: refine the address resolution logic when listen-host is ↵Corentin Chary2009-11-032-6/+35
| | | | | | | | | | | | | | | | | not specified. - when listen-host is not specified and there are are no interfaces having adresses belonging to the address-family specified, listen at 0.0.0.0/::0. - this patch is necessary since with AI_ADDRCONFIG, getaddrinfo fails if there are no active interfaces for the address family specified and when listen-host is specified we still want the functionality provided with usage of AI_ADDRCONFIG. Signed-off-by: Corentin Chary <corentin.chary@gmail.com> Signed-off-by: Anand V. Avati <avati@dev.gluster.com> BUG: 339 (glusterfsd fails to start when there are no active interfaces having address in the address family configured.) URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=339
* transport/socket:Enable NODELAY by default for lowlat client and server socketsVijay Bellur2009-10-291-0/+80
| | | | | | | | | | TCP_NODELAY is enabled by default for lowlat client and server sockets. Signed-off-by: Vijay Bellur <vijay@gluster.com> Signed-off-by: Anand V. Avati <avati@dev.gluster.com> BUG: 344 (Add support for TCP NODELAY in master) URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=344
* transport/socket: Support for TCP_NODELAYVijay Bellur2009-10-291-0/+2
| | | | | | | | Signed-off-by: Vijay Bellur <vijay@gluster.com> Signed-off-by: Anand V. Avati <avati@dev.gluster.com> BUG: 344 (Add support for TCP NODELAY in master) URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=344
* Changed occurrences of Z Research to Gluster.Vijay Bellur2009-10-078-8/+8
| | | | Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
* transport/ib-verbs: initialize fini member of new-transports created during ↵Raghavendra G2009-09-141-0/+2
| | | | | | | | | | | accepting client connections. - This bug used to cause a memory leak of 2 * sizeof(ib_verbs_private_t) for each new client connection. Signed-off-by: Anand V. Avati <avati@dev.gluster.com> BUG: 259 (Memory leak on server side when there are large number of disconnections from clients) URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=259
* ib-verbs: handle failure of ibv_create_qp gracefully.Raghavendra G2009-09-021-0/+3
| | | | | | | Signed-off-by: Anand V. Avati <avati@dev.gluster.com> BUG: 217 (crash in ib_verbs_create_qp) URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=217
* increased ib-verbs buffer sizeAmar Tumballi2009-08-041-2/+2
| | | | | | | | | | | | | Noticed that in few cases, where ib-verbs doesn't handle a bigger sized buffer to be sent across, which happens without problem in tcp. Caused frame losses in the case where server's reply msg was bigger, hence the msg got dropped at the server end. With this patch ib-verbs buffer size is fixed to 512KB. (4 x page-size) Signed-off-by: Anand V. Avati <avati@dev.gluster.com> BUG: 190 (missing frames due to larger reply message size.. (ib-verbs)) URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=190
* client-protocol: log messages at WARNING loglevel when client_bind on ↵Raghavendra G2009-07-312-2/+2
| | | | | | | | | privileged port fails. Signed-off-by: Anand V. Avati <avati@dev.gluster.com> BUG: 140 (use appropriate loglevel to log in case of failure to bind to privileged socket) URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=140
* ib-verbs: don't append ioq_entry to pending_list if first attempt of writing ↵Raghavendra G2009-07-151-1/+1
| | | | | | | | | | | | | | | | | | to network fails * fix to bug #101 - When a buffer bigger than ib-verbs-work-request-send-size was attempted to write to network, ib-verbs returns ENOTCONN. Neverthless, the ioq_entry corresponding to the write was appended to the pending lists of ioq_entries waiting to be written to network. This resulted in double free of header, once in protocol_client_xfer and again during cleanup of transport. The transport cleanup happened due to the timeouts of subsequent operations, since ioq_entry corresponding to writev was blocking any other operations from reaching server. Signed-off-by: Anand V. Avati <avati@dev.gluster.com> BUG: 101 (ib-verbs config crashing while dd'ing with a big mtu size) URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=101
* Remove the trailing "/" which fails build with new version of automakeHarshavardhana2009-06-182-2/+2
| | | | Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
* ib-verbs error log enhancementAmar Tumballi2009-06-031-3/+10
| | | | | | | | | | | | | Earlier it was thought that only not having 'opensm' running will cause handshake errors in ib-verbs. Recently understood that even having a wrong 'ib-verbs.port' option can also cause the same behavior, and it took more than 5-6 e-mail iterations with the user and lot of brain cycle in support team to understand the problem. Made the log message more descriptive, so user can be find the cause, or can send us email without wasting time. Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
* socket: New option: Set receive and send buffer sizeShehjar Tikoo2009-05-292-3/+76
| | | | | | | ..and hope for a chance to improve performance on high speed links like 10GigE. Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
* fix crash in __socket_reset. Previously iobuf_p was an allocated pointer, ↵Anand Avati2009-05-221-2/+2
| | | | | | but since introduction of IObuf it is no more. Now iobuf has to be unref'ed instead. Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
* THIS: ib-verbs now uses xlator_notify for setting THISAnand V. Avati2009-05-221-4/+4
| | | | Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
* THIS: socket now uses xlator_notify for setting THISAnand V. Avati2009-05-221-4/+4
| | | | Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
* add 'non-blocking-io' to the options array in sockets.Amar Tumballi2009-05-201-0/+3
| | | | Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
* minor log enhancement in 'ib-verbs' transport.Amar Tumballi2009-05-161-0/+5
| | | | Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
* socket transport logging cleanupAnand V. Avati2009-04-281-5/+6
|
* cleanup of logs in socket and ib-verbs transportsAnand V. Avati2009-04-243-64/+65
| | | | Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
* disconnect transport peer if system is out of memory while allocating iobufAnand V. Avati2009-04-182-4/+26
|
* remove unused variable @ret in ib_verbs_options_initAnand V. Avati2009-04-141-1/+0
| | | | Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
* use ctx->page_size in all translators and transports instead of having their ↵Anand V. Avati2009-04-131-38/+4
| | | | | | own configurations Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
* updated transport/ib-verbs to use IOBUF/IOBREFsAnand V. Avati2009-04-122-14/+14
| | | | Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
* updated transport/socket to use IOBUF/IOBREFsAnand V. Avati2009-04-122-37/+43
| | | | Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
* fix broken transport-type unixRommer2009-04-031-1/+5
| | | | | | | fix broken transport-type "unix" however unix transport not working with defined transport.socket.bind-path Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
* Build fixes for ib-verbs compilation on solarisHarshavardhana2009-04-022-6/+22
| | | | | | Build fixes for solaris on ib-verbs with recent OFUV Update 3 release. Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
* socket_connect() - if socket is already created, do not fail ↵Anand V. Avati2009-04-021-0/+1
| | | | | | | | transport_connect() -- causes spurious CHILD_DOWN events to be sent up when reconnect() thread misinterprets the failure of transport_connect() to be an actual teardown of the transport the spurious CHILD_DOWN events cause self-heal in replicate to not heal files in that subvolume, writev to not modify that subvolume etc, accounting for a lot of discrepencies in replicate which are being in the mailing lists recently. Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
* Fixes server goes into infinite loop on Solaris when poll_err is not set.Harshavardhana2009-04-021-2/+3
| | | | | | Server goes into infinite loop when poll_err is not set. Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
* Add new type of option type INTERNET_ADDRESS for validationRaghavendra G2009-04-011-1/+1
| | | | | | | | - used to validate options like remote-host, bind-address. - Also validate options of translators created during fetch of volume specification file from remote server. Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
* ib-verbs recv-size and send-size argument takes SIZET arguments now.Amar Tumballi2009-03-182-11/+31
| | | | | | | With this patch, to specify recv-size and send-size of ib-verbs to <n>KB, we need not give the option as integer value of 'n * 1024' value. This is neater to do deployments. Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
* updated copyright header to extend copyright upto 2009Basavanagowda Kanur2009-02-268-8/+8
| | | | | | updated copyright header to include 2009. Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
* Added all filesVikas Gorur2009-02-1813-0/+5567