summaryrefslogtreecommitdiffstats
path: root/cli/src/cli-cmd-parser.c
Commit message (Collapse)AuthorAgeFilesLines
* mgmt/glusterd: unify the geo-replication status rpc messages.Kaushik BV2011-04-171-15/+1
| | | | | | | | | | | the intelligence of determining the type of status command is now at glusterd, rather then explicitly setting it while parsing at cli. Signed-off-by: Kaushik BV <kaushikbv@gluster.com> Signed-off-by: Anand Avati <avati@gluster.com> BUG: 2536 (gsync service introspection) URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2536
* TOP: validate bs/count pair for write/read-perf measurementshishir gowda2011-04-151-0/+4
| | | | | | | | | | | If either one the above args are supplied, the other arg should be supplied too. Signed-off-by: shishir gowda <shishirng@gluster.com> Signed-off-by: Anand Avati <avati@gluster.com> BUG: 2771 (bs or count tag missing with volume top write-perf/read-perf command blocks glusterd) URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2771
* top: Modified integer bounds check for count/bsKrishnan Parthasarathi2011-04-151-3/+10
| | | | | | | | Signed-off-by: Krishnan Parthasarathi <kp@gluster.com> Signed-off-by: Anand Avati <avati@gluster.com> BUG: 2721 (Incorrect validation message in gluster top CLI) URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2721
* use "geo-replication" all over as the official name of this featureCsaba Henk2011-04-151-1/+1
| | | | | | | | | | Use GEOREP macro if you want to refer to the feature in code. Signed-off-by: Csaba Henk <csaba@gluster.com> Signed-off-by: Anand Avati <avati@gluster.com> BUG: 2757 (refactory gsync/gsyncd/syncdaemon/whatever to geo-replication) URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2757
* mgmt/glusterd: Implementation of volume gsync status [master [slave]]Kaushik BV2011-04-141-1/+48
| | | | | | | | | | | | | | Changes made in the path of gsync start/stop as well, where we maintain a list of active gsync sessions, hence gsync stop could be executed at all nodes. A new dict in glusterd_volinfo_t added to maintain an active list of gsync slaves running on each master. Signed-off-by: Kaushik BV <kaushikbv@gluster.com> Signed-off-by: Anand Avati <avati@gluster.com> BUG: 2536 (gsync service introspection) URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2536
* cli: simplfy gsysnc configuration commandCsaba Henk2011-04-131-26/+23
| | | | | | | | | | | | | | | | | | | | | | | New syntax is volume gsync config <master> <slave> [[!]opt [val]] In details: - instead of "volume gsyncd configure M S config-get-all" : "volume gsyncd config M S" - instead of "volume gsyncd configure M S config-get O" : "volume gsyncd config M S O" - instead of "volume gsyncd configure M S config-del O" : "volume gsyncd config M S !O" - instead of "volume gsyncd configure M S config-set O V" : "volume gsyncd config M S O V" Signed-off-by: Csaba Henk <csaba@gluster.com> Signed-off-by: Anand Avati <avati@gluster.com> BUG: 2738 ("volume gsync configure <master> <slave> config-<subop> ..." is overly verbose) URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2738
* cli: join value arguments of "gsync config-set" with spacesKaushik BV2011-04-131-4/+33
| | | | | | | | | | | | | When a given gsync tunable is supposed to hold a command (which can take options), it's quite possible that it spaces in its value. Try to approximate this situation by joining the leftover arguments. Signed-off-by: Kaushik BV <kaushikbv@gluster.com> Signed-off-by: Csaba Henk <csaba@gluster.com> Signed-off-by: Anand Avati <avati@gluster.com> BUG: 2713 ([glusterfs-3.2.0qa10]: config-set works only for one value) URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2713
* mgmt/glusterd: volume reset force implementationPranith Kumar K2011-04-131-4/+16
| | | | | | | | Signed-off-by: Pranith Kumar K <pranithk@gluster.com> Signed-off-by: Anand Avati <avati@gluster.com> BUG: 2729 (Implement force option for volume reset) URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2729
* cli: Validating the cli quota options.Junaid2011-04-111-6/+10
| | | | | | | | Signed-off-by: Junaid <junaid@gluster.com> Signed-off-by: Anand Avati <avati@gluster.com> BUG: 2612 (quota limit-set not in line with help) URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2612
* Replace strdup call to gf_strdup as GF_FREE is being calledshishir gowda2011-04-011-2/+2
| | | | | | | | | | Also, fix validation of bs and count to <= 0. Signed-off-by: shishir gowda <shishirng@gluster.com> Signed-off-by: Vijay Bellur <vijay@dev.gluster.com> BUG: 2645 (volume top write-perf results in memory corruption) URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2645
* TOP: Validate command optionsshishir gowda2011-03-311-7/+13
| | | | | | | | Signed-off-by: shishir gowda <shishirng@gluster.com> Signed-off-by: Vijay Bellur <vijay@dev.gluster.com> BUG: 2628 () URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2628
* TOP: handle list-cnt behaviour uniformly.shishir gowda2011-03-311-7/+11
| | | | | | | | | | | Valid range is 0-100. if list-cnt is 0 or there are no files in the list, handle it uniformly. Signed-off-by: shishir gowda <shishirng@gluster.com> Signed-off-by: Vijay Bellur <vijay@dev.gluster.com> BUG: 2622 () URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2622
* Loosen restrictions on hostnamesPavan T C2011-03-291-0/+4
| | | | | | | | Signed-off-by: Pavan T C <tcp@gluster.com> Signed-off-by: Vijay Bellur <vijay@dev.gluster.com> BUG: 2249 (Problems with hostname validation) URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2249
* TOP: remove trailing '/' from brick pathshishir gowda2011-03-221-0/+2
| | | | | | | | Signed-off-by: shishir gowda <shishirng@gluster.com> Signed-off-by: Vijay Bellur <vijay@dev.gluster.com> BUG: 2573 (trailing '/' with brick name says "volume top unsuccessful" while running 'top' command) URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2573
* TOP: cli, rpc/xdr related changesshishir gowda2011-03-161-0/+133
| | | | | | | | Signed-off-by: shishir gowda <shishirng@gluster.com> Signed-off-by: Vijay Bellur <vijay@dev.gluster.com> BUG: 2516 (Implement gluster volume top command) URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2516
* cli: QUOTA cli related changes.Mohammed Junaid Ahmed2011-03-161-0/+166
| | | | | | | | Signed-off-by: Junaid <junaid@gluster.com> Signed-off-by: Vijay Bellur <vijay@dev.gluster.com> BUG: 2473 (Support for volume and directory level quota) URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2473
* cli: gluster profile CLIPranith K2011-03-101-176/+150
| | | | | | | | Signed-off-by: Pranith Kumar K <pranithk@gluster.com> Signed-off-by: Vijay Bellur <vijay@dev.gluster.com> BUG: 1965 (need a cmd to get io-stat details) URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1965
* mgmt/glusterd: prevent spurious cmd unlocksPranith K2011-02-281-13/+0
| | | | | | | | Signed-off-by: Pranith Kumar K <pranithk@gluster.com> Signed-off-by: Anand V. Avati <avati@dev.gluster.com> BUG: 2460 ([glusterfs-3.2.0-gsync1]: gluserd crashed trying to access freed request) URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2460
* glusterd/cli: option added to create volume with both transportsAmar Tumballi2011-02-221-0/+3
| | | | | | | | | | | | | | | to avail the option, enter the volume create command with arguments 'transport tcp,rdma' and while mounting, on the mountpoints which works on rdma, do, mount -t glusterfs <IP>:/<VOLNAME>-rdma <MOUNT-POINT> Signed-off-by: Amar Tumballi <amar@gluster.com> Signed-off-by: Anand V. Avati <avati@dev.gluster.com> BUG: 2294 (Currently there is no way through cli to make a volume listen on both the transports (socket/rdma)) URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2294
* gsync: cli support for gsyncd.Mohammed Junaid Ahmed2011-02-101-0/+96
| | | | | | | | Signed-off-by: Junaid <junaid@gluster.com> Signed-off-by: Anand V. Avati <avati@dev.gluster.com> BUG: 1570 (geosync related changes) URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1570
* display the error message to the user if a volume with the name is tried to ↵Raghavendra Bhat2010-11-241-1/+3
| | | | | | | | | | be created Signed-off-by: Raghavendra Bhat <raghavendrabhat@gluster.com> Signed-off-by: Anand V. Avati <avati@dev.gluster.com> BUG: 1209 () URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1209
* cli: fix memory corruption in create volume and add-brickPranith K2010-11-151-2/+17
| | | | | | | | Signed-off-by: Pranith Kumar K <pranithk@gluster.com> Signed-off-by: Anand V. Avati <avati@dev.gluster.com> BUG: 2113 (cli: memory corruption in add-brick and create volume parsing functions) URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2113
* mgmt/glusterd: set the transport type correctly in create volumePranith K2010-11-131-4/+1
| | | | | | | | Signed-off-by: Pranith Kumar K <pranithk@gluster.com> Signed-off-by: Anand V. Avati <avati@dev.gluster.com> BUG: 2095 () URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2095
* cli: remove volume type from add-brick and remove-brick cmdsPranith K2010-11-091-65/+2
| | | | | | | | Signed-off-by: Pranith Kumar K <pranithk@gluster.com> Signed-off-by: Anand V. Avati <avati@dev.gluster.com> BUG: 1983 ("type" in add-brick is completely redundant) URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1983
* Cli memory leak fix for tmp_list in cli_cmd_volume_add_brick_parsev3.1.1qa4shishir gowda2010-11-021-2/+6
| | | | | | | | Signed-off-by: shishir gowda <shishirng@gluster.com> Signed-off-by: Anand V. Avati <avati@dev.gluster.com> BUG: 2047 () URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2047
* Fix crash while freeing tmp_list in cli_cmd_volume_create_parseshishir gowda2010-11-021-3/+6
| | | | | | | | Signed-off-by: shishir gowda <shishirng@gluster.com> Signed-off-by: Anand V. Avati <avati@dev.gluster.com> BUG: 2047 () URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2047
* cli: Fix memory leaksVijay Bellur2010-10-301-0/+5
| | | | | | | | Signed-off-by: Vijay Bellur <vijay@gluster.com> Signed-off-by: Anand V. Avati <avati@dev.gluster.com> BUG: 1198 () URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1198
* mgmt/Glusterd: Memory leak fixes, minor CLI changesv3.1.0qa44Kaushik BV2010-10-091-4/+4
| | | | | | | | Signed-off-by: Kaushik BV <kaushikbv@gluster.com> Signed-off-by: Vijay Bellur <vijay@dev.gluster.com> BUG: 1852 (Usage message of volume set printed twice) URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1852
* mgmt/Glusterd : Reply to CLI error: graph constructionKaushik BV2010-10-051-1/+1
| | | | | | | | Signed-off-by: Kaushik BV <kaushikbv@gluster.com> Signed-off-by: Vijay Bellur <vijay@dev.gluster.com> BUG: 1159 () URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1159
* cli: mgmt/glusterd: Add commit force op to replace-brickPavan Sondur2010-10-041-2/+19
| | | | | | | | Signed-off-by: Pavan Vilas Sondur <pavan@gluster.com> Signed-off-by: Vijay Bellur <vijay@dev.gluster.com> BUG: 1235 (Bug for all pump/migrate commits) URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1235
* mgmt/Glusterd: new command volume reset <volname>, volume set enhancementsv3.1.0qa39Kaushik BV2010-10-031-0/+56
| | | | | | | | | | | | - Write the reconfigured options in 'info' file to make it persistant - Implementation of volume set <volname> history - Implementation of volume reset <volname> Signed-off-by: Kaushik BV <kaushikbv@gluster.com> Signed-off-by: Vijay Bellur <vijay@dev.gluster.com> BUG: 1159 () URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1159
* gluster cli: handle case of no brick given in log locate/rotatev3.1.0qa29Amar Tumballi2010-09-231-26/+30
| | | | | | | | Signed-off-by: Amar Tumballi <amar@gluster.com> Signed-off-by: Vijay Bellur <vijay@dev.gluster.com> BUG: 1679 (gluster volume log locate/rotate segfault) URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1679
* mgmt/glusterd: replace-brick validationsPranith Kumar K2010-09-221-28/+31
| | | | | | | | Signed-off-by: Pranith Kumar K <pranithk@gluster.com> Signed-off-by: Vijay Bellur <vijay@dev.gluster.com> BUG: 1657 (validations for replace-brick while stage op) URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1657
* cli: remove trailing slashes from brick pathsPranith Kumar K2010-09-211-10/+51
| | | | | | | | Signed-off-by: Pranith Kumar K <pranithk@gluster.com> Signed-off-by: Vijay Bellur <vijay@dev.gluster.com> BUG: 1659 () URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1659
* Glusterd: gluster volume set <volume> <option> <value>Kaushik BV2010-09-181-6/+10
| | | | | | | | Signed-off-by: Kaushik BV <kaushikbv@gluster.com> Signed-off-by: Vijay Bellur <vijay@dev.gluster.com> BUG: 1159 () URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1159
* Typo in log msg for volume create localhostshishir gowda2010-09-061-1/+1
| | | | | | | | Signed-off-by: shishir gowda <shishirng@gluster.com> Signed-off-by: Vijay Bellur <vijay@dev.gluster.com> BUG: 1539 (Typo in error message) URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1539
* cli: check for argument presence before accessingPranith Kumar K2010-09-061-4/+14
| | | | | | | | Signed-off-by: Pranith Kumar K <pranithk@gluster.com> Signed-off-by: Vijay Bellur <vijay@dev.gluster.com> BUG: 1543 () URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1543
* cli: stripe/replica count should be greater than 1Pranith Kumar K2010-09-061-23/+21
| | | | | | | | Signed-off-by: Pranith Kumar K <pranithk@gluster.com> Signed-off-by: Vijay Bellur <vijay@dev.gluster.com> BUG: 1534 () URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1534
* cli: In volume create check for presence of bricksPranith Kumar K2010-09-061-0/+6
| | | | | | | | Signed-off-by: Pranith Kumar K <pranithk@gluster.com> Signed-off-by: Vijay Bellur <vijay@dev.gluster.com> BUG: 1532 () URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1532
* Create volume adding transport type option rdmashishir gowda2010-09-061-0/+30
| | | | | | | | | | | | Adding transport type option to cli volume create command. This is optional, and defaults to TCP. The other transport supported is rdma Signed-off-by: shishir gowda <shishirng@gluster.com> Signed-off-by: Vijay Bellur <vijay@dev.gluster.com> BUG: 1507 (need to add 'transport <type>' options to create brick) URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1507
* Add brick hostname should not be localhostshishir gowda2010-09-061-0/+23
| | | | | | | | | | | | Add brick hostname should not be localhost or 127.0.0.1, but valid nodeid or ip. This will prevent volfiles being generated at respective glusterd's as hostname would be localhost Signed-off-by: shishir gowda <shishirng@gluster.com> Signed-off-by: Vijay Bellur <vijay@dev.gluster.com> BUG: 1505 (volume create/add-brick requires ip or hostname for localhost) URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1505
* Volume create hostname should not be localhostshishir gowda2010-09-061-0/+23
| | | | | | | | | | | | | volume create hostname should not be localhost or 127.0.0.1. It should be a valid nodeid or ip. This will prevent invalid vol files being created on glusterd's when localhost or 127.0.0.1 is specified Signed-off-by: shishir gowda <shishirng@gluster.com> Signed-off-by: Vijay Bellur <vijay@dev.gluster.com> BUG: 1505 (volume create/add-brick requires ip or hostname for localhost) URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1505
* cli: Fix clang errors.Sachidananda2010-09-031-1/+16
| | | | | | | | Signed-off-by: Sachidananda Urs <sac@gluster.com> Signed-off-by: Vijay Bellur <vijay@dev.gluster.com> BUG: 1145 () URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1145
* Remove brick validationshishir gowda2010-09-021-1/+42
| | | | | | | | | | | | Added checks for duplicate bricks in cli arguments, valid bricks for the volume, valid volume name, and prevent removing of incorrect pairs for replica. Signed-off-by: shishir gowda <shishirng@gluster.com> Signed-off-by: Vijay Bellur <vijay@dev.gluster.com> BUG: 1486 () URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1486
* 'gluster volume log' feature addedAmar Tumballi2010-08-311-0/+135
| | | | | | | | | * 'gluster volume log filename <VOLNAME> [BRICK] <path>' * 'gluster volume log locate <VOLNAME> [BRICK]' * 'gluster volume log rotate <VOLUME> [BRICK]' Signed-off-by: Amar Tumballi <amar@gluster.com> Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
* Volume Add-brick validation for exportsshishir gowda2010-08-301-0/+16
| | | | | | | | | | | | Added checks for export already in use, duplicate exports in command, and check whether exports are valid. Also, cleaned up error handling in glusterd_handle_add_bricks Signed-off-by: shishir gowda <shishirng@gluster.com> Signed-off-by: Vijay Bellur <vijay@dev.gluster.com> BUG: 1457 (volume add brick validation for export) URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1457
* cli, mgmt/glusterd: validate brickPranith Kumar K2010-08-271-6/+30
| | | | | Signed-off-by: Pranith Kumar K <pranithk@gluster.com> Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
* Cli volume create detect dup bricksshishir gowda2010-08-261-0/+16
| | | | | | | | Signed-off-by: shishir gowda <shishirng@gluster.com> Signed-off-by: Anand V. Avati <avati@dev.gluster.com> BUG: 1184 () URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1184
* cli: check if the arguments are present before accessingPranith Kumar K2010-08-251-3/+59
| | | | | | | | Signed-off-by: Pranith Kumar K <pranithk@gluster.com> Signed-off-by: Anand V. Avati <avati@dev.gluster.com> BUG: 1431 (cli: check if arguments exist before the accessing them) URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1431
* cli: validating if the arguments exist before accessing in volume createPranith Kumar K2010-08-251-0/+15
| | | | | | | | Signed-off-by: Pranith Kumar K <pranithk@gluster.com> Signed-off-by: Anand V. Avati <avati@dev.gluster.com> BUG: 1202 () URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1202