diff options
Diffstat (limited to 'xlators/protocol')
| -rw-r--r-- | xlators/protocol/client/src/client3_1-fops.c | 51 | ||||
| -rw-r--r-- | xlators/protocol/server/src/server3_1-fops.c | 24 | 
2 files changed, 44 insertions, 31 deletions
diff --git a/xlators/protocol/client/src/client3_1-fops.c b/xlators/protocol/client/src/client3_1-fops.c index 35e90c72379..be4322f2b3c 100644 --- a/xlators/protocol/client/src/client3_1-fops.c +++ b/xlators/protocol/client/src/client3_1-fops.c @@ -955,12 +955,12 @@ int  client3_1_setxattr_cbk (struct rpc_req *req, struct iovec *iov, int count,                          void *myframe)  { -        call_frame_t    *frame      = NULL; -        gf_common_rsp    rsp        = {0,}; -        int              ret        = 0; -        xlator_t *this       = NULL; -        dict_t  *xdata       = NULL; - +        call_frame_t  *frame    = NULL; +        gf_common_rsp  rsp      = {0,}; +        int            ret      = 0; +        xlator_t      *this     = NULL; +        dict_t        *xdata    = NULL; +        int            op_errno = EINVAL;          this = THIS; @@ -985,12 +985,14 @@ client3_1_setxattr_cbk (struct rpc_req *req, struct iovec *iov, int count,                                        rsp.op_errno, out);  out: +        op_errno = gf_error_to_errno (rsp.op_errno);          if (rsp.op_ret == -1) { -                gf_log (this->name, GF_LOG_WARNING, "remote operation failed: %s", -                        strerror (gf_error_to_errno (rsp.op_errno))); +                gf_log (this->name, ((op_errno == ENOTSUP) ? +                                     GF_LOG_DEBUG : GF_LOG_WARNING), +                        "remote operation failed: %s", +                        strerror (op_errno));          } -        CLIENT_STACK_UNWIND (setxattr, frame, rsp.op_ret, -                             gf_error_to_errno (rsp.op_errno), xdata); +        CLIENT_STACK_UNWIND (setxattr, frame, rsp.op_ret, op_errno, xdata);          if (rsp.xdata.xdata_val)                  free (rsp.xdata.xdata_val); @@ -1048,7 +1050,8 @@ client3_1_getxattr_cbk (struct rpc_req *req, struct iovec *iov, int count,  out:          if (rsp.op_ret == -1) { -                gf_log (this->name, GF_LOG_WARNING, +                gf_log (this->name, ((op_errno == ENOTSUP) ? +                                     GF_LOG_DEBUG : GF_LOG_WARNING),                          "remote operation failed: %s. Path: %s",                          strerror (op_errno),                          (local) ? local->loc.path : "--"); @@ -1117,7 +1120,8 @@ client3_1_fgetxattr_cbk (struct rpc_req *req, struct iovec *iov, int count,  out:          if (rsp.op_ret == -1) { -                gf_log (this->name, GF_LOG_WARNING, +                gf_log (this->name, ((op_errno == ENOTSUP) ? +                                     GF_LOG_DEBUG : GF_LOG_WARNING),                          "remote operation failed: %s",                          strerror (op_errno));          } @@ -1794,12 +1798,12 @@ int  client3_1_fsetxattr_cbk (struct rpc_req *req, struct iovec *iov, int count,                           void *myframe)  { -        call_frame_t    *frame      = NULL; -        gf_common_rsp    rsp        = {0,}; -        int              ret        = 0; -        xlator_t *this       = NULL; -        dict_t  *xdata       = NULL; - +        call_frame_t  *frame    = NULL; +        gf_common_rsp  rsp      = {0,}; +        int            ret      = 0; +        xlator_t      *this     = NULL; +        dict_t        *xdata    = NULL; +        int            op_errno = EINVAL;          this = THIS; @@ -1823,12 +1827,15 @@ client3_1_fsetxattr_cbk (struct rpc_req *req, struct iovec *iov, int count,                                        rsp.op_errno, out);  out: +        op_errno = gf_error_to_errno (rsp.op_errno);          if (rsp.op_ret == -1) { -                gf_log (this->name, GF_LOG_WARNING, "remote operation failed: %s", -                        strerror (gf_error_to_errno (rsp.op_errno))); +                gf_log (this->name, ((op_errno == ENOTSUP) ? +                                     GF_LOG_DEBUG : GF_LOG_WARNING), +                        "remote operation failed: %s", +                        strerror (op_errno));          } -        CLIENT_STACK_UNWIND (fsetxattr, frame, rsp.op_ret, -                             gf_error_to_errno (rsp.op_errno), xdata); + +        CLIENT_STACK_UNWIND (fsetxattr, frame, rsp.op_ret, op_errno, xdata);          if (rsp.xdata.xdata_val)                  free (rsp.xdata.xdata_val); diff --git a/xlators/protocol/server/src/server3_1-fops.c b/xlators/protocol/server/src/server3_1-fops.c index 7c64b5f9f5c..914d5160dbe 100644 --- a/xlators/protocol/server/src/server3_1-fops.c +++ b/xlators/protocol/server/src/server3_1-fops.c @@ -812,7 +812,8 @@ out:          rsp.op_errno      = gf_errno_to_error (op_errno);          if (op_ret == -1) -                gf_log (this->name, GF_LOG_INFO, +                gf_log (this->name, ((op_errno == ENOTSUP) ? +                                     GF_LOG_DEBUG : GF_LOG_INFO),                          "%"PRId64": GETXATTR %s (%s) ==> %"PRId32" (%s)",                          frame->root->unique, state->loc.path,                          state->name, op_ret, strerror (op_errno)); @@ -858,7 +859,8 @@ out:          rsp.op_errno      = gf_errno_to_error (op_errno);          if (op_ret == -1) -                gf_log (this->name, GF_LOG_INFO, +                gf_log (this->name, ((op_errno == ENOTSUP) ? +                                     GF_LOG_DEBUG : GF_LOG_INFO),                          "%"PRId64": FGETXATTR %"PRId64" (%s) ==> %"PRId32" (%s)",                          frame->root->unique, state->resolve.fd_no,                          state->name, op_ret, strerror (op_errno)); @@ -889,12 +891,15 @@ server_setxattr_cbk (call_frame_t *frame, void *cookie, xlator_t *this,          rsp.op_ret    = op_ret;          rsp.op_errno  = gf_errno_to_error (op_errno); -        if (op_ret == -1) -                gf_log (this->name, GF_LOG_INFO, -                        "%"PRId64": SETXATTR %s (%s) ==> %"PRId32" (%s)", +        if (op_ret == -1) { +                gf_log (this->name, ((op_errno == ENOTSUP) ? +                                     GF_LOG_DEBUG : GF_LOG_INFO), +                        "%"PRId64": SETXATTR %s (%s) ==> %s (%s)",                          frame->root->unique, state->loc.path,                          state->loc.inode ? uuid_utoa (state->loc.inode->gfid) : -                        "--", op_ret, strerror (op_errno)); +                        "--", state->dict->members_list->key, +                        strerror (op_errno)); +        }          GF_PROTOCOL_DICT_SERIALIZE (this, xdata, (&rsp.xdata.xdata_val),                                      rsp.xdata.xdata_len, op_errno, out); @@ -926,11 +931,12 @@ server_fsetxattr_cbk (call_frame_t *frame, void *cookie, xlator_t *this,          state = CALL_STATE(frame);          if (op_ret == -1) -                gf_log (this->name, GF_LOG_INFO, -                        "%"PRId64": FSETXATTR %"PRId64" (%s) ==> %"PRId32" (%s)", +                gf_log (this->name, ((op_errno == ENOTSUP) ? +                                     GF_LOG_DEBUG : GF_LOG_INFO), +                        "%"PRId64": FSETXATTR %"PRId64" (%s) ==> %s (%s)",                          frame->root->unique, state->resolve.fd_no,                          state->fd ? uuid_utoa (state->fd->inode->gfid) : "--", -                        op_ret, strerror (op_errno)); +                        state->dict->members_list->key, strerror (op_errno));          GF_PROTOCOL_DICT_SERIALIZE (this, xdata, (&rsp.xdata.xdata_val),                                      rsp.xdata.xdata_len, op_errno, out);  | 
