diff options
Diffstat (limited to 'libglusterfs/src/common-utils.c')
| -rw-r--r-- | libglusterfs/src/common-utils.c | 16 |
1 files changed, 12 insertions, 4 deletions
diff --git a/libglusterfs/src/common-utils.c b/libglusterfs/src/common-utils.c index 543f8601ebe..374b76b0410 100644 --- a/libglusterfs/src/common-utils.c +++ b/libglusterfs/src/common-utils.c @@ -4238,16 +4238,26 @@ gf_backtrace_fillframes (char *buf) size_t idx = 0; size_t pos = 0; size_t inc = 0; - char tmpl[32] = "/tmp/btXXXXXX"; + char tmpl[] = "/tmp/glfs-bt-XXXXXX"; frames = backtrace (array, GF_BACKTRACE_FRAME_COUNT); if (!frames) return -1; - fd = gf_mkostemp (tmpl, 0, O_RDWR); + /* coverity[secure_temp] mkstemp uses 0600 as the mode and is safe */ + fd = mkstemp (tmpl); if (fd == -1) return -1; + /* Calling unlink so that when the file is closed or program + * terminates the temporary file is deleted. + */ + ret = sys_unlink (tmpl); + if (ret < 0) { + gf_msg (THIS->name, GF_LOG_INFO, 0, LG_MSG_FILE_OP_FAILED, + "Unable to delete temporary file: %s", tmpl); + } + /*The most recent two frames are the calling function and * gf_backtrace_save, which we can infer.*/ @@ -4280,8 +4290,6 @@ out: if (fp) fclose (fp); - sys_unlink (tmpl); - return (idx > 0)? 0: -1; } |