diff options
| -rw-r--r-- | rpc/rpc-lib/src/protocol-common.h | 1 | ||||
| -rw-r--r-- | rpc/xdr/src/glusterfs3-xdr.x | 12 | ||||
| -rw-r--r-- | xlators/protocol/client/src/client-helpers.c | 78 | ||||
| -rw-r--r-- | xlators/protocol/client/src/client-mem-types.h | 1 | ||||
| -rw-r--r-- | xlators/protocol/client/src/client-rpc-fops.c | 119 | ||||
| -rw-r--r-- | xlators/protocol/client/src/client.c | 29 | ||||
| -rw-r--r-- | xlators/protocol/client/src/client.h | 9 | ||||
| -rw-r--r-- | xlators/protocol/server/src/server-helpers.c | 36 | ||||
| -rw-r--r-- | xlators/protocol/server/src/server-rpc-fops.c | 126 | ||||
| -rw-r--r-- | xlators/protocol/server/src/server.h | 4 | 
10 files changed, 413 insertions, 2 deletions
diff --git a/rpc/rpc-lib/src/protocol-common.h b/rpc/rpc-lib/src/protocol-common.h index ae6189d2e9b..915d358e707 100644 --- a/rpc/rpc-lib/src/protocol-common.h +++ b/rpc/rpc-lib/src/protocol-common.h @@ -64,6 +64,7 @@ enum gf_fop_procnum {          GFS3_OP_COMPOUND,          GFS3_OP_LEASE,          GFS3_OP_GETACTIVELK, +        GFS3_OP_SETACTIVELK,          GFS3_OP_MAXVALUE,  }; diff --git a/rpc/xdr/src/glusterfs3-xdr.x b/rpc/xdr/src/glusterfs3-xdr.x index f0c5f12301f..dcd10cb23b7 100644 --- a/rpc/xdr/src/glusterfs3-xdr.x +++ b/rpc/xdr/src/glusterfs3-xdr.x @@ -980,3 +980,15 @@ struct gfs3_getactivelk_req {          opaque gfid[16];          opaque xdata<>;  }; + +struct gfs3_setactivelk_rsp { +        int    op_ret; +        int    op_errno; +        opaque   xdata<>; +}; + +struct gfs3_setactivelk_req { +        opaque gfid[16]; +        struct gfs3_locklist *request; +        opaque xdata<>; +}; diff --git a/xlators/protocol/client/src/client-helpers.c b/xlators/protocol/client/src/client-helpers.c index c28a7cb4cbd..351a10be6e6 100644 --- a/xlators/protocol/client/src/client-helpers.c +++ b/xlators/protocol/client/src/client-helpers.c @@ -1806,3 +1806,81 @@ clnt_unserialize_rsp_locklist (xlator_t *this, struct gfs3_getactivelk_rsp *rsp,  out:          return ret;  } + +void +clnt_setactivelk_req_cleanup (gfs3_setactivelk_req *req) +{ +        gfs3_locklist   *trav = NULL; +        gfs3_locklist   *next = NULL; + +        trav = req->request; + +        while (trav) { +                next = trav->nextentry; +                GF_FREE (trav->client_uid); +                GF_FREE (trav); +                trav = next; +        } +} + +int +serialize_req_locklist (lock_migration_info_t *locklist, +                        gfs3_setactivelk_req *req) +{ +        lock_migration_info_t   *tmp    = NULL; +        gfs3_locklist           *trav   = NULL; +        gfs3_locklist           *prev   = NULL; +        int                     ret     = -1; + +        GF_VALIDATE_OR_GOTO ("server", locklist, out); +        GF_VALIDATE_OR_GOTO ("server", req, out); + +        list_for_each_entry (tmp, &locklist->list, list) { +                trav = GF_CALLOC (1, sizeof (*trav), +                                  gf_client_mt_clnt_lock_request_t); +                if (!trav) +                        goto out; + +                switch (tmp->flock.l_type) { +                case F_RDLCK: +                        tmp->flock.l_type = GF_LK_F_RDLCK; +                        break; +                case F_WRLCK: +                        tmp->flock.l_type = GF_LK_F_WRLCK; +                        break; +                case F_UNLCK: +                        tmp->flock.l_type = GF_LK_F_UNLCK; +                        break; + +                default: +                        gf_msg (THIS->name, GF_LOG_ERROR, 0, 0, +                                "Unknown lock type: %"PRId32"!", +                                tmp->flock.l_type); +                        break; +                } + +                gf_proto_flock_from_flock (&trav->flock, &tmp->flock); + +                trav->client_uid = gf_strdup (tmp->client_uid); +                if (!trav->client_uid) { +                        gf_msg (THIS->name, GF_LOG_ERROR, 0, 0, +                                "client_uid could not be allocated"); +                        ret = -1; +                        goto out; +                } + +                if (prev) +                        prev->nextentry = trav; +                else +                        req->request = trav; + +                prev = trav; +                trav = NULL; +        } + +        ret = 0; +out: +        GF_FREE (trav); + +        return ret; +} diff --git a/xlators/protocol/client/src/client-mem-types.h b/xlators/protocol/client/src/client-mem-types.h index e6cb9a2e0f4..1e995414ed8 100644 --- a/xlators/protocol/client/src/client-mem-types.h +++ b/xlators/protocol/client/src/client-mem-types.h @@ -22,6 +22,7 @@ enum gf_client_mem_types_ {          gf_client_mt_clnt_fd_lk_local_t,          gf_client_mt_clnt_args_t,          gf_client_mt_compound_req_t, +        gf_client_mt_clnt_lock_request_t,          gf_client_mt_end,  };  #endif /* __CLIENT_MEM_TYPES_H__ */ diff --git a/xlators/protocol/client/src/client-rpc-fops.c b/xlators/protocol/client/src/client-rpc-fops.c index 3b4f1c45ed0..8d7da4e0d29 100644 --- a/xlators/protocol/client/src/client-rpc-fops.c +++ b/xlators/protocol/client/src/client-rpc-fops.c @@ -3093,6 +3093,60 @@ out:          return 0;  } +static int +client3_3_setactivelk_cbk (struct rpc_req *req, struct iovec *iov, int count, +                             void *myframe) +{ +        call_frame_t            *frame = NULL; +        gfs3_getactivelk_rsp     rsp   = {0,}; +        int32_t                  ret   = 0; +        clnt_local_t            *local = NULL; +        xlator_t                *this  = NULL; +        dict_t                  *xdata = NULL; + +        this = THIS; + +        frame = myframe; +        local = frame->local; + +        if (-1 == req->rpc_status) { +                rsp.op_ret   = -1; +                rsp.op_errno = ENOTCONN; +                goto out; +        } + +        ret = xdr_to_generic (*iov, &rsp, (xdrproc_t)xdr_gfs3_setactivelk_rsp); +        if (ret < 0) { +                gf_msg (this->name, GF_LOG_ERROR, EINVAL, +                        PC_MSG_XDR_DECODING_FAILED, "XDR decoding failed"); +                rsp.op_ret   = -1; +                rsp.op_errno = EINVAL; +                goto out; +        } + +        GF_PROTOCOL_DICT_UNSERIALIZE (this, xdata, (rsp.xdata.xdata_val), +                                      (rsp.xdata.xdata_len), ret, +                                      rsp.op_errno, out); + +out: +        if (rsp.op_ret == -1) { +                gf_msg (this->name, GF_LOG_WARNING, +                        gf_error_to_errno (rsp.op_errno), +                        PC_MSG_REMOTE_OP_FAILED, +                        "remote operation failed"); +        } + +        CLIENT_STACK_UNWIND (setactivelk, frame, rsp.op_ret, +                             gf_error_to_errno (rsp.op_errno), xdata); + +        free (rsp.xdata.xdata_val); + +        if (xdata) +                dict_unref (xdata); + +        return 0; +} +  int  client3_3_compound_cbk (struct rpc_req *req, struct iovec *iov, int count,                          void *myframe) @@ -6232,6 +6286,68 @@ unwind:          return 0;  } +static int32_t +client3_3_setactivelk (call_frame_t *frame, xlator_t *this, +                        void *data) +{ +        clnt_conf_t   *conf             = NULL; +        clnt_args_t   *args             = NULL; +        gfs3_setactivelk_req  req      = {{0,},}; +        int            ret              = 0; +        int            op_errno         = ESTALE; + +        if (!frame || !this || !data) +                goto unwind; + +        args = data; +        if (!(args->loc && args->loc->inode && args->locklist)) +                goto unwind; + +        if (!gf_uuid_is_null (args->loc->inode->gfid)) +                memcpy (req.gfid,  args->loc->inode->gfid, 16); +        else +                memcpy (req.gfid, args->loc->gfid, 16); + +        GF_ASSERT_AND_GOTO_WITH_ERROR (this->name, +                                       !gf_uuid_is_null (*((uuid_t *)req.gfid)), +                                       unwind, op_errno, EINVAL); +        conf = this->private; + +        GF_PROTOCOL_DICT_SERIALIZE (this, args->xdata, (&req.xdata.xdata_val), +                                    req.xdata.xdata_len, op_errno, unwind); + +        ret = serialize_req_locklist (args->locklist, &req); + +        if (ret) +                goto unwind; + +        ret = client_submit_request (this, &req, frame, conf->fops, +                                     GFS3_OP_SETACTIVELK, client3_3_setactivelk_cbk, NULL, +                                     NULL, 0, NULL, 0, NULL, +                                     (xdrproc_t)xdr_gfs3_setactivelk_req); +        if (ret) { +                gf_msg (this->name, GF_LOG_WARNING, 0, PC_MSG_FOP_SEND_FAILED, +                        "failed to send the fop"); +        } + + +        clnt_setactivelk_req_cleanup (&req); + +        GF_FREE (req.xdata.xdata_val); + +        return 0; + +unwind: + +        CLIENT_STACK_UNWIND (setactivelk, frame, -1, op_errno, NULL); + +        GF_FREE (req.xdata.xdata_val); + +        clnt_setactivelk_req_cleanup (&req); + +        return 0; +} +  /* Table Specific to FOPS */  rpc_clnt_procedure_t clnt3_3_fop_actors[GF_FOP_MAXVALUE] = {          [GF_FOP_NULL]         = { "NULL",         NULL}, @@ -6286,7 +6402,7 @@ rpc_clnt_procedure_t clnt3_3_fop_actors[GF_FOP_MAXVALUE] = {          [GF_FOP_SEEK]         = { "SEEK",         client3_3_seek },          [GF_FOP_LEASE]        = { "LEASE",        client3_3_lease },          [GF_FOP_GETACTIVELK]  = { "GETACTIVELK", client3_3_getactivelk}, - +        [GF_FOP_SETACTIVELK]  = { "SETACTIVELK", client3_3_setactivelk},  };  /* Used From RPC-CLNT library to log proper name of procedure based on number */ @@ -6342,6 +6458,7 @@ char *clnt3_3_fop_names[GFS3_OP_MAXVALUE] = {          [GFS3_OP_SEEK]        = "SEEK",          [GFS3_OP_LEASE]       = "LEASE",          [GFS3_OP_GETACTIVELK] = "GETACTIVELK", +        [GFS3_OP_SETACTIVELK] = "SETACTIVELK",  };  rpc_clnt_prog_t clnt3_3_fop_prog = { diff --git a/xlators/protocol/client/src/client.c b/xlators/protocol/client/src/client.c index 4810f75ac25..14af6fb03c5 100644 --- a/xlators/protocol/client/src/client.c +++ b/xlators/protocol/client/src/client.c @@ -2095,6 +2095,34 @@ out:  }  int32_t +client_setactivelk (call_frame_t *frame, xlator_t *this, loc_t *loc, +                      lock_migration_info_t *locklist, dict_t *xdata) +{ +        int          ret  = -1; +        clnt_conf_t *conf = NULL; +        rpc_clnt_procedure_t *proc = NULL; +        clnt_args_t  args = {0,}; + +        conf = this->private; +        if (!conf || !conf->fops) +                goto out; + + +        args.loc = loc; +        args.xdata = xdata; +        args.locklist = locklist; + +        proc = &conf->fops->proctable[GF_FOP_SETACTIVELK]; +        if (proc->fn) +                ret = proc->fn (frame, this, &args); +out: +        if (ret) +                STACK_UNWIND_STRICT (setactivelk, frame, -1, ENOTCONN, NULL); + +        return 0; +} + +int32_t  client_getspec (call_frame_t *frame, xlator_t *this, const char *key,                  int32_t flags)  { @@ -2921,6 +2949,7 @@ struct xlator_fops fops = {          .lease       = client_lease,          .compound    = client_compound,          .getactivelk = client_getactivelk, +        .setactivelk = client_setactivelk,  }; diff --git a/xlators/protocol/client/src/client.h b/xlators/protocol/client/src/client.h index c12c45605b5..46a7875682e 100644 --- a/xlators/protocol/client/src/client.h +++ b/xlators/protocol/client/src/client.h @@ -267,6 +267,7 @@ typedef struct client_args {          mode_t              umask;          dict_t             *xdata; +        lock_migration_info_t *locklist;  } clnt_args_t;  typedef ssize_t (*gfs_serialize_t) (struct iovec outmsg, void *args); @@ -366,4 +367,12 @@ clnt_unserialize_rsp_locklist (xlator_t *this, struct gfs3_getactivelk_rsp *rsp,                                 lock_migration_info_t *lmi);  void  clnt_getactivelk_rsp_cleanup (gfs3_getactivelk_rsp *rsp); + +void +clnt_setactivelk_req_cleanup (gfs3_setactivelk_req *req); + +int +serialize_req_locklist (lock_migration_info_t *locklist, +                        gfs3_setactivelk_req *req); +  #endif /* !_CLIENT_H */ diff --git a/xlators/protocol/server/src/server-helpers.c b/xlators/protocol/server/src/server-helpers.c index 146c13c3c2f..dc127a6cdcd 100644 --- a/xlators/protocol/server/src/server-helpers.c +++ b/xlators/protocol/server/src/server-helpers.c @@ -1309,3 +1309,39 @@ server_inode_new (inode_table_t *itable, uuid_t gfid) {                  return inode_new (itable);  } +int +unserialize_req_locklist (gfs3_setactivelk_req *req, +                          lock_migration_info_t *lmi) +{ +        struct gfs3_locklist            *trav      = NULL; +        lock_migration_info_t           *temp    = NULL; +        char                            *buf       = NULL; +        int                             entry_len = 0; +        int                             ret       = -1; + +        trav = req->request; + +        INIT_LIST_HEAD (&lmi->list); + +        while (trav) { +                temp = GF_CALLOC (1, sizeof (*lmi), gf_common_mt_lock_mig); +                if (temp == NULL) { +                        gf_msg (THIS->name, GF_LOG_ERROR, 0, 0, "No memory"); +                        goto out; +                } + +                INIT_LIST_HEAD (&temp->list); + +                gf_proto_flock_to_flock (&trav->flock, &temp->flock); + +                temp->client_uid =  gf_strdup (trav->client_uid); + +                list_add_tail (&temp->list, &lmi->list); + +                trav = trav->nextentry; +        } + +        ret = 0; +out: +        return ret; +} diff --git a/xlators/protocol/server/src/server-rpc-fops.c b/xlators/protocol/server/src/server-rpc-fops.c index 8a1b14bf7f6..72824781406 100644 --- a/xlators/protocol/server/src/server-rpc-fops.c +++ b/xlators/protocol/server/src/server-rpc-fops.c @@ -2209,6 +2209,44 @@ out:          return 0;  } +static int +server_setactivelk_cbk (call_frame_t *frame, void *cookie, xlator_t *this, +                        int32_t op_ret, int32_t op_errno, dict_t *xdata) +{ +        gfs3_setactivelk_rsp   rsp     = {0,}; +        server_state_t          *state  = NULL; +        rpcsvc_request_t        *req    = NULL; +        int                     ret     = 0; + +        state = CALL_STATE (frame); + +        GF_PROTOCOL_DICT_SERIALIZE (this, xdata, &rsp.xdata.xdata_val, +                                    rsp.xdata.xdata_len, op_errno, out); + +        if (op_ret < 0) { +                state = CALL_STATE (frame); +                gf_msg (this->name, GF_LOG_INFO, +                        op_errno, 0, +                        "%"PRId64": SETACTIVELK %s (%s) ==> (%s)", +                        frame->root->unique, state->loc.path, +                        uuid_utoa (state->resolve.gfid), +                        strerror (op_errno)); +                goto out; +        } + +out: +        rsp.op_ret    = op_ret; +        rsp.op_errno  = gf_errno_to_error (op_errno); + +        req = frame->local; + +        server_submit_reply (frame, req, &rsp, NULL, 0, NULL, +                             (xdrproc_t)xdr_gfs3_setactivelk_rsp); + +        GF_FREE (rsp.xdata.xdata_val); + +        return 0; +}  /* Resume function section */ @@ -3375,6 +3413,28 @@ err:  } +int +server_setactivelk_resume (call_frame_t *frame, xlator_t *bound_xl) +{ +        server_state_t *state = NULL; + +        state = CALL_STATE (frame); + +        if (state->resolve.op_ret != 0) +                goto err; + +        STACK_WIND (frame, server_setactivelk_cbk, +                    bound_xl, bound_xl->fops->setactivelk, &state->loc, +                    &state->locklist, state->xdata); +        return 0; +err: +        server_setactivelk_cbk (frame, NULL, frame->this, +                                 state->resolve.op_ret, +                                 state->resolve.op_errno, NULL); +        return 0; + +} +  /* Fop section */  int @@ -6646,6 +6706,69 @@ out:          return ret;  } + +static int +server3_3_setactivelk (rpcsvc_request_t *req) +{ +        server_state_t          *state          = NULL; +        call_frame_t            *frame          = NULL; +        gfs3_setactivelk_req   args            = {{0,},}; +        size_t                  headers_size    = 0; +        int                     ret             = -1; +        int                     op_errno        = 0; + +        if (!req) +                return ret; + +        ret = xdr_to_generic (req->msg[0], &args, +                              (xdrproc_t)xdr_gfs3_setactivelk_req); +        if (ret < 0) { +                SERVER_REQ_SET_ERROR (req, ret); +                goto out; +        } + +        frame = get_frame_from_request (req); +        if (!frame) { +                SERVER_REQ_SET_ERROR (req, ret); +                goto out; +        } + +        frame->root->op = GF_FOP_SETACTIVELK; + +        state = CALL_STATE (frame); +        if (!frame->root->client->bound_xl) { +                SERVER_REQ_SET_ERROR (req, ret); +                goto out; +        } + +        state->resolve.type = RESOLVE_MUST; +        memcpy (state->resolve.gfid, args.gfid, 16); + +        /* here, dict itself works as xdata */ +        GF_PROTOCOL_DICT_UNSERIALIZE (frame->root->client->bound_xl, +                                      state->xdata, +                                      (args.xdata.xdata_val), +                                      (args.xdata.xdata_len), ret, +                                      op_errno, out); + +        ret = unserialize_req_locklist (&args, &state->locklist); +        if (ret) +                goto out; + +        ret = 0; + +        resolve_and_resume (frame, server_setactivelk_resume); +out: +        free (args.xdata.xdata_val); + +        if (op_errno) +                SERVER_REQ_SET_ERROR (req, ret); + +        free (args.xdata.xdata_val); + +        return ret; +} +  rpcsvc_actor_t glusterfs3_3_fop_actors[GLUSTER_FOP_PROCCNT] = {          [GFS3_OP_NULL]         = {"NULL",         GFS3_OP_NULL,         server_null,            NULL, 0, DRC_NA},          [GFS3_OP_STAT]         = {"STAT",         GFS3_OP_STAT,         server3_3_stat,         NULL, 0, DRC_NA}, @@ -6697,7 +6820,8 @@ rpcsvc_actor_t glusterfs3_3_fop_actors[GLUSTER_FOP_PROCCNT] = {          [GFS3_OP_IPC]          = {"IPC",          GFS3_OP_IPC,          server3_3_ipc,          NULL, 0, DRC_NA},          [GFS3_OP_SEEK]         = {"SEEK",         GFS3_OP_SEEK,         server3_3_seek,         NULL, 0, DRC_NA},          [GFS3_OP_LEASE]       =  {"LEASE",        GFS3_OP_LEASE,        server3_3_lease,        NULL, 0, DRC_NA}, -        [GFS3_OP_GETACTIVELK] = {"GETACTIVELK", GFS3_OP_GETACTIVELK, server3_3_getactivelk, NULL, 0, DRC_NA}, +        [GFS3_OP_GETACTIVELK]  = {"GETACTIVELK", GFS3_OP_GETACTIVELK, server3_3_getactivelk, NULL, 0, DRC_NA}, +        [GFS3_OP_SETACTIVELK]  = {"SETACTIVELK", GFS3_OP_SETACTIVELK, server3_3_setactivelk, NULL, 0, DRC_NA},  }; diff --git a/xlators/protocol/server/src/server.h b/xlators/protocol/server/src/server.h index f2140dbb087..163cf2b9918 100644 --- a/xlators/protocol/server/src/server.h +++ b/xlators/protocol/server/src/server.h @@ -160,6 +160,7 @@ struct _server_state {          dict_t           *xdata;          mode_t            umask;          struct gf_lease   lease; +        lock_migration_info_t locklist;  }; @@ -185,4 +186,7 @@ int gf_server_check_getxattr_cmd (call_frame_t *frame, const char *name);  void  forget_inode_if_no_dentry (inode_t *inode); +int +unserialize_req_locklist (gfs3_setactivelk_req *req, +                          lock_migration_info_t *lmi);  #endif /* !_SERVER_H */  | 
