summaryrefslogtreecommitdiffstats
path: root/xlators/storage/posix
diff options
context:
space:
mode:
authorKotresh HR <khiremat@redhat.com>2017-08-01 07:51:44 -0400
committerAmar Tumballi <amarts@redhat.com>2017-08-29 12:52:46 +0000
commit3ec63650bb7fd874a5013e7be4a2def3b519c9b2 (patch)
treed778b633f55b0f06db973ec518a9d9cd49808a5c /xlators/storage/posix
parentea8c9af0b4a91ef927bbeee9afdfa7d1cea6369f (diff)
feature/posix: Enabled gfid2path by default
Enable gfid2path feature by default. The basic performance tests are carried out and it doesn't show significant depreciation. The results are updated in issue. Updates: #139 Change-Id: I5f1949a608d0827018ef9d548d5d69f3bb7744fd Signed-off-by: Kotresh HR <khiremat@redhat.com> Reviewed-on: https://review.gluster.org/17950 Smoke: Gluster Build System <jenkins@build.gluster.org> CentOS-regression: Gluster Build System <jenkins@build.gluster.org> Reviewed-by: Aravinda VK <avishwan@redhat.com> Reviewed-by: Amar Tumballi <amarts@redhat.com>
Diffstat (limited to 'xlators/storage/posix')
-rw-r--r--xlators/storage/posix/src/posix.c16
1 files changed, 3 insertions, 13 deletions
diff --git a/xlators/storage/posix/src/posix.c b/xlators/storage/posix/src/posix.c
index dc9fc0f8436..1e50ad79b78 100644
--- a/xlators/storage/posix/src/posix.c
+++ b/xlators/storage/posix/src/posix.c
@@ -7663,18 +7663,6 @@ init (xlator_t *this)
" set.");
}
- tmp_data = dict_get (this->options, "gfid2path");
- if (tmp_data) {
- if (gf_string2boolean (tmp_data->data,
- &_private->gfid2path) == -1) {
- ret = -1;
- gf_msg (this->name, GF_LOG_ERROR, 0,
- P_MSG_INVALID_OPTION, "wrong value provided "
- "for 'gfid2path'");
- goto out;
- }
- }
-
ret = dict_get_str (this->options, "glusterd-uuid", &guuid);
if (!ret) {
if (gf_uuid_parse (guuid, _private->glusterd_uuid))
@@ -7841,6 +7829,8 @@ init (xlator_t *this)
goto out;
}
+ GF_OPTION_INIT ("gfid2path", _private->gfid2path, bool, out);
+
GF_OPTION_INIT ("gfid2path-separator", gfid2path_sep, str, out);
if (set_gfid2path_separator (_private, gfid2path_sep) != 0) {
gf_msg (this->name, GF_LOG_ERROR, 0, P_MSG_INVALID_ARGUMENT,
@@ -8045,7 +8035,7 @@ struct volume_options options[] = {
},
{ .key = {"gfid2path"},
.type = GF_OPTION_TYPE_BOOL,
- .default_value = "off",
+ .default_value = "on",
.description = "Enable logging metadata for gfid to path conversion"
},
{ .key = {"gfid2path-separator"},