summaryrefslogtreecommitdiffstats
path: root/xlators/storage/posix/src/posix.c
diff options
context:
space:
mode:
authorRavishankar N <ravishankar@redhat.com>2016-08-05 11:22:18 +0000
committerPranith Kumar Karampuri <pkarampu@redhat.com>2016-08-05 09:06:51 -0700
commitcf51bc699646359be92969024a52c225e7ee55a1 (patch)
treed23e5efee0c6d3b07c548c2150de725fca5efa15 /xlators/storage/posix/src/posix.c
parentd297d2bdfc4d5ba99c37b22dd1ae0f8e8e92fe7b (diff)
posix: honour fsync flags in posix_do_zerofill
commit 6d994661db96cad43f26d0d1e2fba31dce9a76f5 introduced fallocate + FALLOC_FL_ZERO_RANGE to do posix_do_zerofill but did not do an fsync if O_SYNC or O_DSYNC fd flags were set. Prashant Pai pointed out performing fallocate(2) does not remove the necessity to do fsyncs if durability is desired: http://linux-fsdevel.vger.kernel.narkive.com/bDmrAUlh/fallocate-falloc-fl-punch-hole So fixed it to honour the fd flags. Change-Id: I27ae90b429185d0af29a5e632c4a8b242075a899 BUG: 1364449 Signed-off-by: Ravishankar N <ravishankar@redhat.com> Reviewed-on: http://review.gluster.org/15100 Reviewed-by: Prashanth Pai <ppai@redhat.com> Smoke: Gluster Build System <jenkins@build.gluster.org> NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org> Reviewed-by: Niels de Vos <ndevos@redhat.com> CentOS-regression: Gluster Build System <jenkins@build.gluster.org> Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
Diffstat (limited to 'xlators/storage/posix/src/posix.c')
-rw-r--r--xlators/storage/posix/src/posix.c4
1 files changed, 2 insertions, 2 deletions
diff --git a/xlators/storage/posix/src/posix.c b/xlators/storage/posix/src/posix.c
index cee4539d2e2..0598b9525df 100644
--- a/xlators/storage/posix/src/posix.c
+++ b/xlators/storage/posix/src/posix.c
@@ -858,7 +858,7 @@ posix_do_zerofill (call_frame_t *frame, xlator_t *this, fd_t *fd, off_t offset,
flags = FALLOC_FL_ZERO_RANGE;
ret = sys_fallocate (pfd->fd, flags, offset, len);
if (ret == 0)
- goto done;
+ goto fsync;
ret = _posix_do_zerofill (pfd->fd, offset, len, pfd->flags & O_DIRECT);
if (ret < 0) {
@@ -869,6 +869,7 @@ posix_do_zerofill (call_frame_t *frame, xlator_t *this, fd_t *fd, off_t offset,
goto out;
}
+fsync:
if (pfd->flags & (O_SYNC|O_DSYNC)) {
ret = sys_fsync (pfd->fd);
if (ret) {
@@ -880,7 +881,6 @@ posix_do_zerofill (call_frame_t *frame, xlator_t *this, fd_t *fd, off_t offset,
}
}
-done:
ret = posix_fdstat (this, pfd->fd, statpost);
if (ret == -1) {
ret = -errno;