diff options
| author | Amar Tumballi <amarts@redhat.com> | 2017-10-11 17:33:20 +0530 |
|---|---|---|
| committer | Amar Tumballi <amarts@redhat.com> | 2017-10-12 10:36:26 +0000 |
| commit | a3767c4ceb527cb0f52b95650c841964cf7faec9 (patch) | |
| tree | 518be95c0d473f4d4791bd88978e76510d0cfef1 /xlators/protocol | |
| parent | 9422446d72bc054962d72ace9912ecb885946d49 (diff) | |
protocol-auth: use the proper validation method
Currently, server protocol's init and glusterd's option
validation methods are different, causing an issue. They
should be same for having consistent behavior
Updates #175
Change-Id: Ibbf9a18c7192b2d77f9b7675ae7da9b8d2fe5de4
Signed-off-by: Amar Tumballi <amarts@redhat.com>
Diffstat (limited to 'xlators/protocol')
| -rw-r--r-- | xlators/protocol/server/src/server.c | 40 |
1 files changed, 7 insertions, 33 deletions
diff --git a/xlators/protocol/server/src/server.c b/xlators/protocol/server/src/server.c index 19f261986b6..344046aabec 100644 --- a/xlators/protocol/server/src/server.c +++ b/xlators/protocol/server/src/server.c @@ -394,9 +394,6 @@ _check_for_auth_option (dict_t *d, char *k, data_t *v, int ret = 0; xlator_t *xl = NULL; char *tail = NULL; - char *tmp_addr_list = NULL; - char *addr = NULL; - char *tmp_str = NULL; xl = tmp; @@ -425,38 +422,15 @@ _check_for_auth_option (dict_t *d, char *k, data_t *v, * valid auth.allow.<xlator> * Now we verify the ip address */ - if (!strcmp (v->data, "*")) { - ret = 0; - goto out; - } - - /* TODO-SUBDIR-MOUNT: fix the format */ - tmp_addr_list = gf_strdup (v->data); - addr = strtok_r (tmp_addr_list, ",", &tmp_str); - if (!addr) - addr = v->data; - - while (addr) { - if (valid_internet_address (addr, _gf_true)) { - ret = 0; - } else { - ret = -1; - gf_msg (xl->name, GF_LOG_ERROR, 0, - PS_MSG_INTERNET_ADDR_ERROR, - "internet address '%s'" - " does not conform to" - " standards.", addr); - goto out; - } - if (tmp_str) - addr = strtok_r (NULL, ",", &tmp_str); - else - addr = NULL; - } + ret = xlator_option_validate_addr_list (xl, "auth-*", v->data, + NULL, NULL); + if (ret) + gf_msg (xl->name, GF_LOG_ERROR, 0, + PS_MSG_INTERNET_ADDR_ERROR, + "internet address '%s' does not conform " + "to standards.", v->data); } out: - GF_FREE (tmp_addr_list); - return ret; } |