diff options
author | Raghavendra G <raghavendra@gluster.com> | 2009-10-07 10:09:26 +0000 |
---|---|---|
committer | Anand V. Avati <avati@dev.gluster.com> | 2009-10-07 23:05:44 -0700 |
commit | cc36c4ae0c4aef08b04f3b320a72a6abd2bd276d (patch) | |
tree | 37cabdff1a27ea090ca5288b3907bb3cc4de926a /xlators/performance/stat-prefetch | |
parent | cf4ced9d6329b410dfb864c70365134718524ec7 (diff) |
performance/stat-prefetch: implement sp_getxattr.
- sp_getxattr needs to send a lookup on the path if it is not already looked up.
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 284 (performance actually decreases for 'ls -l' on a directory containing large number of files with stat-prefetch loaded)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=284
Diffstat (limited to 'xlators/performance/stat-prefetch')
-rw-r--r-- | xlators/performance/stat-prefetch/src/stat-prefetch.c | 89 |
1 files changed, 89 insertions, 0 deletions
diff --git a/xlators/performance/stat-prefetch/src/stat-prefetch.c b/xlators/performance/stat-prefetch/src/stat-prefetch.c index 061ed5bd64d..0476ef8f4d5 100644 --- a/xlators/performance/stat-prefetch/src/stat-prefetch.c +++ b/xlators/performance/stat-prefetch/src/stat-prefetch.c @@ -3390,6 +3390,94 @@ out: int32_t +sp_getxattr_cbk (call_frame_t *frame, void *cookie, xlator_t *this, + int32_t op_ret, int32_t op_errno, dict_t *dict) +{ + STACK_UNWIND (frame, op_ret, op_errno, dict); + return 0; +} + + +int32_t +sp_getxattr_helper (call_frame_t *frame, xlator_t *this, loc_t *loc, + const char *name) +{ + uint64_t value = 0; + sp_inode_ctx_t *inode_ctx = NULL; + int32_t ret = 0, op_ret = -1, op_errno = -1; + + ret = inode_ctx_get (loc->inode, this, &value); + if (ret == -1) { + gf_log (this->name, GF_LOG_DEBUG, "context not set in inode " + "(%p)", loc->inode); + op_errno = EINVAL; + goto unwind; + } + + inode_ctx = (sp_inode_ctx_t *)(long) value; + GF_VALIDATE_OR_GOTO_WITH_ERROR (this->name, inode_ctx, unwind, op_errno, + EINVAL); + + LOCK (&inode_ctx->lock); + { + op_ret = inode_ctx->op_ret; + op_errno = inode_ctx->op_errno; + } + UNLOCK (&inode_ctx->lock); + + if (op_ret == -1) { + goto unwind; + } + + STACK_WIND (frame, sp_getxattr_cbk, FIRST_CHILD(this), + FIRST_CHILD(this)->fops->getxattr, loc, name); + + return 0; + +unwind: + SP_STACK_UNWIND (frame, -1, op_errno, NULL); + return 0; +} + + +int32_t +sp_getxattr (call_frame_t *frame, xlator_t *this, loc_t *loc, const char *name) +{ + int32_t op_errno = -1; + call_stub_t *stub = NULL; + char can_wind = 0, need_lookup = 0, need_unwind = 1; + + GF_VALIDATE_OR_GOTO_WITH_ERROR (this->name, loc, out, op_errno, + EINVAL); + GF_VALIDATE_OR_GOTO_WITH_ERROR (this->name, loc->inode, out, + op_errno, EINVAL); + + stub = fop_getxattr_stub (frame, sp_getxattr_helper, loc, name); + if (stub == NULL) { + op_errno = ENOMEM; + gf_log (this->name, GF_LOG_ERROR, "out of memory"); + goto out; + } + + sp_process_inode_ctx (frame, this, loc, stub, &need_unwind, + &need_lookup, &can_wind, &op_errno); + +out: + if (need_unwind) { + SP_STACK_UNWIND (frame, -1, op_errno, NULL); + } else if (need_lookup) { + STACK_WIND (frame, sp_lookup_cbk, FIRST_CHILD(this), + FIRST_CHILD(this)->fops->lookup, loc, NULL); + } else if (can_wind) { + STACK_WIND (frame, sp_getxattr_cbk, FIRST_CHILD(this), + FIRST_CHILD(this)->fops->getxattr, loc, name); + } + + return 0; +} + + +int32_t sp_release (xlator_t *this, fd_t *fd) { sp_fd_ctx_t *fd_ctx = NULL; @@ -3463,6 +3551,7 @@ struct xlator_fops fops = { .fsync = sp_fsync, .rename = sp_rename, .setxattr = sp_setxattr, + .getxattr = sp_getxattr, .removexattr = sp_removexattr, .setdents = sp_setdents, .getdents = sp_getdents, |