summaryrefslogtreecommitdiffstats
path: root/xlators/performance/readdir-ahead/src/readdir-ahead.c
diff options
context:
space:
mode:
authorDavid Spisla <david.spisla@iternity.com>2019-03-06 12:21:18 +0100
committerAmar Tumballi <amarts@redhat.com>2019-03-07 12:04:12 +0000
commitab9b928873024bbc44c941d2ded1b7371f443dd6 (patch)
treeea6be823f00c5be509d7c5f15679151bec5332d5 /xlators/performance/readdir-ahead/src/readdir-ahead.c
parent30c6e354b054879dcdadc726cdf5b9a38630f1bb (diff)
WORM-Xlator: Maybe integer overflow when computing new atime
The structs worm_reten_state_t and read_only_priv_t from read-only.h are using uint64_t values to store periods of retention and autocommmit. This seems to be dangerous since in worm-helper.c the function worm_set_state computes in line 97: stbuf->ia_atime = time(NULL) + retention_state->ret_period; stbuf->ia_atime is using int64_t because of the settings of struct iattr. So if there is a very very high retention period stored, there is maybe an integer overflow. What can be the solution? Using int64_t instead if uint64_t may reduce the probability of the occurance. Change-Id: Id1e86c6b20edd53f171c4cfcb528804ba7881f65 fixes: bz#1685944 Signed-off-by: David Spisla <david.spisla@iternity.com>
Diffstat (limited to 'xlators/performance/readdir-ahead/src/readdir-ahead.c')
0 files changed, 0 insertions, 0 deletions