diff options
| author | Raghavendra G <raghavendra@gluster.com> | 2011-07-15 05:12:52 +0000 |
|---|---|---|
| committer | Anand Avati <avati@gluster.com> | 2011-07-29 01:26:32 -0700 |
| commit | a31fe944e714f75dcd0f6d58d0776c1139548383 (patch) | |
| tree | 0fec0956aa76fba3f4c319e02801f5d3d43f49f7 /xlators/performance/quick-read/src/quick-read.h | |
| parent | 412a951dc6b575e89e497a8588426257018e284e (diff) | |
performance/quick-read: propagate errors during open back to actual fops.
- If open fails and there are any other fops waiting on that open, those fops
should also unwind with appropriate errors. Before this patch, irrespective
of success/failure of open, fops waiting on it were stack_wound and since
fd was invalid, they would fail with EBADFD errors. Due to this
actual error would've got masked by EBADFD.
Change-Id: I65f88a681ea573a964fae132073696d32701882f
BUG: 2346
Reviewed-on: http://review.gluster.com/49
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@gluster.com>
Diffstat (limited to 'xlators/performance/quick-read/src/quick-read.h')
| -rw-r--r-- | xlators/performance/quick-read/src/quick-read.h | 12 |
1 files changed, 6 insertions, 6 deletions
diff --git a/xlators/performance/quick-read/src/quick-read.h b/xlators/performance/quick-read/src/quick-read.h index 0b2a5ae30e5..3b5c900943b 100644 --- a/xlators/performance/quick-read/src/quick-read.h +++ b/xlators/performance/quick-read/src/quick-read.h @@ -108,11 +108,11 @@ typedef struct qr_private qr_private_t; void qr_local_free (qr_local_t *local); -#define QR_STACK_UNWIND(op, frame, params ...) do { \ - qr_local_t *__local = frame->local; \ - frame->local = NULL; \ - STACK_UNWIND_STRICT (op, frame, params); \ - qr_local_free (__local); \ -} while (0) +#define QR_STACK_UNWIND(op, frame, params ...) do { \ + qr_local_t *__local = frame->local; \ + frame->local = NULL; \ + STACK_UNWIND_STRICT (op, frame, params); \ + qr_local_free (__local); \ + } while (0) #endif /* #ifndef __QUICK_READ_H */ |