diff options
| author | Pranith Kumar K <pkarampu@redhat.com> | 2016-03-19 11:40:26 +0530 |
|---|---|---|
| committer | Niels de Vos <ndevos@redhat.com> | 2016-05-14 07:30:21 -0700 |
| commit | be312da5eac94410c41dac5dc1dde810974a12b7 (patch) | |
| tree | 497b8b9f3bd55c4a91f80a6b1e74daf479906a59 /xlators/nfs/server/src/nfs3-helpers.c | |
| parent | bf80f5a94b7d5e617612904723c2ae053e137d3b (diff) | |
cluster/afr: Don't let NFS cache stat after writes
Problem:
Afr does post-ops after write but the stat buffer it unwinds is at the
time of write, so if nfs client caches this, it will see different
ctime when it does stat on it after post-op is done. From NFS client's
perspective it thinks the file is changed. Tar which depends on this
to be correct keeps giving 'file changed as we read it' warning.
If Afr instead has to choose to unwind after post-op, eager-lock,
delayed-post-op will have to be disabled which will lead to bad
performance for all write usecases.
Fix:
Don't let client cache stat after write.
>Change-Id: Ic6062acc6e5cdd97a9c83c56bd529ec83cee8a23
>BUG: 1302948
>Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
>Signed-off-by: Anuradha Talur <atalur@redhat.com>
>Reviewed-on: http://review.gluster.org/13785
>Smoke: Gluster Build System <jenkins@build.gluster.com>
>NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
>CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
>Reviewed-by: Niels de Vos <ndevos@redhat.com>
BUG: 1335285
Change-Id: Ibef4fc80496d12acd15db57713af2e3a1c9109a7
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
Reviewed-on: http://review.gluster.org/14300
Smoke: Gluster Build System <jenkins@build.gluster.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Ravishankar N <ravishankar@redhat.com>
Reviewed-by: Niels de Vos <ndevos@redhat.com>
Diffstat (limited to 'xlators/nfs/server/src/nfs3-helpers.c')
| -rw-r--r-- | xlators/nfs/server/src/nfs3-helpers.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/xlators/nfs/server/src/nfs3-helpers.c b/xlators/nfs/server/src/nfs3-helpers.c index 7eb491142f7..ad4c87e69d7 100644 --- a/xlators/nfs/server/src/nfs3-helpers.c +++ b/xlators/nfs/server/src/nfs3-helpers.c @@ -373,7 +373,7 @@ nfs3_stat_to_post_op_attr (struct iatt *buf) * returning these zeroed out attrs. */ attr.attributes_follow = FALSE; - if (nfs_zero_filled_stat (buf)) + if (gf_is_zero_filled_stat (buf)) goto out; nfs3_stat_to_fattr3 (buf, &(attr.post_op_attr_u.attributes)); @@ -394,7 +394,7 @@ nfs3_stat_to_pre_op_attr (struct iatt *pre) * returning these zeroed out attrs. */ poa.attributes_follow = FALSE; - if (nfs_zero_filled_stat (pre)) + if (gf_is_zero_filled_stat (pre)) goto out; poa.attributes_follow = TRUE; |