clean up handling of special client pids

- no need to name a lower boundary [drop GF_CLIENT_PID_MIN]
- drop utility function to decide about pid speciality [gf_pid_client_check()];
  when we implement uniform policy for special pids, use just comparison with
  GF_CLIENT_PID_MAX (currently such uniform policy exists in io-threads, where
  special clients get lowest priority)
- io-threads: drop numeric literal, use GF_CLIENT_PID_MAX
- xattr flipping (in fuse):
  - fuse_xattr_alloc_default() made static
  - avoid compiler warnings wrt. partial enum traversal in the switch
    by not casting the original numeric value to gf_client_pid_t (enum) type
  - trim down the switch to those cases with which there is something to do
    [GF_CLIENT_PID_GSYNCD, GF_CLIENT_PID_HADOOP]
  - eliminate the (theoretical) chance of succesfully returning
    from fuse_flip_xattr_ns() with unallocated nkey
    [as was the case with pids GF_CLIENT_PID_{MIN,MAX,DEFRAG}]

Change-Id: Ic2b83b908d8e3be23a7fba1e5895869828a6194b
BUG: 765433
Signed-off-by: Csaba Henk <csaba@redhat.com>
Reviewed-on: http://review.gluster.com/3170
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
Reviewed-by: Anand Avati <avati@redhat.com>

1 files changed, 0 insertions, 1 deletions

diff --git a/xlators/mount/fuse/src/fuse-bridge.h b/xlators/mount/fuse/src/fuse-bridge.h
index d20413055d8..3711ca54da0 100644
--- a/xlators/mount/fuse/src/fuse-bridge.h
+++ b/xlators/mount/fuse/src/fuse-bridge.h
@@ -350,7 +350,6 @@ inode_t *fuse_ino_to_inode (uint64_t ino, xlator_t *fuse);
 int send_fuse_err (xlator_t *this, fuse_in_header_t *finh, int error);
 int fuse_gfid_set (fuse_state_t *state);
 int fuse_flip_xattr_ns (struct fuse_private *priv, char *okey, char **nkey);
-int fuse_xattr_alloc_default (char *okey, char **nkey);
 fuse_fd_ctx_t * __fuse_fd_ctx_check_n_create (fd_t *fd, xlator_t *this);
 fuse_fd_ctx_t * fuse_fd_ctx_check_n_create (fd_t *fd, xlator_t *this);