diff options
author | Jeff Darcy <jdarcy@redhat.com> | 2017-03-20 12:32:33 -0400 |
---|---|---|
committer | Raghavendra Talur <rtalur@redhat.com> | 2017-04-24 15:49:00 +0000 |
commit | e6045103b7e010779549bb486c00a07b3c3eb0fc (patch) | |
tree | 74a7d99741869208f9a2d54d18b8e3d9b8665959 /xlators/mgmt/glusterd/src/glusterd-volume-ops.c | |
parent | e37d546042a73bec85fe2ebd0146b88b7079bc66 (diff) |
glusterd: hold off volume deletes while still restarting bricks
We need to do this because modifying the volume/brick tree while
glusterd_restart_bricks is still walking it can lead to segfaults.
Without waiting we could accidentally "slip in" while attach_brick has
released big_lock between retries and make such a modification.
Backport of:
> Commit a7ce0548b7969050644891cd90c0bf134fa1594c
> BUG: 1432542
> Reviewed-on: https://review.gluster.org/16927
Change-Id: I30ccc4efa8d286aae847250f5d4fb28956a74b03
BUG: 1441476
Signed-off-by: Jeff Darcy <jeff@pl.atyp.us>
Reviewed-on: https://review.gluster.org/17044
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Smoke: Gluster Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Atin Mukherjee <amukherj@redhat.com>
Diffstat (limited to 'xlators/mgmt/glusterd/src/glusterd-volume-ops.c')
-rw-r--r-- | xlators/mgmt/glusterd/src/glusterd-volume-ops.c | 3 |
1 files changed, 0 insertions, 3 deletions
diff --git a/xlators/mgmt/glusterd/src/glusterd-volume-ops.c b/xlators/mgmt/glusterd/src/glusterd-volume-ops.c index 96b9aaf93d5..778579b4440 100644 --- a/xlators/mgmt/glusterd/src/glusterd-volume-ops.c +++ b/xlators/mgmt/glusterd/src/glusterd-volume-ops.c @@ -2795,14 +2795,11 @@ glusterd_op_delete_volume (dict_t *dict) { int ret = 0; char *volname = NULL; - glusterd_conf_t *priv = NULL; glusterd_volinfo_t *volinfo = NULL; xlator_t *this = NULL; this = THIS; GF_ASSERT (this); - priv = this->private; - GF_ASSERT (priv); ret = dict_get_str (dict, "volname", &volname); if (ret) { |