diff options
| author | Atin Mukherjee <amukherj@redhat.com> | 2017-03-30 14:47:45 +0530 |
|---|---|---|
| committer | Jeff Darcy <jeff@pl.atyp.us> | 2017-03-31 09:06:22 -0400 |
| commit | e325479cf222d2f25dbc0a4c6b80bfe5a7f09f43 (patch) | |
| tree | 2e8078f8e08bdb7bb02908e5491ab06ea4ef5cee /xlators/mgmt/glusterd/src/glusterd-utils.c | |
| parent | a7ce0548b7969050644891cd90c0bf134fa1594c (diff) | |
glusterd: reset pid to -1 if brick is not online
While populating brick details in gluster volume status response payload
if a brick is not online then pid should be reset back to -1 so that
volume status output doesn't show up the pid which was not cleaned up
especially with brick multiplexing where multiple bricks belong to same
process.
Change-Id: Iba346da9a8cb5b5f5dd38031d4c5ef2097808387
BUG: 1437494
Signed-off-by: Atin Mukherjee <amukherj@redhat.com>
Reviewed-on: https://review.gluster.org/16971
Smoke: Gluster Build System <jenkins@build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Gaurav Yadav <gyadav@redhat.com>
Reviewed-by: Prashanth Pai <ppai@redhat.com>
Reviewed-by: Jeff Darcy <jeff@pl.atyp.us>
Diffstat (limited to 'xlators/mgmt/glusterd/src/glusterd-utils.c')
| -rw-r--r-- | xlators/mgmt/glusterd/src/glusterd-utils.c | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/xlators/mgmt/glusterd/src/glusterd-utils.c b/xlators/mgmt/glusterd/src/glusterd-utils.c index a0df27c8bae..fbec4fcafb8 100644 --- a/xlators/mgmt/glusterd/src/glusterd-utils.c +++ b/xlators/mgmt/glusterd/src/glusterd-utils.c @@ -6358,6 +6358,8 @@ glusterd_add_brick_to_dict (glusterd_volinfo_t *volinfo, if (glusterd_is_brick_started (brickinfo)) { if (gf_is_service_running (pidfile, &pid)) { brick_online = _gf_true; + } else { + pid = -1; } } |