summaryrefslogtreecommitdiffstats
path: root/xlators/features/read-only
diff options
context:
space:
mode:
authorkarthik-us <ksubrahm@redhat.com>2016-06-03 01:04:01 +0530
committerJeff Darcy <jdarcy@redhat.com>2016-06-13 05:12:47 -0700
commit40a7537556a7eb0a7c90ec6e7e2fd4014beae092 (patch)
treef4dab80d109cb55cfa79acd6e02b27277cdf2223 /xlators/features/read-only
parent1a348bfaeb9f2a50ec8ce27e5477e9b430c58b3c (diff)
features/worm: fixed issue with write FOP for normal files
The write FOPs on normal files were being blocked after the recent change. It should fail only for the WORM and WORM-Retained files, and should pass for a normal file. Using auto-commit period to check for dormant files instead of retention period. Change-Id: I30f82d4de2ea2c59c1eb7b4449ba6a60e568cfd5 BUG: 1342259 Signed-off-by: karthik-us <ksubrahm@redhat.com> Reviewed-on: http://review.gluster.org/14619 Smoke: Gluster Build System <jenkins@build.gluster.com> CentOS-regression: Gluster Build System <jenkins@build.gluster.com> NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org> Reviewed-by: Joseph Fernandes Reviewed-by: Manikandan Selvaganesh <mselvaga@redhat.com>
Diffstat (limited to 'xlators/features/read-only')
-rw-r--r--xlators/features/read-only/src/worm-helper.c4
-rw-r--r--xlators/features/read-only/src/worm.c5
2 files changed, 5 insertions, 4 deletions
diff --git a/xlators/features/read-only/src/worm-helper.c b/xlators/features/read-only/src/worm-helper.c
index 692899d9379..81a167e3c63 100644
--- a/xlators/features/read-only/src/worm-helper.c
+++ b/xlators/features/read-only/src/worm-helper.c
@@ -305,7 +305,6 @@ gf_worm_state_transition (xlator_t *this, gf_boolean_t fop_with_fd,
int op_errno = EROFS;
int ret = -1;
uint64_t com_period = 0;
- uint64_t ret_period = 0;
uint64_t start_time = 0;
dict_t *dict = NULL;
worm_reten_state_t reten_state = {0,};
@@ -356,8 +355,7 @@ gf_worm_state_transition (xlator_t *this, gf_boolean_t fop_with_fd,
}
if (ret == -1 && (time (NULL) - start_time) >= com_period) {
- ret_period = priv->reten_period;
- if ((time (NULL) - stbuf.ia_mtime) >= ret_period) {
+ if ((time (NULL) - stbuf.ia_mtime) >= com_period) {
ret = worm_set_state(this, fop_with_fd, file_ptr,
&reten_state, &stbuf);
if (ret) {
diff --git a/xlators/features/read-only/src/worm.c b/xlators/features/read-only/src/worm.c
index ad06f46a4e4..3e32d65dbac 100644
--- a/xlators/features/read-only/src/worm.c
+++ b/xlators/features/read-only/src/worm.c
@@ -370,8 +370,11 @@ worm_writev (call_frame_t *frame, xlator_t *this, fd_t *fd,
goto out;
}
ret = worm_get_state (this, _gf_true, fd, &reten_state);
- if (ret)
+ if (ret) {
+ if (ret == -1)
+ op_errno = 0;
goto out;
+ }
if (!reten_state.worm)
op_errno = 0;