diff options
| author | Amar Tumballi <amarts@redhat.com> | 2018-11-06 22:47:41 +0530 |
|---|---|---|
| committer | Shyamsundar Ranganathan <srangana@redhat.com> | 2018-11-09 14:03:02 +0000 |
| commit | 83304fedb464fe3f97db662ce3e07bd948b7b7d9 (patch) | |
| tree | e9bc09af05900b562a99bff6ff964ed19a9bf685 /xlators/debug | |
| parent | 7136414bcc0426270f1df8720018af1b53fd228a (diff) | |
all: fix the format string exceptions
Currently, there are possibilities in few places, where a user-controlled
(like filename, program parameter etc) string can be passed as 'fmt' for
printf(), which can lead to segfault, if the user's string contains '%s',
'%d' in it.
While fixing it, makes sense to make the explicit check for such issues
across the codebase, by making the format call properly.
Fixes: CVE-2018-14661
Fixes: bz#1647666
Change-Id: Ib547293f2d9eb618594cbff0df3b9c800e88bde4
Signed-off-by: Amar Tumballi <amarts@redhat.com>
Diffstat (limited to 'xlators/debug')
| -rw-r--r-- | xlators/debug/trace/src/trace.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/xlators/debug/trace/src/trace.c b/xlators/debug/trace/src/trace.c index 86fa9d4611d..a02288ceb41 100644 --- a/xlators/debug/trace/src/trace.c +++ b/xlators/debug/trace/src/trace.c @@ -77,7 +77,7 @@ dump_history_trace(circular_buffer_t *cb, void *data) ".%" GF_PRI_SUSECONDS, cb->tv.tv_usec); gf_proc_dump_write("TIME", "%s", timestr); - gf_proc_dump_write("FOP", "%s\n", cb->data); + gf_proc_dump_write("FOP", "%s\n", (char *)cb->data); return 0; } @@ -3218,7 +3218,7 @@ trace_dump_history(xlator_t *this) // Is it ok to return silently if log-history option his off? if (conf && conf->log_history == _gf_true) { gf_proc_dump_build_key(key_prefix, "xlator.debug.trace", "history"); - gf_proc_dump_add_section(key_prefix); + gf_proc_dump_add_section("%s", key_prefix); eh_dump(this->history, NULL, dump_history_trace); } ret = 0; |