summaryrefslogtreecommitdiffstats
path: root/xlators/cluster
diff options
context:
space:
mode:
authorRavishankar N <ravishankar@redhat.com>2015-01-23 11:12:54 +0530
committerRaghavendra Bhat <raghavendra@redhat.com>2015-02-03 05:24:56 -0800
commitf397d7edb85c1e4b78c4cac176dc8a0afe8cf9a8 (patch)
tree964e187c2c8ff5e073306dd5b90f751348eafd10 /xlators/cluster
parent90f35bc8e806fc615d5e2a2657a389dbdd7e2672 (diff)
afr: Don't write to sparse regions of sink.
Backport of http://review.gluster.org/9480 Problem: When data-self-heal-algorithm is set to 'full', shd just reads from source and writes to sink. If source file happened to be sparse (VM workloads), we end up actually writing 0s to the corresponding regions of the sink causing it to lose its sparseness. Fix: If the source file is sparse, and the data read from source and sink are both zeros for that range, skip writing that range to the sink. Change-Id: Id23d953fe2c8c64cde5ce3530b52ef91a7583891 BUG: 1187547 Signed-off-by: Ravishankar N <ravishankar@redhat.com> Reviewed-on: http://review.gluster.org/9515 Tested-by: Gluster Build System <jenkins@build.gluster.com> Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com> Reviewed-by: Raghavendra Bhat <raghavendra@redhat.com>
Diffstat (limited to 'xlators/cluster')
-rw-r--r--xlators/cluster/afr/src/afr-self-heal-data.c41
1 files changed, 39 insertions, 2 deletions
diff --git a/xlators/cluster/afr/src/afr-self-heal-data.c b/xlators/cluster/afr/src/afr-self-heal-data.c
index a434b9e6ba1..5637de365e0 100644
--- a/xlators/cluster/afr/src/afr-self-heal-data.c
+++ b/xlators/cluster/afr/src/afr-self-heal-data.c
@@ -111,11 +111,38 @@ __afr_selfheal_data_checksums_match (call_frame_t *frame, xlator_t *this,
}
+static gf_boolean_t
+__afr_is_sink_zero_filled (xlator_t *this, fd_t *fd, size_t size,
+ off_t offset, int sink)
+{
+ afr_private_t *priv = NULL;
+ struct iobref *iobref = NULL;
+ struct iovec *iovec = NULL;
+ int count = 0;
+ int ret = 0;
+ gf_boolean_t zero_filled = _gf_false;
+
+ priv = this->private;
+ ret = syncop_readv (priv->children[sink], fd, size, offset, 0, &iovec,
+ &count, &iobref);
+ if (ret < 0)
+ goto out;
+ ret = iov_0filled (iovec, count);
+ if (!ret)
+ zero_filled = _gf_true;
+out:
+ if (iovec)
+ GF_FREE (iovec);
+ if (iobref)
+ iobref_unref (iobref);
+ return zero_filled;
+}
+
static int
__afr_selfheal_data_read_write (call_frame_t *frame, xlator_t *this, fd_t *fd,
int source, unsigned char *healed_sinks,
off_t offset, size_t size,
- struct afr_reply *replies)
+ struct afr_reply *replies, int type)
{
struct iovec *iovec = NULL;
int count = 0;
@@ -165,6 +192,16 @@ __afr_selfheal_data_read_write (call_frame_t *frame, xlator_t *this, fd_t *fd,
(iov_0filled (iovec, count) == 0))
continue;
+ /* Avoid filling up sparse regions of the sink with 0-filled
+ * writes.*/
+ if (type == AFR_SELFHEAL_DATA_FULL &&
+ HAS_HOLES ((&replies[source].poststat)) &&
+ ((offset + size) <= replies[i].poststat.ia_size) &&
+ (iov_0filled (iovec, count) == 0) &&
+ __afr_is_sink_zero_filled (this, fd, size, offset, i)) {
+ continue;
+ }
+
ret = syncop_writev (priv->children[i], fd, iovec, count,
offset, iobref, 0);
if (ret != iov_length (iovec, count)) {
@@ -216,7 +253,7 @@ afr_selfheal_data_block (call_frame_t *frame, xlator_t *this, fd_t *fd,
ret = __afr_selfheal_data_read_write (frame, this, fd, source,
healed_sinks, offset, size,
- replies);
+ replies, type);
}
unlock:
afr_selfheal_uninodelk (frame, this, fd->inode, this->name,