diff options
author | Ashish Pandey <aspandey@redhat.com> | 2016-06-06 10:17:54 +0530 |
---|---|---|
committer | Niels de Vos <ndevos@redhat.com> | 2016-06-13 03:12:12 -0700 |
commit | c8d78fa265b8b938bbaee5bc8a59b60a58ae0440 (patch) | |
tree | 5f06b96dc9b0d49029d3e1d01b8d28020dab8a80 /xlators/cluster | |
parent | dca103a2830746e08bea6b576465956f6568b521 (diff) |
cluster/ec: Restrict the launch of replace brick heal
Problem: When features.cache-invalidation is ON, a lot of
ec_notify function gets called which leads to launch of
too many heals. This leads to no heal completion,
which causes accumulation of heals.
Solution: ec_launch_replace_heal should not be launch
for every event. Replace brick will trigger a child up
event and then only this heal function should be called.
master -
http://review.gluster.org/#/c/14649/
Change-Id: I57b44c6a279d57230daea1d93229be6069245b7d
BUG: 1342954
Signed-off-by: Ashish Pandey <aspandey@redhat.com>
Reviewed-on: http://review.gluster.org/14651
Reviewed-by: Xavier Hernandez <xhernandez@datalab.es>
Smoke: Gluster Build System <jenkins@build.gluster.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Diffstat (limited to 'xlators/cluster')
-rw-r--r-- | xlators/cluster/ec/src/ec.c | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/xlators/cluster/ec/src/ec.c b/xlators/cluster/ec/src/ec.c index 1d53981303a..94d1241b364 100644 --- a/xlators/cluster/ec/src/ec.c +++ b/xlators/cluster/ec/src/ec.c @@ -519,7 +519,8 @@ unlock: } if (ec->shd.iamshd && - ec->xl_notify_count == ec->nodes) { + ec->xl_notify_count == ec->nodes && + event == GF_EVENT_CHILD_UP) { ec_launch_replace_heal (ec); } out: |