diff options
| author | Ashish Pandey <aspandey@redhat.com> | 2016-06-06 10:17:54 +0530 |
|---|---|---|
| committer | Pranith Kumar Karampuri <pkarampu@redhat.com> | 2016-06-09 02:04:07 -0700 |
| commit | 37ac79fe54e91a8ffe23318855f2cda582a27798 (patch) | |
| tree | 4bcaba1e6956dfe64c0afb1903c07c994a0c3a1f /xlators/cluster | |
| parent | 3a82ea38fd5b150796e1f436097ad45a629835e7 (diff) | |
cluster/ec: Restrict the launch of replace brick heal
Problem: When features.cache-invalidation is ON, a lot of
ec_notify function gets called which leads to launch of
too many heals. This leads to no heal completion,
which causes accumulation of heals.
Solution: ec_launch_replace_heal should not be launch
for every event. Replace brick will trigger a child up
event and then only this heal function should be called.
master -
http://review.gluster.org/#/c/14649/
Change-Id: I57b44c6a279d57230daea1d93229be6069245b7d
BUG: 1342964
Signed-off-by: Ashish Pandey <aspandey@redhat.com>
Reviewed-on: http://review.gluster.org/14652
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
Smoke: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Xavier Hernandez <xhernandez@datalab.es>
Diffstat (limited to 'xlators/cluster')
| -rw-r--r-- | xlators/cluster/ec/src/ec.c | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/xlators/cluster/ec/src/ec.c b/xlators/cluster/ec/src/ec.c index 3133962cb4f..4c9740c675d 100644 --- a/xlators/cluster/ec/src/ec.c +++ b/xlators/cluster/ec/src/ec.c @@ -517,7 +517,8 @@ unlock: } if (ec->shd.iamshd && - ec->xl_notify_count == ec->nodes) { + ec->xl_notify_count == ec->nodes && + event == GF_EVENT_CHILD_UP) { ec_launch_replace_heal (ec); } out: |