diff options
| author | Amar Tumballi <amarts@redhat.com> | 2018-11-06 22:47:41 +0530 |
|---|---|---|
| committer | Shyamsundar Ranganathan <srangana@redhat.com> | 2018-11-09 14:03:02 +0000 |
| commit | 83304fedb464fe3f97db662ce3e07bd948b7b7d9 (patch) | |
| tree | e9bc09af05900b562a99bff6ff964ed19a9bf685 /xlators/cluster/stripe/src/stripe.c | |
| parent | 7136414bcc0426270f1df8720018af1b53fd228a (diff) | |
all: fix the format string exceptions
Currently, there are possibilities in few places, where a user-controlled
(like filename, program parameter etc) string can be passed as 'fmt' for
printf(), which can lead to segfault, if the user's string contains '%s',
'%d' in it.
While fixing it, makes sense to make the explicit check for such issues
across the codebase, by making the format call properly.
Fixes: CVE-2018-14661
Fixes: bz#1647666
Change-Id: Ib547293f2d9eb618594cbff0df3b9c800e88bde4
Signed-off-by: Amar Tumballi <amarts@redhat.com>
Diffstat (limited to 'xlators/cluster/stripe/src/stripe.c')
| -rw-r--r-- | xlators/cluster/stripe/src/stripe.c | 5 |
1 files changed, 3 insertions, 2 deletions
diff --git a/xlators/cluster/stripe/src/stripe.c b/xlators/cluster/stripe/src/stripe.c index a6027d1f281..6c8568b5608 100644 --- a/xlators/cluster/stripe/src/stripe.c +++ b/xlators/cluster/stripe/src/stripe.c @@ -5514,12 +5514,13 @@ stripe_priv_dump(xlator_t *this) options = priv->pattern; while (options != NULL) { gf_proc_dump_write("path_pattern", "%s", priv->pattern->path_pattern); - gf_proc_dump_write("options_block_size", "%ul", options->block_size); + gf_proc_dump_write("options_block_size", "%" PRIu64, + options->block_size); options = options->next; } - gf_proc_dump_write("block_size", "%ul", priv->block_size); + gf_proc_dump_write("block_size", "%" PRIu64, priv->block_size); gf_proc_dump_write("nodes-down", "%d", priv->nodes_down); gf_proc_dump_write("first-child_down", "%d", priv->first_child_down); gf_proc_dump_write("xattr_supported", "%d", priv->xattr_supported); |