diff options
author | Xavier Hernandez <xhernandez@datalab.es> | 2014-12-03 16:42:31 +0100 |
---|---|---|
committer | Raghavendra Bhat <raghavendra@redhat.com> | 2015-01-04 22:58:30 -0800 |
commit | 8bfe216b8297129833d3af5a66984b9b9bf0046c (patch) | |
tree | dab61920cc7fe3b92a837c72240d47eb249158b2 /xlators/cluster/ec/src/ec-combine.c | |
parent | 0111ab923dd4c8f0985dd566c172cda31492b0f7 (diff) |
ec: Fix mutex related coverity scan issues
This patch solves 3 issues detected by coverity scan:
CID1241484 Data race condition
CID1241486 Data race condition
CID1256173 Thread deadlock
CID1257622 Thread deadlock
With this patch, inode lock is never acquired inside a region locked
with fop->lock.
This is a backport of http://review.gluster.org/9230/ and
http://review.gluster.org/9263/
Change-Id: I35c4633efd1b68b9f72b42661fa7c728b1f52c6a
BUG: 1170954
Signed-off-by: Xavier Hernandez <xhernandez@datalab.es>
Reviewed-on: http://review.gluster.org/9244
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Dan Lambright <dlambrig@redhat.com>
Reviewed-by: Raghavendra Bhat <raghavendra@redhat.com>
Diffstat (limited to 'xlators/cluster/ec/src/ec-combine.c')
-rw-r--r-- | xlators/cluster/ec/src/ec-combine.c | 14 |
1 files changed, 5 insertions, 9 deletions
diff --git a/xlators/cluster/ec/src/ec-combine.c b/xlators/cluster/ec/src/ec-combine.c index a98380adfb8..e605f7ba567 100644 --- a/xlators/cluster/ec/src/ec-combine.c +++ b/xlators/cluster/ec/src/ec-combine.c @@ -851,12 +851,9 @@ void ec_combine(ec_cbk_data_t * cbk, ec_combine_f combine) ec_trace("ANSWER", fop, "combine=%s[%d]", ec_bin(str, sizeof(str), cbk->mask, 0), cbk->count); - if ((cbk->count == fop->expected) && (fop->answer == NULL)) - { + if ((cbk->count == fop->expected) && (fop->answer == NULL)) { fop->answer = cbk; - ec_update_bad(fop, cbk->mask); - resume = 1; } @@ -865,12 +862,11 @@ void ec_combine(ec_cbk_data_t * cbk, ec_combine_f combine) UNLOCK(&fop->lock); - if (needed > 0) - { + if (needed > 0) { ec_dispatch_next(fop, cbk->idx); - } - else if (resume) - { + } else if (resume) { + ec_update_bad(fop, cbk->mask); + ec_resume(fop, 0); } } |