summaryrefslogtreecommitdiffstats
path: root/xlators/cluster/afr/src
diff options
context:
space:
mode:
authorHarshavardhana <harsha@harshavardhana.net>2014-05-21 13:30:02 -0700
committerVenky Shankar <vshankar@redhat.com>2014-05-27 23:23:09 -0700
commit38b2531d91e51dc73ba99ebcd3b98db75affa7d7 (patch)
tree754833cf8a1478b576a0bc6953871a1f14fcffb6 /xlators/cluster/afr/src
parent048902f108ad3c437e83248c14de33e6519d9f07 (diff)
features/changelog: NULL termination after memcpy should be of dest pointer
snippet code < ..memcpy (bufff, src, len - 1); ..*(src + len) = '\0'; ---> Wrong! > Source buffer lvalue() referencing with offset style NULL termination is wrong and unnecessary when we have a destination buffer, it is the destination buffer which should look to be NULL terminated Makes it more readable and also clearly logical. < ..memcpy (bufff, src, len - 1); ..bufff[len -1] = '\0'; ---> Correct! > Change-Id: I6d7f312aaa5c541f0345649ff1ef9f193892b674 BUG: 1099986 Signed-off-by: Harshavardhana <harsha@harshavardhana.net> Reviewed-on: http://review.gluster.org/7836 Reviewed-by: Raghavendra Bhat <raghavendra@redhat.com> Reviewed-by: Venky Shankar <vshankar@redhat.com> Tested-by: Venky Shankar <vshankar@redhat.com>
Diffstat (limited to 'xlators/cluster/afr/src')
0 files changed, 0 insertions, 0 deletions