summaryrefslogtreecommitdiffstats
path: root/xlators/cluster/afr/src/afr-self-heal-common.c
diff options
context:
space:
mode:
authorPranith Kumar K <pkarampu@redhat.com>2016-03-28 16:31:12 +0530
committerPranith Kumar Karampuri <pkarampu@redhat.com>2016-03-31 05:46:32 -0700
commitb2a5eed9b17a82ec4b6366b0107fe2271328c16a (patch)
tree044ae61060c37e7a1885b033b8999dbd5be8a6a6 /xlators/cluster/afr/src/afr-self-heal-common.c
parent16a3f0d020d23978b22a07354c25c654c88163a2 (diff)
cluster/afr: Don't lookup/forget inodes
Problem: All inodes that are looked-up are always forgotten without fail in afr removing the benefits of them being in lru. This same code can cause crashes if between inode_lookup, inode_forget in afr if the top xlator does inode_forget(0). Fix: Don't use lookup/forget in afr. No benefits are there at the moment for keeping this code. It is impossible to prevent top xlators to do inode_forget(0). Found similar instances in ec and removed them even though those code paths are not going to be executed in any place other than heal-daemon. BUG: 1321554 Change-Id: Ia4cb236178f7f129cc898d53f0bbd26f494a2a8d Signed-off-by: Pranith Kumar K <pkarampu@redhat.com> Reviewed-on: http://review.gluster.org/13834 Smoke: Gluster Build System <jenkins@build.gluster.com> NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org> CentOS-regression: Gluster Build System <jenkins@build.gluster.com> Reviewed-by: Anuradha Talur <atalur@redhat.com>
Diffstat (limited to 'xlators/cluster/afr/src/afr-self-heal-common.c')
-rw-r--r--xlators/cluster/afr/src/afr-self-heal-common.c20
1 files changed, 2 insertions, 18 deletions
diff --git a/xlators/cluster/afr/src/afr-self-heal-common.c b/xlators/cluster/afr/src/afr-self-heal-common.c
index 151960d2516..3f4e9703546 100644
--- a/xlators/cluster/afr/src/afr-self-heal-common.c
+++ b/xlators/cluster/afr/src/afr-self-heal-common.c
@@ -1153,20 +1153,6 @@ afr_is_entry_set (xlator_t *this, dict_t *xdata)
return afr_is_pending_set (this, xdata, AFR_ENTRY_TRANSACTION);
}
-
-inode_t*
-afr_inode_link (inode_t *inode, struct iatt *iatt)
-{
- inode_t *linked_inode = NULL;
-
- linked_inode = inode_link (inode, NULL, NULL, iatt);
-
- if (linked_inode)
- inode_lookup (linked_inode);
- return linked_inode;
-}
-
-
/*
* This function inspects the looked up replies (in an unlocked manner)
* and decides whether a locked verification and possible healing is
@@ -1293,7 +1279,7 @@ afr_selfheal_unlocked_inspect (call_frame_t *frame, xlator_t *this,
}
if (valid_cnt > 0 && link_inode) {
- *link_inode = afr_inode_link (inode, &first);
+ *link_inode = inode_link (inode, NULL, NULL, &first);
if (!*link_inode) {
ret = -EINVAL;
goto out;
@@ -1454,10 +1440,8 @@ afr_selfheal_do (call_frame_t *frame, xlator_t *this, uuid_t gfid)
ret = 0;
out:
- if (inode) {
- inode_forget (inode, 1);
+ if (inode)
inode_unref (inode);
- }
return ret;
}
/*