summaryrefslogtreecommitdiffstats
path: root/xlators/cluster/afr/src/afr-self-heal-common.c
diff options
context:
space:
mode:
authorPranith Kumar K <pkarampu@redhat.com>2014-01-09 16:55:11 +0530
committerVijay Bellur <vbellur@redhat.com>2014-04-28 09:44:58 -0700
commit800258b54a4a776430410eb949cfded147c4ae8a (patch)
tree81bd10a6e873868822e4271c43ddfe90f19c6132 /xlators/cluster/afr/src/afr-self-heal-common.c
parent26843b00447cc14427b4f02ca136033b56ca093f (diff)
cluster/afr: Prevent heal info hang when data-self-heal in progress.
Problem: For determining whether data-self-heal is needed afr takes blocking locks. So if self-heal is indeed in progress on the file, this leads to hangs. heal info hung for almost 50 minutes when a 50G file is undergoing heal. Fix: When self-heal is in progress there is a live self-heal-domain lock. In this stage if a non-blocking inodelk for self-heal-domain lock is performed it will fail with EAGAIN. For heal info we can use this logic to determing that the file is possibly undergoing heal and inform it to user instead of waiting for the completion of self-heal. Change-Id: I18527c59e429602bae49c98ff45502833ab8e1f0 BUG: 1039544 Signed-off-by: Pranith Kumar K <pkarampu@redhat.com> Reviewed-on: http://review.gluster.org/7482 Tested-by: Gluster Build System <jenkins@build.gluster.com> Reviewed-by: Ravishankar N <ravishankar@redhat.com> Reviewed-by: Vijay Bellur <vbellur@redhat.com>
Diffstat (limited to 'xlators/cluster/afr/src/afr-self-heal-common.c')
-rw-r--r--xlators/cluster/afr/src/afr-self-heal-common.c1
1 files changed, 1 insertions, 0 deletions
diff --git a/xlators/cluster/afr/src/afr-self-heal-common.c b/xlators/cluster/afr/src/afr-self-heal-common.c
index 4916bf4..8861870 100644
--- a/xlators/cluster/afr/src/afr-self-heal-common.c
+++ b/xlators/cluster/afr/src/afr-self-heal-common.c
@@ -2360,6 +2360,7 @@ afr_self_heal_completion_cbk (call_frame_t *bgsh_frame, xlator_t *this)
orig_frame_sh->entry_sh_pending = sh->entry_sh_pending;
orig_frame_sh->data_sh_pending = sh->data_sh_pending;
orig_frame_sh->metadata_sh_pending = sh->metadata_sh_pending;
+ orig_frame_sh->possibly_healing = sh->possibly_healing;
sh->unwind (sh->orig_frame, this, sh->op_ret, sh->op_errno,
is_self_heal_failed (sh, AFR_CHECK_ALL));
}