diff options
| author | Ravishankar N <ravishankar@redhat.com> | 2015-03-11 16:41:06 +0530 |
|---|---|---|
| committer | Niels de Vos <ndevos@redhat.com> | 2015-03-11 21:14:38 -0700 |
| commit | 147b3871180a699a642767d0cc0ea00fa69a33c8 (patch) | |
| tree | 0671c7954f3fdc59c73a356649a7c403c0d0ff89 /xlators/cluster/afr/src/afr-open.c | |
| parent | 526448e784317e3c9ec72e1641f82b28959b696d (diff) | |
afr: exit out of stack winds in for loops if call_count is zero
....in order to avoid a race where the fop cbk frees the frame's local
variables and the fop tries to access it at a later point in time.
Change-Id: I91d2696e5e183c61ea1368b3a538f9ed7f3851de
BUG: 1200764
Signed-off-by: Ravishankar N <ravishankar@redhat.com>
Reviewed-on: http://review.gluster.org/9856
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: pranith karampuri <pranith.k@gmail.com>
Reviewed-by: Niels de Vos <ndevos@redhat.com>
Diffstat (limited to 'xlators/cluster/afr/src/afr-open.c')
| -rw-r--r-- | xlators/cluster/afr/src/afr-open.c | 4 |
1 files changed, 4 insertions, 0 deletions
diff --git a/xlators/cluster/afr/src/afr-open.c b/xlators/cluster/afr/src/afr-open.c index ccfd655eebb..9e49857508a 100644 --- a/xlators/cluster/afr/src/afr-open.c +++ b/xlators/cluster/afr/src/afr-open.c @@ -304,6 +304,7 @@ afr_fix_open (xlator_t *this, fd_t *fd, size_t need_open_count, int *need_open) int ret = -1; int32_t op_errno = 0; afr_fd_ctx_t *fd_ctx = NULL; + int call_count = -1; priv = this->private; @@ -335,6 +336,7 @@ afr_fix_open (xlator_t *this, fd_t *fd, size_t need_open_count, int *need_open) local->fd = fd_ref (fd); local->call_count = need_open_count; + call_count = need_open_count; gf_log (this->name, GF_LOG_DEBUG, "need open count: %zd", need_open_count); @@ -367,6 +369,8 @@ afr_fix_open (xlator_t *this, fd_t *fd, size_t need_open_count, int *need_open) fd_ctx->flags & (~O_TRUNC), local->fd, NULL); } + if (!--call_count) + break; } op_errno = 0; |