diff options
| author | Anuradha <atalur@redhat.com> | 2015-02-25 15:09:28 +0530 | 
|---|---|---|
| committer | Vijay Bellur <vbellur@redhat.com> | 2015-03-19 06:33:12 -0700 | 
| commit | d06692d1deec425f74747e2c463e56f7eca981c8 (patch) | |
| tree | 2bb530f08506ee80b5704b09a02fb7f1bb75dfea /xlators/cluster/afr/src/afr-inode-write.c | |
| parent | 6f71bc02df5bd177c2f5dbf4e54b2af1525ab979 (diff) | |
cluster/afr : enable inspection & resolution of files in split-brain
Part 2/2 patch to enable users analyze and resolve
split-brain.
This patch enables :
1) Users to inspect the files in data and metadata split-brain.
2) Resolve the split-brain.
Both using a series of setfattr commands.
Consider a volume "test" with 2 bricks.
1) To inspect a file f1:
setfattr -n replica.split-brain-choice -v test-client-0 f1
        After the execution of this command, if no read_subvol
is found, reads will be served from test-client-0 (corresponding
to brick-0).
2) To resolve split-brain :
setfattr -n replica.split-brain-heal-finalize -v test-client-0 f1
        Execution of this command will lead to the resolution
of data and metadata split-brain with subvol mentioned in the
command (test-client-0 here) as the source and the rest as sink.
Change-Id: Ia20f3ee5abd3119e3d54fcc599f1e55ac65fd179
BUG: 1191396
Signed-off-by: Anuradha <atalur@redhat.com>
Reviewed-on: http://review.gluster.org/9743
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Diffstat (limited to 'xlators/cluster/afr/src/afr-inode-write.c')
| -rw-r--r-- | xlators/cluster/afr/src/afr-inode-write.c | 146 | 
1 files changed, 145 insertions, 1 deletions
diff --git a/xlators/cluster/afr/src/afr-inode-write.c b/xlators/cluster/afr/src/afr-inode-write.c index 0c96d069ae5..776933892ff 100644 --- a/xlators/cluster/afr/src/afr-inode-write.c +++ b/xlators/cluster/afr/src/afr-inode-write.c @@ -34,8 +34,8 @@  #include "common-utils.h"  #include "compat-errno.h"  #include "compat.h" +#include "protocol-common.h" -#include "afr.h"  #include "afr-transaction.h" @@ -961,6 +961,145 @@ afr_setxattr_wind (call_frame_t *frame, xlator_t *this, int subvol)          return 0;  } +int +afr_split_brain_resolve_do (call_frame_t *frame, xlator_t *this, loc_t *loc, +                            char *data) +{ +        afr_local_t    *local             = NULL; +        int     ret                       = -1; +        int     op_errno                  = EINVAL; + +        local = AFR_FRAME_INIT (frame, op_errno); +        if (!local) +                goto out; + +        local->op = GF_FOP_SETXATTR; + +        local->xdata_req = dict_new (); + +        if (!local->xdata_req) { +                op_errno = ENOMEM; +                goto out; +        } + +        ret = dict_set_int32 (local->xdata_req, "heal-op", +                              GF_SHD_OP_SBRAIN_HEAL_FROM_BRICK); +        if (ret) { +                op_errno = -ret; +                ret = -1; +                goto out; +        } +        ret = dict_set_str (local->xdata_req, "child-name", data); +        if (ret) { +                op_errno = -ret; +                ret = -1; +                goto out; +        } +        afr_heal_splitbrain_file (frame, this, loc); +out: +        if (ret < 0) +                AFR_STACK_UNWIND (setxattr, frame, -1, op_errno, NULL); +        return 0; +} + +int +afr_set_split_brain_choice (call_frame_t *frame, xlator_t *this, loc_t *loc, +                            int spb_choice) +{ +        int     ret       = -1; +        int     op_errno  = ENOMEM; +        afr_private_t *priv = NULL; + +        priv = this->private; + +        ret = afr_inode_split_brain_choice_set (loc->inode, this, spb_choice); +        if (ret) { +                gf_log (this->name, GF_LOG_ERROR, "Failed to set" +                        "split-brain choice as %s for %s", +                        priv->children[spb_choice]->name, +                        loc->name); +        } +        inode_invalidate (loc->inode); +        AFR_STACK_UNWIND (setxattr, frame, ret, op_errno, NULL); +        return ret; +} + +int +afr_get_split_brain_child_index (xlator_t *this, void *value, size_t len) +{ +        int             spb_child_index   = -1; +        char           *spb_child_str     = NULL; + +        spb_child_str =  alloca0 (len + 1); +        memcpy (spb_child_str, value, len); + +        if (!strcmp (spb_child_str, "none")) +                return -2; + +        spb_child_index = afr_get_child_index_from_name (this, +                                                         spb_child_str); +        if (spb_child_index < 0) { +                gf_log (this->name, GF_LOG_ERROR, "Invalid subvol: %s", +                        spb_child_str); +        } +        return spb_child_index; +} + +int +afr_handle_split_brain_commands (xlator_t *this, call_frame_t *frame, +                                loc_t *loc, dict_t *dict) +{ +        int             len               = 0; +        void           *value             = NULL; +        int             spb_child_index   = -1; +        int             ret               = -1; +        int             op_errno          = EINVAL; +        afr_private_t  *priv              = NULL; + +        priv = this->private; + +        ret =  dict_get_ptr_and_len (dict, GF_AFR_SBRAIN_CHOICE, &value, +                                     &len); +        if (value) { +                spb_child_index = afr_get_split_brain_child_index (this, value, +                                                                   len); +                if (spb_child_index < 0) { +                        /* Case where value was "none" */ +                        if (spb_child_index == -2) +                                spb_child_index = -1; +                        else { +                                ret = 1; +                                goto out; +                        } +                } + +                afr_set_split_brain_choice (frame, this, loc, +                                            spb_child_index); +                ret = 0; +                goto out; +        } + +        ret = dict_get_ptr_and_len (dict, GF_AFR_SBRAIN_RESOLVE, &value, &len); +        if (value) { +                spb_child_index = afr_get_split_brain_child_index (this, value, +                                                                   len); +                if (spb_child_index < 0) { +                        ret = 1; +                        goto out; +                } + +                afr_split_brain_resolve_do (frame, this, loc, +                                            priv->children[spb_child_index]->name); +                ret = 0; +        } +out: +        /* key was correct but value was invalid when ret == 1 */ +        if (ret == 1) { +                AFR_STACK_UNWIND (setxattr, frame, -1, op_errno, NULL); +                ret = 0; +        } +        return ret; +}  int  afr_setxattr (call_frame_t *frame, xlator_t *this, loc_t *loc, dict_t *dict, @@ -977,6 +1116,11 @@ afr_setxattr (call_frame_t *frame, xlator_t *this, loc_t *loc, dict_t *dict,          GF_IF_INTERNAL_XATTR_GOTO ("trusted.glusterfs.afr.*", dict,                                     op_errno, out); +        ret = afr_handle_split_brain_commands (this, frame, loc, dict); + +        if (ret == 0) +                return 0; +          transaction_frame = copy_frame (frame);          if (!transaction_frame)                  goto out;  | 
