diff options
| author | Krishnan Parthasarathi <kp@gluster.com> | 2011-06-10 04:42:28 +0000 |
|---|---|---|
| committer | Anand Avati <avati@gluster.com> | 2011-06-10 03:53:58 -0700 |
| commit | 25da481bc5b06d671e41e5a70b2c145777154bf1 (patch) | |
| tree | c58240c266f711778181d96e270f9ea6a053e145 /xlators/cluster/afr/src/afr-common.c | |
| parent | fb42a67e1eea17b3dc116d26ea92b93f740b28c3 (diff) | |
pump: cleanup potential dict related memory corruption.v3.1.5qa2
Signed-off-by: Krishnan Parthasarathi <kp@gluster.com>
Signed-off-by: Anand Avati <avati@gluster.com>
BUG: 2489 (GlusterFS crashing with replace-brick)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2489
Diffstat (limited to 'xlators/cluster/afr/src/afr-common.c')
| -rw-r--r-- | xlators/cluster/afr/src/afr-common.c | 14 |
1 files changed, 12 insertions, 2 deletions
diff --git a/xlators/cluster/afr/src/afr-common.c b/xlators/cluster/afr/src/afr-common.c index 868dab736b9..5c8a8105d30 100644 --- a/xlators/cluster/afr/src/afr-common.c +++ b/xlators/cluster/afr/src/afr-common.c @@ -63,13 +63,23 @@ int32_t afr_set_dict_gfid (dict_t *dict, uuid_t gfid) { - int ret = 0; + int ret = 0; + uuid_t *pgfid = NULL; GF_ASSERT (gfid); + pgfid = GF_CALLOC (1, sizeof (uuid_t), gf_common_mt_char); + if (!pgfid) { + ret = -1; + goto out; + } + uuid_copy (*pgfid, gfid); - ret = dict_set_static_bin (dict, "gfid-req", gfid, 16); + ret = dict_set_dynptr (dict, "gfid-req", pgfid, 16); if (ret) gf_log (THIS->name, GF_LOG_DEBUG, "gfid set failed"); +out: + if (ret && pgfid) + GF_FREE (pgfid); return ret; } |