path: root/xlators/cluster/afr/src/afr-common.c
diff options
authorkarthik-us <>2020-05-21 15:18:59 +0530
committerRinku Kothiya <>2020-07-08 01:29:06 +0000
commitc30bd3ca40fe2235ab46f3cd1e76ed64ba0cd8e4 (patch)
tree7a8faa141b9f50e815fc93abda065f4cb622636b /xlators/cluster/afr/src/afr-common.c
parent4cc44e3f128bf0eb90e5634c634ff5eabeaeda60 (diff)
cluster/afr: Prioritize ENOSPC over other errors
Problem: In a replicate/arbiter volume if file creations or writes fails on quorum number of bricks and on one brick it is due to ENOSPC and on other brick it fails for a different reason, it may fail with errors other than ENOSPC in some cases. Fix: Prioritize ENOSPC over other lesser priority errors and do not set op_errno in posix_gfid_set if op_ret is 0 to avoid receiving any error_no which can be misinterpreted by __afr_dir_write_finalize(). Also removing the function afr_has_arbiter_fop_cbk_quorum() which might consider a successful reply form a single brick as quorum success in some cases, whereas we always need fop to be successful on quorum number of bricks in arbiter configuration. Change-Id: I106e267f8b9451f681022f1cccb410d9bc824c08 Fixes: #1254 Signed-off-by: karthik-us <> (cherry picked from commit fa63b45ca5edf172b1b89b28b5db3c5129cc57b6)
Diffstat (limited to 'xlators/cluster/afr/src/afr-common.c')
1 files changed, 3 insertions, 1 deletions
diff --git a/xlators/cluster/afr/src/afr-common.c b/xlators/cluster/afr/src/afr-common.c
index 8959a9c503d..ecad217d0c4 100644
--- a/xlators/cluster/afr/src/afr-common.c
+++ b/xlators/cluster/afr/src/afr-common.c
@@ -2471,7 +2471,7 @@ error:
* others in that they must be given higher priority while
* returning to the user.
- * The hierarchy is ENODATA > ENOENT > ESTALE > others
+ * The hierarchy is ENODATA > ENOENT > ESTALE > ENOSPC others
@@ -2483,6 +2483,8 @@ afr_higher_errno(int32_t old_errno, int32_t new_errno)
return ENOENT;
if (old_errno == ESTALE || new_errno == ESTALE)
return ESTALE;
+ if (old_errno == ENOSPC || new_errno == ENOSPC)
+ return ENOSPC;
return new_errno;