diff options
| author | N Balachandran <nbalacha@redhat.com> | 2015-11-04 15:20:49 +0530 |
|---|---|---|
| committer | Dan Lambright <dlambrig@redhat.com> | 2015-11-04 03:55:08 -0800 |
| commit | c2c7a4e472ef737a2f3d8e97e4cd007442a5f5a2 (patch) | |
| tree | d58a596ded6999892b3dec10bd99f9dae826029b /tests/tier.rc | |
| parent | 87788a273e6026fb125e0a73d8a9034a32a2e2dc (diff) | |
cluster/tier : Files skipped during tier query parsing
The tier query parsing code was using fscanf to read each record.
As space is a delimiter for fscanf, filenames containing spaces
caused the parsing to return unexpected values causing various
issues in the tier process, including crashes due to buffer
overflows.
> Change-Id: Ife602cb7ecb158fccbc2c89e4d2959bd97098a87
> Signed-off-by: N Balachandran <nbalacha@redhat.com>
> Reviewed-on: http://review.gluster.org/12469
> Tested-by: NetBSD Build System <jenkins@build.gluster.org>
> Tested-by: Gluster Build System <jenkins@build.gluster.com>
> Reviewed-by: Dan Lambright <dlambrig@redhat.com>
> Tested-by: Dan Lambright <dlambrig@redhat.com>
(cherry picked from commit 499b43058049572e33b525ac669ef623d476fe41)
Change-Id: Id60f9c484dfbb02de6ebb44032160ad4cc94cb7f
BUG: 1277587
Signed-off-by: N Balachandran <nbalacha@redhat.com>
Reviewed-on: http://review.gluster.org/12502
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Dan Lambright <dlambrig@redhat.com>
Tested-by: Dan Lambright <dlambrig@redhat.com>
Diffstat (limited to 'tests/tier.rc')
| -rw-r--r-- | tests/tier.rc | 16 |
1 files changed, 16 insertions, 0 deletions
diff --git a/tests/tier.rc b/tests/tier.rc index 393d712f3bb..3fa6af6a40f 100644 --- a/tests/tier.rc +++ b/tests/tier.rc @@ -18,6 +18,22 @@ function is_sticky_set () { } +function exists_and_regular_file () { + filepath=$1 + if [ -n "$filepath" ]; + then + if [ -k "$filepath" ] + then + echo "no" + else + echo "yes" + fi + else + echo "no" + fi +} + + function check_counters { index=0 ret=0 |