summaryrefslogtreecommitdiffstats
path: root/tests/bugs
diff options
context:
space:
mode:
authorSachin Pandit <spandit@redhat.com>2014-04-03 10:00:04 +0530
committerVijay Bellur <vbellur@redhat.com>2014-04-29 22:02:01 -0700
commite2034a84d284c37ade9f49be1589e3f53321bb23 (patch)
treef0827a0ed6b4d4f04ab50f65f8d6d6cec991354f /tests/bugs
parent4d9e0bf658cce3cf9f808bb6d0a4cb2d8c9ad504 (diff)
snapshot/config : Fix for bug which states gluster snapshot config
command should only accept the decimal numeric value. Syntax : gluster snapshot config [volname] [snap-max-hard-limit <count>] [snap-max-soft-limit <percentage>] Problem : Snapshot config used to consider the alphanumeric value staring with digit as an integer (Example: "9abc" is converted to "9"). Solution : Refined the code to check if the entered value is numeric. This patch also fixes some of the minor problems related to snapshot config. 1) Output correction in gluster snapshot config snap-max-soft-limit. 2) setting the soft limit to greater than 100% displays that "Invalid snap-max-soft-limit 0". The error message used to display "zero" in the output, Changed this to display relevant value. 3) Setting greater than allowed snap-max-hard-limit output needs to have space in between. Change-Id: Ie7c7045722fe57b2b3c50c873664b67c28eb3853 BUG: 1087203 Signed-off-by: Sachin Pandit <spandit@redhat.com> Reviewed-on: http://review.gluster.org/7457 Reviewed-by: Vijaikumar Mallikarjuna <vmallika@redhat.com> Tested-by: Gluster Build System <jenkins@build.gluster.com> Reviewed-by: Vijay Bellur <vbellur@redhat.com>
Diffstat (limited to 'tests/bugs')
-rw-r--r--tests/bugs/bug-1087203.t44
1 files changed, 44 insertions, 0 deletions
diff --git a/tests/bugs/bug-1087203.t b/tests/bugs/bug-1087203.t
new file mode 100644
index 00000000000..0c4ee01cba5
--- /dev/null
+++ b/tests/bugs/bug-1087203.t
@@ -0,0 +1,44 @@
+#!/bin/bash
+
+. $(dirname $0)/../include.rc
+. $(dirname $0)/../volume.rc
+
+cleanup;
+
+TEST glusterd;
+TEST $CLI volume info;
+
+TEST $CLI volume create $V0 replica 2 $H0:$B0/${V0}-{0,1};
+EXPECT "$V0" volinfo_field $V0 'Volume Name';
+EXPECT 'Created' volinfo_field $V0 'Status';
+
+TEST $CLI volume start $V0
+EXPECT 'Started' volinfo_field $V0 'Status';
+
+
+# Setting system limit
+TEST $CLI snapshot config snap-max-hard-limit 100
+
+# Volume limit cannot exceed system limit, as limit is set to 100,
+# this should fail.
+TEST ! $CLI snapshot config $V0 snap-max-hard-limit 101
+
+# Following are the invalid cases
+TEST ! $CLI snapshot config $V0 snap-max-hard-limit a10
+TEST ! $CLI snapshot config snap-max-hard-limit 10a
+TEST ! $CLI snapshot config snap-max-hard-limit 10%
+TEST ! $CLI snapshot config snap-max-soft-limit 50%1
+TEST ! $CLI snapshot config snap-max-soft-limit 0111
+TEST ! $CLI snapshot config snap-max-hard-limit OXA
+TEST ! $CLI snapshot config snap-max-hard-limit 11.11
+TEST ! $CLI snapshot config snap-max-soft-limit 50%
+
+# Soft limit cannot be assigned to volume
+TEST ! $CLI snapshot config $V0 snap-max-soft-limit 10
+
+# Valid case
+TEST $CLI snapshot config snap-max-soft-limit 50
+TEST $CLI snapshot config $V0 snap-max-hard-limit 10
+
+cleanup;
+