diff options
| author | Michael Scherer <misc@redhat.com> | 2017-02-23 20:17:25 +0100 |
|---|---|---|
| committer | Raghavendra G <rgowdapp@redhat.com> | 2017-02-28 23:29:38 -0500 |
| commit | bae7b51d628a3ff4d96be1ec62dca1c8ed008dc8 (patch) | |
| tree | 0ccba268cbfddba4d62ba0b87f3a0c4e080952f3 /rpc | |
| parent | 3e66156cf202c56010bfa0c63db95ef0a5998947 (diff) | |
Use int instead of int8_t for the 3 variables
Since strcmp return a int, and since the spec
of strcmp do not tell the return value, it
could return 256 and this would overflow.
Found by Coverity scan.
(thanks to Stéphane Marcheusin who explained
the details to me)
Change-Id: I5195e05b44f8b537226e6cee178d95a1ab904e96
BUG: 789278
Signed-off-by: Michael Scherer <misc@redhat.com>
Reviewed-on: https://review.gluster.org/16738
Smoke: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Shyamsundar Ranganathan <srangana@redhat.com>
Tested-by: Michael Scherer <misc@fedoraproject.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Raghavendra G <rgowdapp@redhat.com>
Diffstat (limited to 'rpc')
| -rw-r--r-- | rpc/rpc-lib/src/rpc-transport.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/rpc/rpc-lib/src/rpc-transport.c b/rpc/rpc-lib/src/rpc-transport.c index 33e94450d9c..4fbbc8cd7fc 100644 --- a/rpc/rpc-lib/src/rpc-transport.c +++ b/rpc/rpc-lib/src/rpc-transport.c @@ -171,7 +171,7 @@ rpc_transport_load (glusterfs_ctx_t *ctx, dict_t *options, char *trans_name) char *type = NULL; char str[] = "ERROR"; int32_t ret = -1; - int8_t is_tcp = 0, is_unix = 0, is_ibsdp = 0; + int is_tcp = 0, is_unix = 0, is_ibsdp = 0; volume_opt_list_t *vol_opt = NULL; gf_boolean_t bind_insecure = _gf_false; xlator_t *this = NULL; |