summaryrefslogtreecommitdiffstats
path: root/rpc/rpc-lib/src/rpc-clnt.c
diff options
context:
space:
mode:
authorNandaja Varma <nandaja.varma@gmail.com>2015-02-06 11:44:22 +0530
committerVijay Bellur <vbellur@redhat.com>2015-04-10 11:29:42 +0000
commit26cbd3bdf5dad190559afbdf0ac125262c4e90a6 (patch)
tree9d8fed20e8d46f33e9dddd321ca014917d473c06 /rpc/rpc-lib/src/rpc-clnt.c
parent320455bddfbadcfbe1b173b0de54b3b25bf228f7 (diff)
rpc-lib: Fixing the coverity issues
Coverity CIDs: 1210973 1124887 1124888 1124682 1124849 1124503 Change-Id: I012f6cf9d14753f572ab94aae6d442d1ef8df79a BUG: 789278 Signed-off-by: Nandaja Varma <nandaja.varma@gmail.com> Reviewed-on: http://review.gluster.org/9600 Tested-by: Gluster Build System <jenkins@build.gluster.com> Reviewed-by: Vijay Bellur <vbellur@redhat.com>
Diffstat (limited to 'rpc/rpc-lib/src/rpc-clnt.c')
-rw-r--r--rpc/rpc-lib/src/rpc-clnt.c15
1 files changed, 8 insertions, 7 deletions
diff --git a/rpc/rpc-lib/src/rpc-clnt.c b/rpc/rpc-lib/src/rpc-clnt.c
index 20981ef9c9c..264a3120a46 100644
--- a/rpc/rpc-lib/src/rpc-clnt.c
+++ b/rpc/rpc-lib/src/rpc-clnt.c
@@ -724,7 +724,7 @@ rpc_clnt_handle_cbk (struct rpc_clnt *clnt, rpc_transport_pollin_t *msg)
}
out:
- clnt = rpc_clnt_unref (clnt);
+ rpc_clnt_unref (clnt);
return ret;
}
@@ -774,7 +774,7 @@ out:
mem_put (saved_frame);
}
- clnt = rpc_clnt_unref (clnt);
+ rpc_clnt_unref (clnt);
return ret;
}
@@ -1455,11 +1455,12 @@ rpcclnt_cbk_program_register (struct rpc_clnt *clnt,
program->progver);
out:
- if (ret == -1) {
- gf_log (clnt->conn.name, GF_LOG_ERROR,
- "Program registration failed:"
- " %s, Num: %d, Ver: %d", program->progname,
- program->prognum, program->progver);
+ if (ret == -1 && clnt) {
+ gf_log (clnt->conn.name, GF_LOG_ERROR,
+ "Program registration failed:"
+ " %s, Num: %d, Ver: %d",
+ program->progname,
+ program->prognum, program->progver);
}
return ret;