summaryrefslogtreecommitdiffstats
path: root/libglusterfs
diff options
context:
space:
mode:
authorPranith Kumar K <pkarampu@redhat.com>2017-11-27 09:50:32 +0530
committerXavier Hernandez <jahernan@redhat.com>2017-11-29 09:17:19 +0000
commit9af6fb54d81b992b9ebaf5dd56aed34fd7dba032 (patch)
treed10b0981b5dd520257f5a64a89f4d99885cb21f2 /libglusterfs
parent01aa87e20490769f1a45f724b6985f6a90ca2b13 (diff)
cluster-syncop: Address comments in 3ad68df725ac32f83b5ea7c0976e2327e7037c8c
Change-Id: I325f718c6c440076c9d9dcd5ad1a0c6bde5393b1 Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
Diffstat (limited to 'libglusterfs')
-rw-r--r--libglusterfs/src/cluster-syncop.c6
1 files changed, 4 insertions, 2 deletions
diff --git a/libglusterfs/src/cluster-syncop.c b/libglusterfs/src/cluster-syncop.c
index 75ba6404d91..50542eb7c16 100644
--- a/libglusterfs/src/cluster-syncop.c
+++ b/libglusterfs/src/cluster-syncop.c
@@ -1220,6 +1220,10 @@ cluster_tiebreaker_inodelk (xlator_t **subvols, unsigned char *on,
num_success++;
continue;
}
+
+ /* TODO: If earlier subvols fail with an error other
+ * than EAGAIN, we could still have 2 clients competing
+ * for the lock*/
if (replies[i].op_ret == -1 && replies[i].op_errno == EAGAIN) {
cluster_fop_success_fill (replies, numsubvols,
locked_on);
@@ -1231,8 +1235,6 @@ cluster_tiebreaker_inodelk (xlator_t **subvols, unsigned char *on,
FOP_SEQ (subvols, on, numsubvols, replies,
locked_on, frame, inodelk, dom, &loc,
F_SETLKW, &flock, NULL);
- } else {
- memset (locked_on, 0, numsubvols);
}
break;
}