|author||Prashanth Pai <firstname.lastname@example.org>||2016-05-04 16:56:50 +0530|
|committer||Raghavendra G <email@example.com>||2016-05-11 04:02:57 -0700|
readdir-ahead: Prefetch xattrs needed by md-cache
Problem: Negative cache feature implementation in md-cache requires xattrs returned by posix to be intercepted for every call that can possibly return xattrs. This includes readdirp(). This is crucial to treat missing keys in cache as a case of negative entry (returns ENODATA) md-cache puts names of xattrs that it wants to cache in xdata and passes it down to posix which returns the specified xattrs in the callback. This is done in lookup() and readdirp(). Hence, a xattr that is cached can be invalidated during readdirp_cbk too. This is based on the assumption that readdirp() will always return all xattrs that md-cache is interested in. However, this is not the case when readdirp() call is served from readdir-ahead's cache. readdir-ahead xlator will pre-fetch dentries during opendir_cbk and readdirp. These internal readdirp() calls made by readdir-ahead xlator does not set xdata in it's requests. Hence, no xattrs are fetched and stored in it's internal cache. This causes metadata loss in gluster-swift. md-cache returns ENODATA during getxattr() call even though the xattr for that object exists on the brick. On receiving ENODATA, gluster-swift will create new metadata and do setxattr(). This results in loss of information stored in existing xattr. Fix: During opendir, md-cache will communicate to readdir-ahead asking it to store the names of xattrs it's interested in so that readdir-ahead can fetch those in all subsequent internal readdirp() calls issued by it. This stored names of xattrs is invalidated/updated on the next real readdirp() call issued by application. This readdirp() call will have xdata set correctly by md-cache xlator. > Reviewed-on: http://review.gluster.org/14214 > Tested-by: Prashanth Pai <firstname.lastname@example.org> > NetBSD-regression: NetBSD Build System <email@example.com> > CentOS-regression: Gluster Build System <firstname.lastname@example.org> > Tested-by: Gluster Build System <email@example.com> > Smoke: Gluster Build System <firstname.lastname@example.org> > Reviewed-by: Raghavendra G <email@example.com> > Tested-by: Raghavendra G <firstname.lastname@example.org> BUG: 1334700 Change-Id: I32d46f93a99d4ec34c741f3c52b0646d141614f9 (cherry picked from commit 0c73e7050c4d30ace0c39cc9b9634e9c1b448cfb) Reviewed-on: http://review.gluster.org/14282 Tested-by: Prashanth Pai <email@example.com> NetBSD-regression: NetBSD Build System <firstname.lastname@example.org> Tested-by: Gluster Build System <email@example.com> CentOS-regression: Gluster Build System <firstname.lastname@example.org> Smoke: Gluster Build System <email@example.com> Reviewed-by: Raghavendra G <firstname.lastname@example.org>
Diffstat (limited to 'libglusterfs')
1 files changed, 1 insertions, 0 deletions
diff --git a/libglusterfs/src/glusterfs.h b/libglusterfs/src/glusterfs.h
index fb4bddb..c8c4590 100644
@@ -92,6 +92,7 @@
#define GF_INTERNAL_IGNORE_DEEM_STATFS "ignore-deem-statfs"
#define GF_READDIR_SKIP_DIRS "readdir-filter-directories"
+#define GF_MDC_LOADED_KEY_NAMES "glusterfs.mdc.loaded.key.names"
#define BD_XATTR_KEY "user.glusterfs"
#define GF_PREOP_PARENT_KEY "glusterfs.preop.parent.key"