summaryrefslogtreecommitdiffstats
path: root/libglusterfs/src
diff options
context:
space:
mode:
authorCsaba Henk <csaba@gluster.com>2009-11-29 19:26:57 +0000
committerAnand V. Avati <avati@dev.gluster.com>2009-11-30 03:06:42 -0800
commit2a3adcfe5c8d649a17b2d30f3715f26794dff6bb (patch)
treef390b27c1e36784db1b5469556d1ad06b77882e3 /libglusterfs/src
parentcc3967db49e5983f43530708c1eb4b2708546ad9 (diff)
fix leaks pointed out by cppcheck static analyzer
See http://cppcheck.sf.net [./build/libglusterfs/src/y.tab.c:2104]: (error) Memory leak: cmd [./libglusterfs/src/md5.c:306]: (error) Resource leak: f [./xlators/debug/io-stats/src/io-stats.c:1396]: (error) Possible null pointer dereference: this - otherwise it is redundant to check if this is null at line 1402 [./xlators/cluster/stripe/src/stripe.c:3597]: (error) Memory leak: dup_str [./xlators/debug/trace/src/trace.c:2426]: (error) Possible null pointer dereference: this - otherwise it is redundant to check if this is null at line 2429 These appear in rarely hit error cases or test/demo code so nothing serious, in fact. Signed-off-by: Csaba Henk <csaba@gluster.com> Signed-off-by: Anand V. Avati <avati@dev.gluster.com> BUG: 420 (fix leaks pointed out by cppcheck static analyzer) URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=420
Diffstat (limited to 'libglusterfs/src')
-rw-r--r--libglusterfs/src/md5.c2
-rw-r--r--libglusterfs/src/spec.y1
2 files changed, 3 insertions, 0 deletions
diff --git a/libglusterfs/src/md5.c b/libglusterfs/src/md5.c
index 6fd6ecbf780..5f0d0d157bf 100644
--- a/libglusterfs/src/md5.c
+++ b/libglusterfs/src/md5.c
@@ -294,6 +294,8 @@ int main(int argc, char *argv[])
while ((i = fread(buf, 1, sizeof buf, f)) > 0)
md5_update(&ctx, buf, i);
+ fclose(f);
+
md5_result(&ctx, md5sum);
for (j = 0; j < MD5_DIGEST_LEN; j++)
diff --git a/libglusterfs/src/spec.y b/libglusterfs/src/spec.y
index e5d68b42106..ec9101a2c21 100644
--- a/libglusterfs/src/spec.y
+++ b/libglusterfs/src/spec.y
@@ -518,6 +518,7 @@ parse_backtick (FILE *srcfp, FILE *dstfp)
result = realloc (result,
2 * cmd_buf_size);
if (result == NULL) {
+ free (cmd);
return -1;
}
}