summaryrefslogtreecommitdiffstats
path: root/libglusterfs/src/syncop.h
diff options
context:
space:
mode:
authorKrishnan Parthasarathi <kparthas@redhat.com>2013-05-11 14:29:29 +0530
committerVijay Bellur <vbellur@redhat.com>2013-05-21 06:03:14 -0700
commitf8e19c6b6f21142aadabd2f30dc3b960a6ec1fa2 (patch)
tree76f6fc68048ccce6c95b3758b5461992accf54cc /libglusterfs/src/syncop.h
parent8abe8f794913daa81d9f1dc0ddab26c9c414abf8 (diff)
syncop: Update synctask state appropriately
Backport of http://review.gluster.org/4985 * Earlier, SYNCOP macro, the only consumer of synctask_yield, would set the task->state to SYNCTASK_SUSPEND. Today, we have glusterd having its own wrapper macros which don't set task's state. There is also the syncbarrier and synclock framework, which also participate in a synctask's scheduling (and need to keep a task's state up to date). It only makes more sense to leave a synctask's state to the synctask library, since its an internal affair. * Need to 'yawn' before 'yield' to avoid re-running tasks to set task->woken appropriately. Change-Id: Ic7a59e6ebcc46f03e53223ca237668d45a3cba40 BUG: 948686 Signed-off-by: Krishnan Parthasarathi <kparthas@redhat.com> Reviewed-on: http://review.gluster.org/5053 Tested-by: Gluster Build System <jenkins@build.gluster.com> Reviewed-by: Vijay Bellur <vbellur@redhat.com>
Diffstat (limited to 'libglusterfs/src/syncop.h')
-rw-r--r--libglusterfs/src/syncop.h2
1 files changed, 0 insertions, 2 deletions
diff --git a/libglusterfs/src/syncop.h b/libglusterfs/src/syncop.h
index f6eb423a4b6..d27c19d7011 100644
--- a/libglusterfs/src/syncop.h
+++ b/libglusterfs/src/syncop.h
@@ -208,8 +208,6 @@ struct syncargs {
\
STACK_WIND_COOKIE (frame, cbk, (void *)stb, subvol, \
op, params); \
- if (task) \
- task->state = SYNCTASK_SUSPEND; \
\
__yield (stb); \
if (task) \