diff options
| author | Jeff Darcy <jdarcy@fb.com> | 2017-06-29 06:50:56 -0700 |
|---|---|---|
| committer | Niels de Vos <ndevos@redhat.com> | 2017-06-30 10:31:02 +0000 |
| commit | 0be8e038d9bf90be94f3e3a7d6ea5bee88da9ecb (patch) | |
| tree | 2f23f3b205a9bdd386488cc00a3d4b1f23b4a076 /libglusterfs/src/stack.h | |
| parent | 50d72373fadf1174918e754e31bae3806aa4c214 (diff) | |
multiple: fix struct/typedef inconsistencies
The most common pattern, both in our code and elsewhere, is this:
struct _xyz {
...
};
typedef struct _xyz xyz_t;
These exceptions - especially call_frame/call_stack - have been slowing
down code navigation for years. By converging on a single pattern,
navigating from xyz_t in code to the actual definition of struct _xyz
(i.e. without having to visit the typedef first) might even be
automatable.
Change-Id: I0e5dd1f51f98e000173c62ef4ddc5b21d9ec44ed
Signed-off-by: Jeff Darcy <jdarcy@fb.com>
Reviewed-on: https://review.gluster.org/17650
Smoke: Gluster Build System <jenkins@build.gluster.org>
Tested-by: Jeff Darcy <jeff@pl.atyp.us>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Amar Tumballi <amarts@redhat.com>
Reviewed-by: Niels de Vos <ndevos@redhat.com>
Diffstat (limited to 'libglusterfs/src/stack.h')
| -rw-r--r-- | libglusterfs/src/stack.h | 12 |
1 files changed, 6 insertions, 6 deletions
diff --git a/libglusterfs/src/stack.h b/libglusterfs/src/stack.h index 51698d16f55..20fbdfabff5 100644 --- a/libglusterfs/src/stack.h +++ b/libglusterfs/src/stack.h @@ -16,10 +16,10 @@ #ifndef _STACK_H #define _STACK_H -struct _call_stack_t; -typedef struct _call_stack_t call_stack_t; -struct _call_frame_t; -typedef struct _call_frame_t call_frame_t; +struct _call_stack; +typedef struct _call_stack call_stack_t; +struct _call_frame; +typedef struct _call_frame call_frame_t; struct call_pool; typedef struct call_pool call_pool_t; @@ -61,7 +61,7 @@ struct call_pool { struct mem_pool *stack_mem_pool; }; -struct _call_frame_t { +struct _call_frame { call_stack_t *root; /* stack root */ call_frame_t *parent; /* previous BP */ struct list_head frames; @@ -84,7 +84,7 @@ struct _call_frame_t { #define SMALL_GROUP_COUNT 128 -struct _call_stack_t { +struct _call_stack { union { struct list_head all_frames; struct { |