diff options
| author | Jeff Darcy <jdarcy@redhat.com> | 2015-07-28 12:11:12 -0400 |
|---|---|---|
| committer | Jeff Darcy <jdarcy@redhat.com> | 2015-09-01 04:55:15 -0700 |
| commit | 0773ca67fdb60a142207759fa6c07a69882ce59c (patch) | |
| tree | 027101fce644fe17e58c78321b1632f38aaed166 /libglusterfs/src/common-utils.c | |
| parent | 038dfe57cf0c5944b0392332dbf5a00bb1208150 (diff) | |
all: reduce "inline" usage
There are three kinds of inline functions: plain inline, extern inline,
and static inline. All three have been removed from .c files, except
those in "contrib" which aren't our problem. Inlines in .h files, which
are overwhelmingly "static inline" already, have generally been left
alone. Over time we should be able to "lower" these into .c files, but
that has to be done in a case-by-case fashion requiring more manual
effort. This part was easy to do automatically without (as far as I can
tell) any ill effect.
In the process, several pieces of dead code were flagged by the
compiler, and were removed.
Change-Id: I56a5e614735c9e0a6ee420dab949eac22e25c155
BUG: 1245331
Signed-off-by: Jeff Darcy <jdarcy@redhat.com>
Reviewed-on: http://review.gluster.org/11769
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Dan Lambright <dlambrig@redhat.com>
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
Reviewed-by: Niels de Vos <ndevos@redhat.com>
Reviewed-by: Raghavendra Bhat <raghavendra@redhat.com>
Reviewed-by: Venky Shankar <vshankar@redhat.com>
Diffstat (limited to 'libglusterfs/src/common-utils.c')
| -rw-r--r-- | libglusterfs/src/common-utils.c | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/libglusterfs/src/common-utils.c b/libglusterfs/src/common-utils.c index 2d61b40fd0c..303ee665440 100644 --- a/libglusterfs/src/common-utils.c +++ b/libglusterfs/src/common-utils.c @@ -2485,7 +2485,7 @@ out: * nr */ -inline int32_t +int32_t gf_roundup_power_of_two (int32_t nr) { int32_t result = 1; @@ -2509,7 +2509,7 @@ out: * power of two is returned. */ -inline int32_t +int32_t gf_roundup_next_power_of_two (int32_t nr) { int32_t result = 1; @@ -3390,7 +3390,7 @@ out: return running; } -static inline int +static int dht_is_linkfile_key (dict_t *this, char *key, data_t *value, void *data) { gf_boolean_t *linkfile_key_found = NULL; @@ -3406,7 +3406,7 @@ out: } -inline gf_boolean_t +gf_boolean_t dht_is_linkfile (struct iatt *buf, dict_t *dict) { gf_boolean_t linkfile_key_found = _gf_false; |