diff options
| author | Yaniv Kaul <ykaul@redhat.com> | 2018-08-24 20:59:30 +0300 |
|---|---|---|
| committer | Amar Tumballi <amarts@redhat.com> | 2018-08-29 17:31:11 +0000 |
| commit | cbe133c832fd9907619a1231aa3d9dda1330ae74 (patch) | |
| tree | de607cd6daf2e22051da74c848fa569d68131f86 /libglusterfs/src/client_t.c | |
| parent | 789a5a3d3cbad9c594fd2a94924ec0a2040c27ad (diff) | |
multiple files: remove unndeeded memset()
This is a squash of multiple commits:
contrib/fuse-lib/misc.c: remove unneeded memset()
All flock variables are properly set, no need to memset it.
Only compile-tested!
Signed-off-by: Yaniv Kaul <ykaul@redhat.com>
Change-Id: I8e0512c5a88daadb0e587f545fdb9b32ca8858a2
libglusterfs/src/{client_t|fd|inode|stack}.c: remove some memset()
I don't think there's a need for any of them.
Only compile-tested!
Signed-off-by: Yaniv Kaul <ykaul@redhat.com>
Change-Id: I2be9ccc3a5cb5da51a92af73488cdabd1c527f59
libglusterfs/src/xlator.c: remove unneeded memset()
All xl->mem_acct members are properly set,
no need to memset it.
Only compile-tested!
Signed-off-by: Yaniv Kaul <ykaul@redhat.com>
Change-Id: I7f264cd47e7a06255a3f3943c583de77ae8e3147
xlators/cluster/afr/src/afr-self-heal-common.c: remove unneeded memset()
Since we are going over the whole array anyway, initialize it
properly, to either 1 or 0.
Only compile-tested!
Signed-off-by: Yaniv Kaul <ykaul@redhat.com>
Change-Id: Ied4210388976b6a7a2e91cc3de334534d6fef201
xlators/cluster/dht/src/dht-common.c: remove unneeded memset()
Since we are going over the whole array anyway it is initialized
properly.
Only compile-tested!
Signed-off-by: Yaniv Kaul <ykaul@redhat.com>
Change-Id: Idc436d2bd0563b6582908d7cbebf9dbc66a42c9a
xlators/cluster/ec/src/ec-helpers.c: remove unneeded memset()
Since we are going over the whole array anyway it is initialized
properly.
Only compile-tested!
Signed-off-by: Yaniv Kaul <ykaul@redhat.com>
Change-Id: I81bf971f7fcecb4599e807d37f426f55711978fa
xlators/mgmt/glusterd/src/glusterd-volgen.c: remove some memset()
I don't think there's a need for any of them.
Only compile-tested!
Signed-off-by: Yaniv Kaul <ykaul@redhat.com>
Change-Id: I476ea59ba53546b5153c269692cd5383da81ce2d
xlators/mgmt/glusterd/src/glusterd-geo-rep.c: read() in 4K blocks
The current 1K seems small. 4K is usually better (in Linux).
Also remove a memset() that I don't think is needed between reads.
Only compile-tested!
Signed-off-by: Yaniv Kaul <ykaul@redhat.com>
Change-Id: I5fb7950c92d282948376db14919ad12e589eac2b
xlators/storage/posix/src/posix-{gfid-path|inode-fd-ops}.c: remove memset()
before sys_*xattr() functions.
I don't see a reason to memset the array sent to the functions
sys_llistxattr(), sys_lgetxattr(), sys_lgetxattr(), sys_flistxattr(),
sys_fgetxattr().
(Note: it's unclear to me why we are calling sys_*txattr() functions with
XATTR_VAL_BUF_SIZE-1 size instead of XATTR_VAL_BUF_SIZE ).
Only compile-tested!
Change-Id: Ief2103b56ba6c71e40ed343a93684eef6b771346
updates: bz#1193929
Signed-off-by: Yaniv Kaul <ykaul@redhat.com>
Diffstat (limited to 'libglusterfs/src/client_t.c')
| -rw-r--r-- | libglusterfs/src/client_t.c | 6 |
1 files changed, 0 insertions, 6 deletions
diff --git a/libglusterfs/src/client_t.c b/libglusterfs/src/client_t.c index eb9e7a78b22..844acbc459c 100644 --- a/libglusterfs/src/client_t.c +++ b/libglusterfs/src/client_t.c @@ -598,12 +598,9 @@ client_ctx_del (client_t *client, void *key, void **value) void client_dump (client_t *client, char *prefix) { - char key[GF_DUMP_MAX_BUF_LEN]; - if (!client) return; - memset(key, 0, sizeof key); gf_proc_dump_write("refcount", GF_PRI_ATOMIC, GF_ATOMIC_GET (client->count)); } @@ -641,7 +638,6 @@ clienttable_dump (clienttable_t *clienttable, char *prefix) "Unable to acquire lock"); return; } - memset(key, 0, sizeof key); gf_proc_dump_build_key(key, prefix, "maxclients"); gf_proc_dump_write(key, "%d", clienttable->max_clients); gf_proc_dump_build_key(key, prefix, "first_free"); @@ -792,7 +788,6 @@ gf_client_dump_fdtables (xlator_t *this) clienttable->cliententries[count].next_free) continue; client = clienttable->cliententries[count].client; - memset(key, 0, sizeof key); if (client->client_uid) { gf_proc_dump_build_key (key, "conn", "%d.id", count); @@ -929,7 +924,6 @@ gf_client_dump_inodes (xlator_t *this) clienttable->cliententries[count].next_free) continue; client = clienttable->cliententries[count].client; - memset(key, 0, sizeof key); if (client->bound_xl && client->bound_xl->itable) { /* Presently every brick contains only * one bound_xl for all connections. |